Re: [PATCH] gnu: Add freeimage.

2014-11-04 Thread David Thompson
Ludovic Courtès writes: > David Thompson skribis: > >> From 67515d4f69b7deda45be7fb6e7ebf260d5e0439b Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Mon, 3 Nov 2014 18:26:38 -0500 >> Subject: [PATCH] gnu: freeimage: Remove MIPS from supported-systems. >> >> * gnu/packages/image.scm (f

Re: [PATCH] gnu: Add freeimage.

2014-11-04 Thread Ludovic Courtès
David Thompson skribis: > From 67515d4f69b7deda45be7fb6e7ebf260d5e0439b Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Mon, 3 Nov 2014 18:26:38 -0500 > Subject: [PATCH] gnu: freeimage: Remove MIPS from supported-systems. > > * gnu/packages/image.scm (freeimage): Drop support for "mips64

Re: [PATCH] gnu: Add freeimage.

2014-11-03 Thread David Thompson
Andreas Enge writes: > Unfortunately, it fails to build on mips: >http://hydra.gnu.org/build/136438 > Could you have a look? To me it looks as if there is bad assembly code > in the source: > /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s: Assembler messages: > /tmp/nix-build-freeimage-3.16

Re: [PATCH] gnu: Add freeimage.

2014-11-03 Thread Ludovic Courtès
Andreas Enge skribis: > On Mon, Nov 03, 2014 at 10:00:38AM +0100, Ludovic Courtès wrote: >> Same problem as with Valgrind, so I would suggest disabling builds on >> MIPS, as done in commit 67a86d3. > > Speaking of valgrind, how is transitivity of disabled builds handled, > on hydra and by the use

Re: [PATCH] gnu: Add freeimage.

2014-11-03 Thread Andreas Enge
On Mon, Nov 03, 2014 at 10:00:38AM +0100, Ludovic Courtès wrote: > Same problem as with Valgrind, so I would suggest disabling builds on > MIPS, as done in commit 67a86d3. Speaking of valgrind, how is transitivity of disabled builds handled, on hydra and by the users? I noticed that some packages

Re: [PATCH] gnu: Add freeimage.

2014-11-03 Thread Ludovic Courtès
Andreas Enge skribis: > Could you have a look? To me it looks as if there is bad assembly code > in the source: > /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s: Assembler messages: > /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s:360: Error: opcode not > supported on this processor: mips3 (

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread David Thompson
Andreas Enge writes: > Unfortunately, it fails to build on mips: >http://hydra.gnu.org/build/136438 > Could you have a look? To me it looks as if there is bad assembly code > in the source: > /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s: Assembler messages: > /tmp/nix-build-freeimage-3.16

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread Andreas Enge
Unfortunately, it fails to build on mips: http://hydra.gnu.org/build/136438 Could you have a look? To me it looks as if there is bad assembly code in the source: /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s: Assembler messages: /tmp/nix-build-freeimage-3.16.0.drv-0/cc1WaZEm.s:360: Error: opc

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread David Thompson
Andreas Enge writes: > On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote: >> +'(#:phases (alist-replace >> +'unpack >> +(lambda* (#:key source #:allow-other-keys) >> + (and (zero? (system* "unzip" source)) >> +

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread Andreas Enge
On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote: > +'(#:phases (alist-replace > +'unpack > +(lambda* (#:key source #:allow-other-keys) > + (and (zero? (system* "unzip" source)) > + (chdir "FreeImage"))) > +

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread David Thompson
nds in .zip, while letting it the user’s > responsibility to add unzip as an input when needed (as is already the > case for lzip.) > > But yes, this would be for core-updates. Okay, that does sound like a good idea. >> From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17

Re: [PATCH] gnu: Add freeimage.

2014-11-02 Thread Ludovic Courtès
ut yes, this would be for core-updates. > From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 25 Jun 2014 19:50:30 -0400 > Subject: [PATCH] gnu: Add freeimage. > > * gnu/packages/image.scm (freeimage): New variable. LGTM, OK to push! Ludo’.

Re: [PATCH] gnu: Add freeimage.

2014-11-01 Thread David Thompson
I think that work could/should be saved for a future patch. Updated patch attached. Thanks for the review! >From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001 From: David Thompson Date: Wed, 25 Jun 2014 19:50:30 -0400 Subject: [PATCH] gnu: Add freeimage. * gnu/package

Re: [PATCH] gnu: Add freeimage.

2014-11-01 Thread Andreas Enge
Hello! On Sat, Nov 01, 2014 at 11:48:46AM -0400, David Thompson wrote: > +(uri (string-append > "mirror://sourceforge/freeimage/Source%20Distribution/" > +version "/FreeImage" > +(string-join (string-split version #\.) ""

[PATCH] gnu: Add freeimage.

2014-11-01 Thread David Thompson
This patch adds the freeimage library. It's a handy way to load images of various formats via a single interface. How does it look? >From 908cad8230ecc89dbf36ab54c0687879e4cf9b22 Mon Sep 17 00:00:00 2001 From: David Thompson Date: Wed, 25 Jun 2014 19:50:30 -0400 Subject: [PATCH]