Ludovic Courtès <l...@gnu.org> writes: > David Thompson <dthomps...@worcester.edu> skribis: > >> Andreas Enge <andr...@enge.fr> writes: > > [...] > >>>> + 'unpack >>>> + (lambda* (#:key source #:allow-other-keys) >>>> + (and (zero? (system* "unzip" source)) >>>> + (chdir "FreeImage"))) >>> >>> I wonder if this should not be moved to the standard unpack phase. Can we >>> determine the file format and use the appropriate tool, unzip or tar, >>> automatically? (Assuming that there are no .tar.zip out there, of >>> course.) >> >> I've been thinking about this, too. I don't think I would like the GNU >> build system to depend on unzip since very few packages require it and >> it's not a format that GNU uses, but maybe a procedure that replaced the >> standard unpack phase with one that uses unzip would be nice. I think >> that work could/should be saved for a future patch. > > I think we could change ‘unpack’ in gnu-build-system.scm to invoke unzip > when the file name ends in .zip, while letting it the user’s > responsibility to add unzip as an input when needed (as is already the > case for lzip.) > > But yes, this would be for core-updates.
Okay, that does sound like a good idea. >> From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001 >> From: David Thompson <dthomps...@worcester.edu> >> Date: Wed, 25 Jun 2014 19:50:30 -0400 >> Subject: [PATCH] gnu: Add freeimage. >> >> * gnu/packages/image.scm (freeimage): New variable. > > LGTM, OK to push! Pushed. Thanks! -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate
