Re: [PATCH] Clean all .go in clean-go

2017-11-08 Thread Vincent Legoll
Hello, > Alternatively... how about adding a new make target that also removes > the stray .go files? what about: make mrproper-go Sorry, couldn't resist... -- Vincent Legoll

Re: [PATCH] Clean all .go in clean-go

2017-11-06 Thread myglc2
On 09/16/2016 at 01:15 Eric Bavier writes: > On Fri, 02 Sep 2016 14:42:27 +0200 > l...@gnu.org (Ludovic Courtès) wrote: > >> Eric Bavier skribis: >> >> > On Thu, 01 Sep 2016 14:37:58 +0200 >> > l...@gnu.org (Ludovic Courtès) wrote: >> >> [...] >> >> >> > In regards of the .go files remaining

Re: [PATCH] Clean all .go in clean-go

2016-09-20 Thread Ludovic Courtès
Hi, Eric Bavier skribis: > So, with the attached patch, I get the following output after `make > clean-go`: > > warning: stray .go files: ./guix/scripts/import/cpan.go ./gnu/services/dmd.go > ./gnu/system/linux.go ./gnu/packages/yasm.go ./gnu/packages/cursynth.go > ./gnu/packages/lightning.go .

Re: [PATCH] Clean all .go in clean-go

2016-09-15 Thread Leo Famulari
On Fri, Sep 16, 2016 at 12:15:40AM -0500, Eric Bavier wrote: > Another issue that I thought of that's posed by these stray .go files, > which isn't only a problem when acting as a wizard: introducing a new > module import when adding a package, only to have that module > moved/renamed before pushin

Re: [PATCH] Clean all .go in clean-go

2016-09-15 Thread Eric Bavier
On Fri, 02 Sep 2016 14:42:27 +0200 l...@gnu.org (Ludovic Courtès) wrote: > Eric Bavier skribis: > > > On Thu, 01 Sep 2016 14:37:58 +0200 > > l...@gnu.org (Ludovic Courtès) wrote: > > [...] > > >> > In regards of the .go files remaining in the build directory, I agree > >> > that this is not

Re: [PATCH] Clean all .go in clean-go

2016-09-02 Thread Ludovic Courtès
Eric Bavier skribis: > On Thu, 01 Sep 2016 14:37:58 +0200 > l...@gnu.org (Ludovic Courtès) wrote: [...] >> > In regards of the .go files remaining in the build directory, I agree >> > that this is not good, however I don't think it is worth trying to fix >> > this issue which equally applies to

Re: [PATCH] Clean all .go in clean-go

2016-09-01 Thread Eric Bavier
On Thu, 01 Sep 2016 14:37:58 +0200 l...@gnu.org (Ludovic Courtès) wrote: > Mathieu Lirzin skribis: > > > Eric Bavier writes: > > > >> From: Eric Bavier > >> > >> I encountered a runtime error recently while running `guix system > >> reconfigure`. Thinking this might be because of an ABI bre

Re: [PATCH] Clean all .go in clean-go

2016-09-01 Thread Ludovic Courtès
Mathieu Lirzin skribis: > Eric Bavier writes: > >> From: Eric Bavier >> >> I encountered a runtime error recently while running `guix system >> reconfigure`. Thinking this might be because of an ABI break I ran `make >> clean-go && make` before trying again, with the same result. >> >> It tur

Re: [PATCH] Clean all .go in clean-go

2016-09-01 Thread David Craven
> Using wildcards can be tempting in such cases but it can lead to accidental > file deletions which is worse IMO. If you name what ever file *.go inside of your guix source tree, it's kind of your on fault. > Thinking this might be because of an ABI break I ran `make clean-go && make` > before

Re: [PATCH] Clean all .go in clean-go

2016-08-31 Thread Mathieu Lirzin
Hello, Eric Bavier writes: > From: Eric Bavier > > I encountered a runtime error recently while running `guix system > reconfigure`. Thinking this might be because of an ABI break I ran `make > clean-go && make` before trying again, with the same result. > > It turns out a module had been ren

[PATCH] Clean all .go in clean-go

2016-08-31 Thread Eric Bavier
From: Eric Bavier I encountered a runtime error recently while running `guix system reconfigure`. Thinking this might be because of an ABI break I ran `make clean-go && make` before trying again, with the same result. It turns out a module had been renamed, in this case fish.scm to shells.scm,