Hi, Eric Bavier <ericbav...@openmailbox.org> skribis:
> So, with the attached patch, I get the following output after `make > clean-go`: > > warning: stray .go files: ./guix/scripts/import/cpan.go ./gnu/services/dmd.go > ./gnu/system/linux.go ./gnu/packages/yasm.go ./gnu/packages/cursynth.go > ./gnu/packages/lightning.go ./gnu/packages/doxygen.go ./gnu/packages/tre.go > ./gnu/packages/asciidoc.go ./gnu/packages/texlive.go ./gnu/packages/i3.go > ./gnu/packages/fish.go ./gnu/packages/slim.go ./gnu/packages/tcsh.go > ./gnu/packages/zsh.go ./gnu/packages/lsh.go ./gnu/packages/rc.go > ./gnu/packages/openssl.go ./gnu/packages/aria2.go ./gnu/packages/gdbm.go > ./gnu/packages/gnutls.go ./gnu/packages/grue-hunter.go > ./gnu/packages/aarddict.go Looks good, surely an improvement! > Another issue that I thought of that's posed by these stray .go files, > which isn't only a problem when acting as a wizard: introducing a new > module import when adding a package, only to have that module > moved/renamed before pushing your change. I suppose it is a corner > case, but it did happen to me recently, in 2e3f18511, which 宋文武 > kindly fixed in 19b2ea1b6. The problem was that between the time I > originally packaged tomb and the time I pushed the commit, > gnu/packages/zsh.scm was consolidated into gnu/packages/shells.scm. I > had done a `make clean-go && make` before pushing, as I always do, but > since clean-go didn't remove gnu/packages/zsh.go the subsequent `make` > didn't complain of a missing module. Indeed, that’s happened to me before. > From ffe1710d5a91cd9906f2419d21944b1375b1b842 Mon Sep 17 00:00:00 2001 > From: Eric Bavier <bav...@member.fsf.org> > Date: Thu, 15 Sep 2016 23:31:41 -0500 > Subject: [PATCH] build: clean-go: warn about stray .go files. > > * Makefile.am (clean-go): Warn of .go files remaining in builddir. LGTM, thank you! Ludo’.
