On Thu, May 2, 2013 at 2:17 PM, Mark H Weaver wrote:
> Hi Aleix,
>
> There was one remaining problem with your commit: web-uri.test contained
> some tests that assumed lowercase percent encoding. I took the liberty
> of modifying your commit to fix those tests, and then pushed it to
> stable-2.0.
Hi Aleix,
There was one remaining problem with your commit: web-uri.test contained
some tests that assumed lowercase percent encoding. I took the liberty
of modifying your commit to fix those tests, and then pushed it to
stable-2.0.
Thanks!
Mark
On Thu, May 2, 2013 at 11:53 AM, Mark H Weaver wrote:
> Hi Aleix,
>
> This patch looks good to me, except that I don't like the variable name
> 'num' for a string. Actually, I'm not sure we need to bind that to a
> variable at all. How about just wrapping 'string-upcase' around the
> call to 'nu
Hi Aleix,
This patch looks good to me, except that I don't like the variable name
'num' for a string. Actually, I'm not sure we need to bind that to a
variable at all. How about just wrapping 'string-upcase' around the
call to 'number->string'?
Thanks,
Mark
> @@ -396,11 +396,12
