Hi Aleix,
This patch looks good to me, except that I don't like the variable name
'num' for a string. Actually, I'm not sure we need to bind that to a
variable at all. How about just wrapping 'string-upcase' around the
call to 'number->string'?
Thanks,
Mark
> @@ -396,11 +396,12 @@ hexadecimal representation of the byte."
> (len (bytevector-length bv)))
> (let lp ((i 0))
> (if (< i len)
> - (let ((byte (bytevector-u8-ref bv i)))
> + (let* ((byte (bytevector-u8-ref bv i))
> + (num (number->string byte 16)))
> (display #\% port)
> (when (< byte 16)
> (display #\0 port))
> - (display (number->string byte 16) port)
> + (display (string-upcase num) port)
> (lp (1+ i))))))))
> str)))
> str))
