Re: [PATCH] Improved source properties and errors; => within case

2012-02-11 Thread Ludovic Courtès
Hi Mark, Mark H Weaver skribis: > l...@gnu.org (Ludovic Courtès) writes: >> However, could it be done in the tree-il/analyze.scm instead, along with >> other warning passes? > > The problem is that 'case' does not exist in tree-il. By the time > analyze.scm sees it, 'case' has been transformed

Re: [PATCH] Improved source properties and errors; => within case

2012-02-11 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > However, could it be done in the tree-il/analyze.scm instead, along with > other warning passes? The problem is that 'case' does not exist in tree-il. By the time analyze.scm sees it, 'case' has been transformed into nested 'if's with 'memv's. In theory,

Re: [PATCH] Improved source properties and errors; => within case

2012-02-10 Thread Ludovic Courtès
Hi Mark, Sorry for not replying earlier. Mark H Weaver skribis: > From 849b96dd703315db31f41e01f10a1140391f82c1 Mon Sep 17 00:00:00 2001 > From: Mark H Weaver > Date: Tue, 7 Feb 2012 19:40:29 -0500 > Subject: [PATCH 5/5] Support => within case, and improve error messages for > cond and case >

Re: [PATCH] Improved source properties and errors; => within case

2012-02-08 Thread Mark H Weaver
Hello all, I have committed an improved version of this patch set to stable-2.0. See below for more. I wrote: > Hmm.  I don't know if this is what you meant, but it occurs to me that > as I've currently implemented them, both (cond (else (define x 5) x)) > and (case 1 (else (define x 5) x)) are a

Re: [PATCH] Improved source properties and errors; => within case

2012-02-08 Thread Noah Lavine
Hello, > Hmm.  I don't know if this is what you meant, but it occurs to me that > as I've currently implemented them, both (cond (else (define x 5) x)) > and (case 1 (else (define x 5) x)) are allowed.  I'll have to make sure > that those raise errors.  I guess that means I'll have to insert a '#f

Re: [PATCH] Improved source properties and errors; => within case

2012-02-08 Thread Mark H Weaver
Hi Andy, thanks for the quick review! Andy Wingo writes: > Patch set looks good to me. Please push. Great, thanks! Of course I'll fix the following issues first. > On Wed 08 Feb 2012 10:09, Mark H Weaver writes: > >> The way that source properties are stored means that Guile can only >> -as

Re: [PATCH] Improved source properties and errors; => within case

2012-02-08 Thread Andy Wingo
Heya Mark, Patch set looks good to me. Please push. One comment: On Wed 08 Feb 2012 10:09, Mark H Weaver writes: > The way that source properties are stored means that Guile can only > -associate source properties with parenthesized expressions, and not, for > -example, with individual symbo