Hi Mark, Sorry for not replying earlier.
Mark H Weaver <m...@netris.org> skribis: > From 849b96dd703315db31f41e01f10a1140391f82c1 Mon Sep 17 00:00:00 2001 > From: Mark H Weaver <m...@netris.org> > Date: Tue, 7 Feb 2012 19:40:29 -0500 > Subject: [PATCH 5/5] Support => within case, and improve error messages for > cond and case > > * module/ice-9/boot-9.scm (cond, case): Reimplement using syntax-case, > with improved error messages and support for '=>' within 'case' as > mandated by the R7RS. Add warnings for duplicate case datums and > case datums that cannot be meaningfully compared using 'eqv?'. This looks like a useful addition. However, could it be done in the tree-il/analyze.scm instead, along with other warning passes? The reason I’m asking is that this: > * module/system/base/message.scm (%warning-types): Add 'bad-case-datum' > and 'duplicate-case-datum' warning types. ... is really meant for compiler warnings (see, for instance, the output of ‘guild compile -Whelp’). In particular, whether the warnings are emitted is determined by a #:opts sub-option to ‘compile’. WDYT? In addition, it would be great to have tests for the warnings themselves, as found at the bottom of tree-il.test. Thanks, Ludo’
