Re: Make temp file in coding.test work on MS-Windows

2014-08-13 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: Eli Zaretskii , guile-devel > Date: Tue, 12 Aug 2014 17:35:11 -0400 > > > OK to commit, thanks. > > Please untabify the lines you changed, and use 'string-append' instead > of 'string-concatenate'. Done and pushed.

Re: Make temp file in coding.test work on MS-Windows

2014-08-12 Thread Mark H Weaver
Nala Ginrut writes: > Out of topic, IIRC string-concatenate is faster than string-append. The speed difference between them is surely insignificant, as they both use the same code internally, and anyway efficiency hardly matters in the test suite. The reason for my suggestion was stylistic, but

Re: Make temp file in coding.test work on MS-Windows

2014-08-12 Thread Nala Ginrut
2014年8月13日 上午5:36于 "Mark H Weaver" 写道: > > l...@gnu.org (Ludovic Courtès) writes: > > > Eli Zaretskii skribis: > > > >> I've built Guile 2.0.11 on another system, and found a problem in > >> coding.test: it assumes that /tmp exists, and creates the temporary > >> files there. Here's the patch to

Re: Make temp file in coding.test work on MS-Windows

2014-08-12 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > Eli Zaretskii skribis: > >> I've built Guile 2.0.11 on another system, and found a problem in >> coding.test: it assumes that /tmp exists, and creates the temporary >> files there. Here's the patch to make that more portable: >> >> --- test-suite/tests/co

Re: Make temp file in coding.test work on MS-Windows

2014-08-12 Thread Ludovic Courtès
Eli Zaretskii skribis: > I've built Guile 2.0.11 on another system, and found a problem in > coding.test: it assumes that /tmp exists, and creates the temporary > files there. Here's the patch to make that more portable: > > --- test-suite/tests/coding.test~02014-01-21 23:45:02.0 +02

Make temp file in coding.test work on MS-Windows

2014-08-09 Thread Eli Zaretskii
I've built Guile 2.0.11 on another system, and found a problem in coding.test: it assumes that /tmp exists, and creates the temporary files there. Here's the patch to make that more portable: --- test-suite/tests/coding.test~0 2014-01-21 23:45:02.0 +0200 +++ test-suite/tests/coding.t