Re: Guile 1.7.91 has been released.

2006-02-13 Thread Kevin Ryde
Oops, I see opendir doesn't record the opened directoryname. Hmm. It might be easiest for now to just stick a mutex around plain readdir() and worry later about readdir_r and its buffer size. ___ Guile-devel mailing list Guile-devel@gnu.org http://lis

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Kevin Ryde
"Bill Schottstaedt" <[EMAIL PROTECTED]> writes: > > I found some examples by Googling for readdir_r and _PC_NAME_MAX. Incomplete bit of code below, it's not pretty but I guess it's what has to be done. #if HAVE_READDIR_R /* On Solaris 2.7, struct dirent only contains "char d_name[1]" and the

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Bill Schottstaedt
Yes, here's the relevent portion of man readdir_r: The caller must allocate storage pointed to by entry to be large enough for a dirent structure with an array of char d_name member containing at least NAME_MAX (that is, pathconf(directory, _PC_NAME_MAX)) plus on

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Kevin Ryde
"Bill Schottstaedt" <[EMAIL PROTECTED]> writes: > > (The d_name field is still defined to be 1 char long, so I think the > glibc comment still pertains to Solaris, I guess that means you can't just define a struct. What does the readdir_r man page say you should do? pathconf like you said? ___

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Bill Schottstaedt
I don't think NAME_MAX is defined anywhere -- the documentation says you should use pathconf instead. Here's the portion of limits.h where they commented out NAME_MAX: /* * POSIX 1003.1a, section 2.9.5, table 2-5 contains [NAME_MAX] and the * related text states: * * A definition of one of th

Re: [PATCH] Fixed `scm_i_take_stringbufn ()'

2006-02-13 Thread Kevin Ryde
[EMAIL PROTECTED] (Ludovic Courtès) writes: > > Note: I'm not sure what to do with `assert ()'. "Don't do that", to coin a phrase. > Perhaps we should define our own macro somewhere? The `if' you put, with an fprintf stderr, should be fine. ___ Guile

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Kevin Ryde
"Bill Schottstaedt" <[EMAIL PROTECTED]> writes: > > filesys.c:860: error: `NAME_MAX' undeclared (first use in this function) > > union { > struct dirent ent; > char pad1 [sizeof(struct dirent) + NAME_MAX]; > char pad2 [offsetof (struct dirent, d_name) + NAME_MAX + 1]; This is

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Marius Vollmer
[EMAIL PROTECTED] (Ludovic Courtès) writes: > BTW, I'd strongly recommend using SHA1 sums (e.g., via `sha1sum', part > of GNU Coreutils) rather than MD5. Yeah, that's probably best. > See the example at http://www.cits.rub.de/MD5Collisions/ if in > doubt. ;-) Well, they get to choose both text

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Bill Schottstaedt
I was trying to build the new guile on a MacIntel box, got this error in gmp: tmp-dive_1.s:98:invalid character '@' in first operand make[2]: *** [dive_1.lo] Error 1 I sent a bug report to the gmp bug list and got this reply: Date: 13 Feb 2006 17:26:45 +0100 From: Torbjorn Granl

[PATCH] Fixed `scm_i_take_stringbufn ()'

2006-02-13 Thread Ludovic Courtès
Hi, The patch below fixes `scm_i_take_stringbufn ()' so that it registers the right amount of collectable memory. Failing to do so, an underflow was triggered in `decrease_mtrigger ()' (when decreasing SCM_MALLOCATED), resulting in a weird behavior (typically: fast increase in memory consumption

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Bill Schottstaedt
In Linux FC4 dual x86-64, trying to build Guile 1.7.91 I get: creating guile cat alist.doc arbiters.doc async.doc backtrace.doc boolean.doc chars.doc continuations.doc debug.doc deprecation.doc deprecated.doc discouraged.doc dynl.doc dynwind.doc environments .doc eq.doc error.doc eval.doc evale

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Bill Schottstaedt
In solaris 10, I think the readdir_r usage is incorrect. gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -g -O2 -Wall -Wmissing-prototypes -MT filesys.lo -MD - MP -MF .deps/filesy s.Tpo -c filesys.c -fPIC -DPIC -o .libs/filesys.o filesys.c: In function `scm_readdir': filesys.c:860: error: `NAME_MAX'

Re: Guile 1.7.91 has been released.

2006-02-13 Thread Ludovic Courtès
Hi, Marius Vollmer <[EMAIL PROTECTED]> writes: > We are pleased to announce the release of Guile 1.7.91. This is a > release candidate for Guile 1.8. It can be found here: > > ftp://alpha.gnu.org/gnu/guile/guile-1.7.91.tar.gz FYI, on `powerpc-unknown-linux-gnu', everything seems to work fi

Re: Another load path idea

2006-02-13 Thread Ludovic Courtès
Hi, Marius Vollmer <[EMAIL PROTECTED]> writes: > Hmm, I'm inclined not to put this into 1.8, at least not in 1.8.0. I > can't really put my finger on it, as I see nothing fundamental wrong > with the patch, but I also don't see the immediate need for it. That > is probably because I haven't fol

[Ludovic Courtès] Re: [PATCH] GC code cleanup #2

2006-02-13 Thread Ludovic Courtès
Hello, I'm resending the GC-cleanup patch in a hopefully more readable form. Han-Wen: let me know if it's alright. Thanks, Ludovic. --- Begin Message --- Hi, [EMAIL PROTECTED] (Han-Wen Nienhuys) writes: >> void >>-scm_i_adjust_min_yield (scm_t_cell_type_statistics *freelist) >>+scm_i_adjust_mi