Re: [PATCH v2 4/5] Add -k, --pubkey=FILE support to grub-install command

2013-09-06 Thread Jonathan McCune
Good points, I'll fix these and send a new version of the patch after I hear what folks think about the more substantial changes. On Fri, Sep 6, 2013 at 12:40 PM, Andrey Borzenkov wrote: > В Fri, 6 Sep 2013 09:18:52 -0700 > Jon McCune пишет: > > > > +pubkey_file_arg="" > > +if [ -e "$pubkey_fil

Re: [PATCH v2 2/5] load_env support for whitelisting which variables are read from an env file, even if check_signatures=enforce

2013-09-06 Thread Jonathan McCune
Thanks for the feedback, inline: On Fri, Sep 6, 2013 at 12:48 PM, Andrey Borzenkov wrote: > В Fri, 6 Sep 2013 09:18:50 -0700 > Jon McCune пишет: > > > This works by adding an open_envblk_file_untrusted() method that bypasses > > signature checking, but only if the invocation of load_env include

Re: [PATCH v2 2/5] load_env support for whitelisting which variables are read from an env file, even if check_signatures=enforce

2013-09-09 Thread Jonathan McCune
On Sat, Sep 7, 2013 at 2:33 AM, Andrey Borzenkov wrote: > В Fri, 6 Sep 2013 14:10:01 -0700 > Jonathan McCune пишет: > > > Thanks for the feedback, inline: > > > > On Fri, Sep 6, 2013 at 12:48 PM, Andrey Borzenkov >wrote: > > > > > В Fri, 6 Se

Re: [PATCH v2 2/5] load_env support for whitelisting which variables are read from an env file, even if check_signatures=enforce

2013-09-19 Thread Jonathan McCune
don't completely make sense, as I was trying to react to Andrey's feedback before he realized the whitelist wasn't already implemented. Thanks, -Jon On Thu, Sep 19, 2013 at 3:12 AM, Andrey Borzenkov wrote: > В Mon, 9 Sep 2013 08:34:10 -0700 > Jonathan McCune пишет: &g

Re: Best practices for bisecting GRUB and cherry-picking?

2014-11-06 Thread Jonathan McCune
If you're just trying to identify where the problem was introduced, and don't mind working from a cloned repository, you can use git's "filter-branch" to rewrite a clone of the repo to be as though the Changelog file never existed. git clone git://git.savannah.gnu.org/grub.git grub-upstream git cl

Re: Remotely choose a menu entry

2014-12-01 Thread Jonathan McCune
Some half-baked thoughts: On Mon, Dec 1, 2014 at 4:03 AM, Brugnara Daniele wrote: > You have simply misunderstood me. I'm trying to explain deeply :) > > When grub starts, it asks for a choice, lets take this, as an example: > > 1) Linux > 2) Linux (mem test ecc) > 3) Windows 7 > 4) Windows Serv

Re: Deterministic grub-mkimage

2014-12-28 Thread Jonathan McCune
On Sun, Dec 28, 2014 at 3:24 AM, Andrew Clausen wrote: > Hi all, > > Deterministic software builds are helpful for spotting and preventing > malicious modifications such as inserting back-doors. > Agree. > At the moment, grub builds are mostly deterministic. However, > grub-mkimage does not d

Re: Deterministic grub-mkimage

2014-12-29 Thread Jonathan McCune
On Mon, Dec 29, 2014 at 3:08 AM, Andrew Clausen wrote: > Hi Jonathan, > > On 29 December 2014 at 06:29, Jonathan McCune > wrote: > >> One solution would be to: > >> * build deterministically by default by using a constant timestamp, and > > > > I t

Re: test command and signature checks

2015-01-29 Thread Jonathan McCune
On Jan 29, 2015 1:19 AM, "Andrei Borzenkov" wrote: > > What sematic of file tests should be? I think they should just test > file existence; this already happens for compressed files that checks > that on-disk file size, not uncompressed. I think same should apply to > signature checks. > Where t

Re: test command and signature checks

2015-01-29 Thread Jonathan McCune
On Thu, Jan 29, 2015 at 7:19 AM, Andrei Borzenkov wrote: > В Thu, 29 Jan 2015 06:17:42 -0800 > Jonathan McCune пишет: > > > On Jan 29, 2015 1:19 AM, "Andrei Borzenkov" wrote: > > > > > > What sematic of file tests should be? I think they should j

selecting the right python to use

2015-03-05 Thread Jonathan McCune
Some installations have several python versions installed. This patch allows the user to choose which one to use by setting $PYTHON, otherwise it falls back to 'python'. Signed-off-by: Jon McCune Thanks, -Jon Author: Jon McCune autogen.sh: Allow overriding the python to be used by setting

Re: selecting the right python to use

2015-03-06 Thread Jonathan McCune
On Thu, Mar 5, 2015 at 7:37 PM, Andrei Borzenkov wrote: > В Thu, 5 Mar 2015 14:27:18 -0800 > Jonathan McCune пишет: > > > Some installations have several python versions installed. This patch > > allows the user to choose which one to use by setting $PYTHON, otherwise &