Good points, I'll fix these and send a new version of the patch after I hear what folks think about the more substantial changes.
On Fri, Sep 6, 2013 at 12:40 PM, Andrey Borzenkov <arvidj...@gmail.com>wrote: > В Fri, 6 Sep 2013 09:18:52 -0700 > Jon McCune <jonmcc...@google.com> пишет: > > > > +pubkey_file_arg="" > > +if [ -e "$pubkey_file" ]; then > > + pubkey_file_arg="--pubkey=$pubkey_file" > > +fi > > + > > You should return an error if file does not exist, not silently ignore > it. Will fix. > > + --pubkey | -k) > > + pubkey_file=`argument $option "$@"`; > grub_process_install_options_consumed=2 ;; > > + --pubkey=*) > > + pubkey_file=`echo "$option" | sed 's/--pubkey=//'` > grub_process_install_options_consumed=1;; > > grub-mkimage supports multiple keys. This will work only for exactly > one. > > Will fix. Thanks, -Jon
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
