https://erofs.docs.kernel.org
Reviewed-by: Glenn Washburn
Reviewed-by: Gao Xiang
Did they review the patch set here? If no these lines should be dropped.
If yes they should go behind Signed-off-by below...
Thanks for the reply!
As for Glenn's review, see:
https://lore.kernel.org/
Thanks for your confirmation, yes, that would be better to address
the diff part. Hopefully Yifan could address these in the next
version.
Thanks,
Gao Xiang
Glenn
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
4->v5 diff, it still looks good to me,
Reviewed-by: Gao Xiang
BTW, Glenn, would you mind taking some time checking if
this version looks good to you? Thanks a lot!
Thanks,
Gao Xiang
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org
Hi Gleen, Daniel,
On 2024/4/5 04:56, Daniel Kiper wrote:
On Wed, Mar 06, 2024 at 10:18:21AM +0800, Gao Xiang wrote:
On 2024/3/4 01:15, Yifan Zhao wrote:
EROFS [1] is a lightweight read-only filesystem designed for performance
which has already been shipped in most Linux distributions as well
n his leisure time) so that kernel/initrd can be loaded then..
Any comment would be much helpful.
Thanks,
Gao Xiang
Yifan Zhao (2):
fs/erofs: Add support for EROFS
fs/erofs: Add tests for EROFS in grub-fs-tester
.gitignore | 1 +
INSTALL
mmit 2):
https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html
Does this version look good you? Could you help take some
time look at the latest version if possible?
Thanks,
Gao Xiang
Yifan Zhao (2):
fs/erofs: Add support for EROFS
fs/erofs: Add tests for EROFS in grub-fs-teste
of
(data->sb.volume_name));
956 if (!*label)
CID 460610: Resource leaks (RESOURCE_LEAK)
Variable "data" going out of scope leaks the storage it points to.
957 return grub_errno;
958
959 grub_free (data);
Will fix as below:
@@ -953,11 +955,10 @@ grub_erofs_label
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn Washburn
Signed-off-by: Gao Xiang
---
Reviewed-by Link:
https://lists.gnu.org/archive/html/grub-devel/2024
EROFS [1] is a lightweight read-only filesystem designed for performance
which has already been shipped in most Linux distributions as well as widely
used in several scenarios, such as Android system partitions, container
images, and rootfs for embedded devices.
This patch brings EROFS uncompresse
igned-off-by: Gao Xiang
---
Tested-by Link:
https://lists.gnu.org/archive/html/grub-devel/2024-05/msg1.html
INSTALL |8 +-
Makefile.util.def |1 +
docs/grub.texi |3 +-
grub-core/Makefile.core.def |5 +
grub-core/fs/erofs.c|
On 2024/5/17 05:37, Daniel Kiper wrote:
On Fri, May 10, 2024 at 08:52:56AM +0800, Gao Xiang wrote:
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn
Hi Daniel,
On 2024/5/17 05:33, Daniel Kiper wrote:
On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote:
...
In general patch LGTM except some nits...
Thanks for the comments. Let me address them.
---
Tested-by Link:
https://lists.gnu.org/archive/html/grub-devel/2024-05
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Signed-off-by: Gao Xiang
---
.gitignore | 1
igned-off-by: Gao Xiang
---
INSTALL |8 +-
Makefile.util.def |1 +
docs/grub.texi |3 +-
grub-core/Makefile.core.def |5 +
grub-core/fs/erofs.c| 1002 +++
5 files changed, 1014 insertions(+), 5 dele
Hi folks,
EROFS [1] is a lightweight read-only filesystem designed for performance
which has already been shipped in most Linux distributions as well as widely
used in several scenarios, such as Android system partitions, container
images, and rootfs for embedded devices.
This patch brings EROFS
Hi Daniel,
On 2024/5/17 08:34, Gao Xiang wrote:
Hi Daniel,
On 2024/5/17 05:33, Daniel Kiper wrote:
On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote:
...
In general patch LGTM except some nits...
Thanks for the comments. Let me address them.
I've addressed your comments
Hi Daniel,
On 2024/5/17 18:22, Daniel Kiper wrote:
On Fri, May 17, 2024 at 12:40:53PM +0800, Gao Xiang wrote:
From: Yifan Zhao
EROFS [1] is a lightweight read-only filesystem designed for performance
which has already been shipped in most Linux distributions as well as widely
used in several
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Signed-off-by: Gao Xiang
---
include/grub/safemath.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/grub/safemath.h b/include/grub/safemath.h
index fbd9b5925..baaea0ef4 100644
mit 2):
https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html
Reviewed-by Link (Commit 2):
https://lore.kernel.org/grub-devel/zkz8fdd+zckt+...@tomti.i.net-space.pl/
Gao Xiang (1):
safemath: Add ALIGN_UP_OVF() that checks for {over,under}flow
Yifan Zhao (2):
fs/erofs: Add suppor
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Signed-off-by: Gao Xiang
---
.gitignore | 1
igned-off-by: Gao Xiang
---
INSTALL |8 +-
Makefile.util.def |1 +
docs/grub.texi |3 +-
grub-core/Makefile.core.def |5 +
grub-core/fs/erofs.c| 1000 +++
5 files changed, 1012 insertions(+), 5 dele
On 2024/5/17 20:17, Gao Xiang wrote:
Hi folks,
EROFS [1] is a lightweight read-only filesystem designed for performance
which has already been shipped in most Linux distributions as well as widely
used in several scenarios, such as Android system partitions, container
images, and rootfs for
/grub-devel/2024-05/msg1.html
Reviewed-by Link (Commit 2):
https://lists.gnu.org/archive/html/grub-devel/2024-04/msg00101.html
Reviewed-by Link (Commit 2):
https://lore.kernel.org/grub-devel/zkz8fdd+zckt+...@tomti.i.net-space.pl/
Gao Xiang (1):
safemath: Add ALIGN_UP_OVF() that checks for
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Signed-off-by: Gao Xiang
---
.gitignore | 1
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Signed-off-by: Gao Xiang
---
include/grub/safemath.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/grub/safemath.h b/include/grub/safemath.h
index fbd9b5925..baaea0ef4 100644
igned-off-by: Gao Xiang
---
INSTALL |8 +-
Makefile.util.def |1 +
docs/grub.texi |3 +-
grub-core/Makefile.core.def |5 +
grub-core/fs/erofs.c| 1000 +++
5 files changed, 1012 insertions(+), 5 dele
d do for this first series for upstreaming and we
could move forward to the next step..
Thanks,
Gao Xiang
Le ven. 17 mai 2024, 15:56, Gao Xiang mailto:hsiang...@linux.alibaba.com>> a écrit :
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Si
On 2024/5/18 17:20, Vladimir 'phcoder' Serbinenko wrote:
Le ven. 17 mai 2024, 21:26, Gao Xiang mailto:hsiang...@linux.alibaba.com>> a écrit :
Hi Vladimir,
On 2024/5/18 00:38, Vladimir 'phcoder' Serbinenko wrote:
> I think that given that align is
/8f2512f9-e851-467c-bbb8-450bf0219...@gmail.com/
Thanks in advance.
Thanks,
Gao Xiang
On 2024/5/19 11:21, Gao Xiang wrote:
On 2024/5/18 17:20, Vladimir 'phcoder' Serbinenko wrote:
Le ven. 17 mai 2024, 21:26, Gao Xiang mailto:hsiang...@linux.alibaba.com>> a écrit :
Hi V
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Signed-off-by: Gao Xiang
---
Hi Daniel,
I've also made another patch to conform Vladimir's and
Boyang's comments as much as I can.
Thanks,
Gao Xiang
include/grub/safemath.h | 16 +
Hi Daniel and all,
On 2024/5/21 00:53, Daniel Kiper wrote:
On Sun, May 19, 2024 at 11:48:24AM +0800, Gao Xiang wrote:
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Signed-off-by: Gao Xiang
I think Vladimir is right.
Thanks for your confirmation
00101.html
Reviewed-by Link (Commit 3):
https://lore.kernel.org/grub-devel/zkz8fdd+zckt+...@tomti.i.net-space.pl/
Gao Xiang (1):
safemath: Add ALIGN_UP_OVF() that checks for {over,under}flow
Yifan Zhao (2):
fs/erofs: Add support for EROFS
fs/erofs: Add tests for EROFS in grub-fs-t
The following EROFS patch will use this helper to handle overflow
ALIGN_UP() cases.
Reviewed-by: Daniel Kiper
Signed-off-by: Gao Xiang
---
include/grub/safemath.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/grub/safemath.h b/include/grub/safemath.h
index
From: Yifan Zhao
In this patch, three tests of EROFS are introduced and they cover
compact, extended and chunk-based inodes, respectively.
Signed-off-by: Yifan Zhao
Reviewed-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Signed-off-by: Gao Xiang
---
.gitignore | 1
igned-off-by: Gao Xiang
---
INSTALL |8 +-
Makefile.util.def |1 +
docs/grub.texi |3 +-
grub-core/Makefile.core.def |5 +
grub-core/fs/erofs.c| 1000 +++
5 files changed, 1012 insertions(+), 5 dele
On 2024/9/2 08:22, Vladimir Serbinenko wrote:
Otherwise depending on compiler we end up with umoddi3 reference and
failed module dependency resolution
Signed-off-by: Vladimir Serbinenko
Reviewed-by: Gao Xiang
Thanks,
Gao Xiang
___
Grub-devel
r
partition for this.
seems that GRUB is being released every couple years.
Ok, I think if we missed this release, we will wait for another two years.
Thanks,
Gao Xiang
When you create an updated patch series, it would be much appreciated if you
use --range-diff or --interdiff so that revie
OFS_MAP_META 0x01
#define EROFS_MAP_MAPPED0x02
Otherwise it looks good to me too, please fix the nits above:
Reviewed-by: Gao Xiang
Thanks,
Gao Xiang
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
arate module. But I prefer the
separate module approach. Perhaps Daniel can speak to his preferred> method.
same here.
Thanks,
Gao Xiang
Glenn
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Hi,
On 2023/9/8 03:57, Daniel Kiper wrote:
Hi Gao,
On Wed, Sep 06, 2023 at 01:46:25PM +0800, Gao Xiang wrote:
Hi Daniel,
On 2023/7/21 01:37, Glenn Washburn wrote:
On Thu, 20 Jul 2023 21:14:22 +0800
wrote:
Thank you for the reply!
As Xiang pointed out, we believe that uncompressed
Hi Daniel,
On Fri, Sep 08, 2023 at 10:04:53AM +0800, Gao Xiang wrote:
> Hi,
>
> On 2023/9/8 03:57, Daniel Kiper wrote:
> > Hi Gao,
> >
> > On Wed, Sep 06, 2023 at 01:46:25PM +0800, Gao Xiang wrote:
> > > Hi Daniel,
> > >
> > > On 2023/7/
On 2023/12/27 21:10, Daniel Kiper wrote:
Hi Gao,
On Mon, Dec 25, 2023 at 03:26:28PM +0800, Gao Xiang wrote:
Hi Daniel,
[...]
It seems that GRUB 2.12 has been always released. Is it possible to
consider this to the upstream?
Sure thing. Though there is a holiday season here. So, expect
42 matches
Mail list logo
