Hi Glenn,
On 2024/3/1 04:52, Glenn Washburn wrote:
Hi Yifan,
I would suggest that the next version of this series have a cover
letter which includes the output of --range-diff or --interdiff (as
appropriate). Cover letters for multipatch submissions are standard on
this list. They allow the tracking of what changed in series revisions.
Please see recent cover letter on this list with subject "[PATCH v9
00/22] Automatic Disk Unlock with TPM2" as an example. Including the
diff from the last version of the series allows the reviewer to easily
see what changed. For instance, I did review the (I think) first
version of the series, but I don't have the time to review this series
from scratch right now. I might have been able to review it again just
looking at the diffs. By making things easier for the review you
increase the chances that someone will review the series.
Thanks for your confirmation, yes, that would be better to address
the diff part. Hopefully Yifan could address these in the next
version.
Thanks,
Gao Xiang
Glenn
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
