On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote:
> When building GRUB with memory management debugging enabled, then the
> build fails because of `grub_debug_malloc()` and `grub_debug_free()`
> being undefined in the luks2 module. The cause is that we patch
> "base64.h" to uncond
On Fri, Mar 06, 2020 at 02:37:43PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit :
>
> > Re-adding grub-devel@gnu.org...
> >
> > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko
On Sat, Mar 07, 2020 at 12:59:31AM -0500, David Michael wrote:
> This provides the node's attributes outside the iterator function
> so the file modification time can be accessed and reported.
>
> Signed-off-by: David Michael
Reviewed-by: Dani
On Sat, Mar 07, 2020 at 12:59:52AM -0500, David Michael wrote:
> This allows comparing file ages on EFI system partitions.
>
> Signed-off-by: David Michael
Reviewed-by: Daniel Kiper
...except...
> ---
>
> Changes since v2:
> * Added comments referencing the specs
>
On Mon, Mar 09, 2020 at 01:01:51PM +0100, Patrick Steinhardt wrote:
> On Mon, Mar 09, 2020 at 12:19:15PM +0100, Daniel Kiper wrote:
> > On Sat, Mar 07, 2020 at 05:29:09PM +0100, Patrick Steinhardt wrote:
> > > When building GRUB with memory management debugging enabled, then the
On Mon, Mar 09, 2020 at 01:22:34PM +0100, Patrick Steinhardt wrote:
> On Mon, Mar 09, 2020 at 12:18:41PM +0100, Paul Menzel wrote:
> > Dear Patrick,
> >
> > On 2020-03-07 17:29, Patrick Steinhardt wrote:
> > > The memory management system supports a debug mode that can be enabled
> > > at build tim
Hi Olaf,
CC-ing Peter...
On Wed, Mar 11, 2020 at 08:44:33AM +0100, Olaf Hering wrote:
> I understand that grub.git#master does (most likely) compile for everyone
> else:
>
> [ 135s] + env CFLAGS=-Wall CXXFLAGS=-Wall FFLAGS=-Wall
> ../grub2-src/configure --target=i386-suse-linux --with-platform
On Tue, Mar 03, 2020 at 06:26:03PM +0100, Daniel Kiper wrote:
> On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote:
> > Hi all,
> >
> > As I told during my FOSDEM 2020 presentation we are preparing for
> > GRUB 2.06 release. Tentative schedule is below:
> &g
Adding Michael, Mihai, Javier and Peter...
Below you can find what more or less Vladimir and I agreed WRT small MBR
gap. In general Vladimir convinced me to phase out small MBR gaps
support gradually. This is first step in this journey. We think that we
have to build some warnings into the code an
On Wed, Mar 11, 2020 at 04:57:13PM +0100, Javier Martinez Canillas wrote:
> On 3/11/20 4:41 PM, Olaf Hering wrote:
> > Am Wed, 11 Mar 2020 12:30:01 +0100
> > schrieb Javier Martinez Canillas :
> >
> >> +#if !(defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L))
> >
> > This does not help. I
On Thu, Mar 12, 2020 at 07:20:22PM +0100, Olaf Hering wrote:
> Am Thu, 12 Mar 2020 19:01:26 +0100
> schrieb Daniel Kiper :
>
> > Olaf, could you try the patch in the attachment?
>
> Yes, this fixes the compile errors. Thanks.
Great! So, I will post proper patch probably at
On Fri, Mar 13, 2020 at 12:02:50PM +0100, Olaf Hering wrote:
> With code like this, the resulting kernel cmdline has backslashes before
> either ' or ".
> I think var="\"str\"" or var="'str'" has to be used to place either " or '
> into the variable.
> How can I avoid the backslash in the kernel
On Wed, Mar 04, 2020 at 02:44:52PM +0800, Michael Chang wrote:
> The lvm cache logical volume is the logical volume consisting of the original
> and the cache pool logical volume. The original is usually on a larger and
> slower storage device while the cache pool is on a smaller and faster one. Th
On Wed, Mar 04, 2020 at 02:44:53PM +0800, Michael Chang wrote:
> Add notes on LVM cache booting to the GRUB manual to help user understanding
> the outstanding issue and status.
>
> Signed-off-by: Michael Chang
Reviewed-by: Daniel Ki
On Tue, Mar 10, 2020 at 07:58:28PM +0100, Patrick Steinhardt wrote:
> By default, GRUB will allocate a quarter of the pages it got available
> in the EFI subsystem. On many current systems, this will amount to
> roughly 800MB of RAM assuming an address space of 32 bits. This is
> plenty for most us
On Tue, Mar 10, 2020 at 07:58:29PM +0100, Patrick Steinhardt wrote:
> For the upcoming import of the Argon2 library, we need the macros
> GRUB_UINT32_MAX, GRUB_UINT32_C and GRUB_UINT64_C. Add them as a
> preparatory step.
>
> Signed-off-by: Patrick Steinhardt
Reviewed-by: Daniel
On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote:
> In order to support the Argon2 key derival function for LUKS2, we
> obviously need to implement Argon2. It doesn't make a lot of sense to
> hand-code any crypto, which is why this commit instead imports Argon2
> from the cryptset
On Fri, Mar 13, 2020 at 12:55:08PM +, Leif Lindholm wrote:
> On Tue, Mar 10, 2020 at 19:58:28 +0100, Patrick Steinhardt wrote:
> > By default, GRUB will allocate a quarter of the pages it got available
> > in the EFI subsystem. On many current systems, this will amount to
> > roughly 800MB of R
On Fri, Mar 13, 2020 at 01:32:12PM +0100, Olaf Hering wrote:
> Am Fri, 13 Mar 2020 12:59:32 +0100
> schrieb Daniel Kiper :
>
> > Both var="\"str\"" and var="'str'" should work. Does not they? Do you
> > still get backslashes in ${cmdli
On Fri, Mar 13, 2020 at 03:20:08PM +0100, Olaf Hering wrote:
> Am Fri, 13 Mar 2020 15:07:57 +0100
> schrieb Daniel Kiper :
>
> > Anyway, could you check what is going on and prepare a patch if needed?
>
> Sure I can wipe the offending lines from grub_create_loader_cmdline
On Wed, Mar 11, 2020 at 11:47:35AM +0100, Daniel Kiper wrote:
> On Tue, Mar 03, 2020 at 06:26:03PM +0100, Daniel Kiper wrote:
> > On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote:
> > > Hi all,
> > >
> > > As I told during my FOSDEM 2020 presenta
On Fri, Mar 13, 2020 at 02:13:49PM +0100, Daniel Kiper wrote:
> On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote:
> > In order to support the Argon2 key derival function for LUKS2, we
> > obviously need to implement Argon2. It doesn't make a lot of sense
On Mon, Mar 16, 2020 at 06:52:30PM +0100, Patrick Steinhardt wrote:
> On Mon, Mar 16, 2020 at 06:21:06PM +0100, Daniel Kiper wrote:
> > On Fri, Mar 13, 2020 at 02:13:49PM +0100, Daniel Kiper wrote:
> > > On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote:
&
Hi Paul,
On Wed, Mar 11, 2020 at 10:37:08AM -0700, Paul Dagnelie wrote:
> Hey all, I previously discussed my concept for this patch in my email
> https://lists.gnu.org/archive/html/grub-devel/2020-01/msg4.html .
> I'm pleased to announce that I've gotten it into a working state and
> it is rea
Hi Patrick,
On Tue, Mar 10, 2020 at 07:58:27PM +0100, Patrick Steinhardt wrote:
> Hi,
>
> this is the third version of my patchset to support the Argon2 KDF in
> LUKS2. The following things have changed in comparison to v2:
>
> - Improved the GRUB_UINT_C macros to not use `elif 1` and fixed
>
1 20191008
>
> This issue is not present on:
> Ubuntu 19.10 with gcc (Ubuntu 7.5.0-3ubuntu1~19.10) 7.5.0
> RHEL 8.0 with gcc 8.3.1 20190507 (Red Hat 8.3.1-4)
>
> The issue can be fixed by removing the section using objcopy as shown in this
> patch:
>
&
gt; > Signed-off-by: Jia Zhang
> > Signed-off-by: Tianjia Zhang
> > ---
>
> Reviewed-by: Javier Martinez Canillas
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote:
> When the platform is EFI platform, use 'linuxefi' and 'initrdefi'
> commands instead of 'linux' and 'initrd'.
>
> Signed-off-by: Jia Zhang
> Signed-off-by: Tianjia Zhang
Sorry, NAK! We do not want more "linuxefi" kinda commands in
ray, or 0x for a
> spare, or 0xfffe for faulty. */
> | ^
> ../../grub-core/disk/mdraid1x_linux.c:127:33: note: defined here 'sb'
> 127 | struct grub_raid_super_1x sb;
> | ^~
> cc1: all warning
On Tue, Mar 17, 2020 at 07:56:14PM +0100, Olaf Hering wrote:
> A http transfer will hang if an unhandled error is returned.
> The error branch returns the value zero, which is not expected by the caller.
>
> Signed-off-by: Olaf Hering
> ---
> grub-core/net/http.c | 2 +-
> 1 file changed, 1 inser
rs in l_hash[0] array that triggers the diagnose.
>
> Given that the l_entries[0] is used to get proper alignment to access
> leaf chunks, we can accomplish the same thing through the ALIGN_UP macro
> thus eliminating l_entries[0] from the structure. In this wa
On Wed, Mar 25, 2020 at 08:30:38PM +0100, Olaf Hering wrote:
> Am Wed, 25 Mar 2020 19:55:47 +0100
> schrieb Daniel Kiper :
>
> > Should not we do the same for 404, file not found, a few lines above?
>
> Maybe. For some reason a 404 returns quickly, while a 400 will request
>
CC-ing Vladimir...
On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote:
> Hi Olaf,
>
> The patch rang a bell to me and eventually I figured out that I had
> similar patch posted.
>
> https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html
Yeah, it looks that it fell through
> #define GRUB_EFI_GLOBAL_VARIABLE_GUID \
> > >> - { 0x8BE4DF61, 0x93CA, 0x11d2, { 0xAA, 0x0D, 0x00, 0xE0, 0x98, 0x03,
> > >> 0x2B,0x8C }}
> > >> + { 0x8BE4DF61, 0x93CA, 0x11d2, { 0xAA, 0x0D, 0x00, 0xE0, 0x98, 0x03,
> > >> 0x2B, 0x8C }}
I will
On Thu, Mar 26, 2020 at 04:10:05AM -0700, PGNet Dev wrote:
> On 3/26/20 1:39 AM, Paul Menzel wrote:
>
> > I am unable to reproduce this with
>
> 1st sanity re-check:
>
>
>
> I _am_ able to reproduce this consistently, with same error.
>
>
>
> I've tested now on multiple machines; not identical, but
Adding Alex...
On Fri, Mar 27, 2020 at 03:01:15PM +0800, Bin Meng wrote:
> Hi,
>
> I tried to build RISC-V 32-bit UEFI target using kernel.org riscv64 toolchain:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_riscv64-linux.tar.xz
>
> $ ./config
k mode which is sensitive to data lost in nature, I'd
> still like to propose my (relatively simple) patch and treat reading dirty
> cache as improvement.
>
> Signed-off-by: Michael Chang
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Fri, Mar 27, 2020 at 10:44:09AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 25, 2020 at 06:38:54PM +0100, Daniel Kiper wrote:
> > On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote:
> > > When the platform is EFI platform, use 'linuxefi' and '
On Wed, Mar 25, 2020 at 06:35:00PM +0100, Daniel Kiper wrote:
> On Mon, Mar 23, 2020 at 07:22:43PM +0100, Javier Martinez Canillas wrote:
> > Hello Tianjia,
> >
> > On 3/23/20 12:52 PM, Tianjia Zhang wrote:
> > > The memory requested for the event is not released he
On Fri, Mar 27, 2020 at 08:38:04AM -0700, PGNet Dev wrote:
> On 3/27/20 7:45 AM, Daniel Kiper wrote:
> >> _is_ a 'clear' env expected/recommended/required for a grub2 build?
> >
> > You control your own build environment. So, if you add options which are
> >
On Mon, Mar 30, 2020 at 05:04:42PM +0800, Michael Chang wrote:
> On Thu, Mar 26, 2020 at 10:33:01PM +0100, Daniel Kiper wrote:
> > CC-ing Vladimir...
> >
> > On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote:
> > > Hi Olaf,
> > >
> > &
Hey,
As in subject... Please review...
Daniel
INSTALL | 51 +++
autogen.sh | 2 +-
configure.ac | 21 +++--
3 files changed, 43 insertions(+), 31 deletions(-)
Daniel Kiper (3):
configure: Enforce gnu99 C language
ive with gnu99 until we do not discover that
we strongly require a feature from newer C standard.
Signed-off-by: Daniel Kiper
---
configure.ac | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 88c0adbae..b7f40a1c3 100644
--- a/c
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by: Daniel Kiper
---
INSTALL | 51 +++
configure.ac | 10 ++
2 files changed, 33 insertions(+), 28
..because -iname cannot be used to match paths.
Signed-off-by: Daniel Kiper
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index ef43270fc..31b0ced7e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -13,7 +13,7 @@ fi
export LC_COLLATE=C
On Thu, Apr 02, 2020 at 05:28:33PM +0100, Leif Lindholm wrote:
> On Thu, Apr 02, 2020 at 17:07:48 +0200, Daniel Kiper wrote:
> > Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer
> > const qualifiers) introduced "restrict" keyword into s
On Tue, Mar 31, 2020 at 12:40:23AM +0200, Christian E. Jørgensen wrote:
> Am I correct in assuming that GRUB relies on something like a BIOS for
> support of NVMe devices? I'm running coreboot with GRUB as the payload
> (on amd64 hardware) and GRUB does not seem to detect my NVMe device.
>
> If I u
On Wed, Apr 01, 2020 at 11:08:07PM +0200, Thomas Frauendorfer wrote:
> Hi Olaf,
>
> Current Grub does not handle proxy DHCP correctly.
> There is a patch to add support for proxy DHCP in the mailing list
> archives, but it was never merged.
> I did some adjustments to make it apply to 2.04 for work
Signed-off-by: Daniel Kiper
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 88c0adbae..b2576b013 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file])
# Optimization flag. Allow user
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by: Daniel Kiper
---
INSTALL | 51 +++
configure.ac | 10 ++
2 files changed, 33 insertions(+), 28
ive with gnu99 until we do not discover that
we strongly require a feature from newer C standard.
Signed-off-by: Daniel Kiper
---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard
(suggested by Leif Lindholm).
---
configure.ac | 4
1 file changed,
..because -iname cannot be used to match paths.
Signed-off-by: Daniel Kiper
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index ef43270fc..31b0ced7e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -13,7 +13,7 @@ fi
export LC_COLLATE=C
Hey,
As in subject... Please review...
Daniel
INSTALL | 51 +++
autogen.sh | 2 +-
configure.ac | 16 +++-
3 files changed, 39 insertions(+), 30 deletions(-)
Daniel Kiper (4):
configure: Drop unneeded TARGET_CFLAGS
On Thu, Apr 02, 2020 at 08:40:28PM +0200, Olaf Hering wrote:
> Am Thu, 2 Apr 2020 19:39:49 +0200
> schrieb Daniel Kiper :
>
> > I use such configuration an UEFI platform and it works without any
> > issue. However, pxelinux.0 above suggests that you are playing with
> &
On Thu, Mar 26, 2020 at 08:36:47PM +0100, Daniel Kiper wrote:
> On Wed, Mar 25, 2020 at 08:30:38PM +0100, Olaf Hering wrote:
> > Am Wed, 25 Mar 2020 19:55:47 +0100
> > schrieb Daniel Kiper :
> >
> > > Should not we do the same for 404, file not found, a few lines
On Tue, Mar 17, 2020 at 09:10:02AM +0100, Denis 'GNUtoo' Carikli wrote:
> I'm sorry to have taken so long.
>
> I ended up being sidetracked with other functionalities I wanted to add
> as well along the way, which I'll probably address another time.
No problem...
> I also forgot to use --compose
On Fri, Mar 13, 2020 at 08:06:33PM +0100, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> On my laptop running at 2.4GHz, if I run a VM where tsc calibration
> using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds
> to do so (as measured with the stopwatch on my phone),
644
> --- a/grub-core/term/efi/console.c
> +++ b/grub-core/term/efi/console.c
> @@ -293,6 +293,39 @@ grub_console_getkey_ex(struct grub_term_input *term)
>return key;
> }
>
> +static int
> +grub_console_getkeystatus(struct grub_term_input *term)
Missin
On Fri, Mar 13, 2020 at 08:14:41PM +0100, Javier Martinez Canillas wrote:
> From: Hans de Goede
>
> Move the grub_getkeystatus helper function from
> grub-core/commands/keystatus.c to grub-core/kern/term.c
> and export it so that it can be used outside of the
> keystatus command code too.
>
> Sign
On Fri, Mar 13, 2020 at 08:15:02PM +0100, Javier Martinez Canillas wrote:
> From: Hans de Goede
>
> On some devices the ESC key is the hotkey to enter the BIOS/EFI setup
> screen, making it really hard to time pressing it right. Besides that
> ESC is also pretty hard to discover for a user who doe
On Fri, Mar 13, 2020 at 08:15:53PM +0100, Javier Martinez Canillas wrote:
> From: Steve Langasek
>
> If fastboot is enabled in the BIOS then often it is not possible to
> enter the firmware setup menu, add a menu entry for this.
>
> hdegoede: Cherry picked the Ubuntu patch from:
> https://git.laun
On Fri, Mar 13, 2020 at 08:16:59PM +0100, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> This makes it so you can do set debug to "all,-scripting,-lexer" and get the
> obvious outcome. Any negation present will take preference over that
> conditional, so "all,-scripting,scripting" is the
On Fri, Mar 13, 2020 at 08:17:17PM +0100, Javier Martinez Canillas wrote:
> From: Peter Jones
>
> This makes it so you can treat grub-module-verifierxx.c as a file you can
> build directly, so syntax checkers like vim's "syntastic" plugin, which uses
> "gcc -x c -fsyntax-only" to build it, will wo
On Fri, Mar 13, 2020 at 08:06:32PM +0100, Javier Martinez Canillas wrote:
> Hello,
>
> This is another set of somewhat small patches that we have been carrying in
> the
> Fedora package. I found that some of them have already been posted to the
> list,
> so for those patches I tried to address th
On Fri, Apr 03, 2020 at 09:34:34PM +0200, Daniel Kiper wrote:
> On Fri, Mar 13, 2020 at 08:06:32PM +0100, Javier Martinez Canillas wrote:
> > Hello,
> >
> > This is another set of somewhat small patches that we have been carrying in
> > the
> > Fedora packag
On Tue, Apr 07, 2020 at 11:38:16AM +0200, Javier Martinez Canillas wrote:
> On 4/3/20 2:45 PM, Daniel Kiper wrote:
> > Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer
> > const qualifiers) introduced "restrict" keyword into some function
On Mon, Apr 06, 2020 at 04:55:52PM +0800, Michael Chang wrote:
> On Mon, Apr 06, 2020 at 09:18:26AM +0200, Olaf Hering wrote:
> > Am Sat, 4 Apr 2020 13:31:40 +0800
> > schrieb Michael Chang :
> >
> > > 7 files changed, 229 insertions(+), 2 deletions(-)
> >
> > A lot of churn. It is called 'verbati
On Tue, Apr 07, 2020 at 12:16:09PM +0100, Leif Lindholm wrote:
> On Fri, Apr 03, 2020 at 14:45:02 +0200, Daniel Kiper wrote:
> > ..to reflect the GRUB build reality in them.
> >
> > Additionally, fix ./configure command example formatting in INSTALL file.
> >
>
On Wed, Apr 08, 2020 at 10:19:26AM +0200, Paul Menzel wrote:
> Signed-off-by: Paul Menzel
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote:
> While we already set up error messages in both `luks2_verify_key()` and
> `luks2_decrypt_key()`, we do not ever print them. This makes it really
> hard to discover why a given key actually failed to decrypt a disk.
>
> Improve th
On Tue, Apr 07, 2020 at 06:02:29PM +0200, Patrick Steinhardt wrote:
> Update our embedded version of the jsmn library to upstream commit
> 053d3cd (Merge pull request #175 from pks-t/pks/struct-type,
> 2020-04-02). The update adds a name for the `jsmntok` struct, which
> allows us to add a forward
Hi,
On Wed, Apr 08, 2020 at 12:57:50PM +, Wim Vervoorn wrote:
> Hello,
>
> We are trying to use grub2 as a coreboot payload.
>
> I noticed there is no XHCI support in the current grub tree. Is this a
> driver that will be added in the future or is the only way to use it
> to either have a UEFI
Hi Eric,
First of all, I am not lawyer. So, please do not treat anything below as
a legal advice.
On Sun, Apr 12, 2020 at 10:38:36AM -0400, Eric McCorkle wrote:
> As part of my work on FreeBSD (re)-integration, I would like to pull in
> some code from the FreeBSD loader for GELI volumes. Specifi
ff ff
> ff 00 00 40 00
>
> So far as I can tell this issue has existed for as long as the note
> generation code has existed, but I guess nothing really checks descsz.
>
> Signed-off-by: Daniel Axtens
Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Tue, Apr 07, 2020 at 11:03:48AM +0200, Javier Martinez Canillas wrote:
> From: Hans de Goede
>
> This is a preparatory patch for adding getkeystatus() support to the
> EFI console driver.
>
> We can get modifier status through the simple_text_input read_key_stroke
> method, but if a non-modifie
On Tue, Apr 07, 2020 at 11:03:50AM +0200, Javier Martinez Canillas wrote:
> From: Hans de Goede
>
> If we're running with a hidden menu we may never need text mode, so do not
> change the video-mode to text until we actually need it.
>
> This allows to boot a machine without unnecessary graphical
On Tue, Apr 07, 2020 at 11:03:51AM +0200, Javier Martinez Canillas wrote:
> From: Hans de Goede
>
> On some devices the ESC key is the hotkey to enter the BIOS/EFI setup
> screen, making it really hard to time pressing it right. Besides that
> ESC is also pretty hard to discover for a user who doe
ditional patches for this feature, for example template changes that
> makes hiding the menu only when the previous boot was successful, and to make
> GRUB less noisy and not print unnecessary output. But those will be posted in
> the future once the paches on this set land.
Except some nitpi
Hi Zide,
On Tue, Apr 07, 2020 at 02:08:59PM -0700, Zide Chen wrote:
> In contrast to Mulitboot, in Mulitboot2, there is currently no way to
> control where to load the modules to. This could be a problem, e.g., the
> OS loaded by Multiboot2 needs to reserve low address for some particular
> purpos
then often it is not possible to
> enter the firmware setup menu. So the entry is again useful for this case.
>
> Signed-off-by: Steve Langasek
> Signed-off-by: Dimitri John Ledkov
> Signed-off-by: Hans de Goede
> Signed-off-by: Javier Martinez Canillas
Except nit below Rev
On Wed, Apr 15, 2020 at 10:55:51PM +0200, Patrick Steinhardt wrote:
> On Tue, Apr 14, 2020 at 08:19:01PM +0200, Daniel Kiper wrote:
> > On Tue, Apr 07, 2020 at 06:02:29PM +0200, Patrick Steinhardt wrote:
> > > @@ -80,7 +80,7 @@ typedef struct {
> > > * JSON parser.
On Wed, Apr 15, 2020 at 10:52:53PM +0200, Patrick Steinhardt wrote:
> On Tue, Apr 14, 2020 at 08:12:22PM +0200, Daniel Kiper wrote:
> > On Tue, Apr 07, 2020 at 06:02:23PM +0200, Patrick Steinhardt wrote:
> > > While we already set up error messages in both `luks2
{
> - grub_dprintf ("luks2", "Could not open keyslot %"PRIuGRUB_SIZE"\n",
> i);
> + grub_dprintf ("luks2", "Could not open keyslot %"PRIuGRUB_SIZE":
> %s\n",
> + i, grub_errmsg);
> continue;
...it does not say anything about these changes. If you update commit
message you can add Reviewed-by: Daniel Kiper
Daniel
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
s?
If yes Reviewed-by: Daniel Kiper
Daniel
> Signed-off-by: Patrick Steinhardt
> ---
> grub-core/lib/json/jsmn.h | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/grub-core/lib/json/jsmn.h b/grub-core/lib/json/jsmn.h
> index b95368a20..3178dcc97 100
the `tokens` member of `struct grub_json` as a void pointer but
> can instead use the forward declaration, allowing us to get rid of casts
> of that field.
>
> Signed-off-by: Patrick Steinhardt
Reviewed-by: Daniel Kiper
Daniel
___
Grub
then often it is not possible to
> enter the firmware setup menu. So the entry is again useful for this case.
>
> Signed-off-by: Steve Langasek
> Signed-off-by: Dimitri John Ledkov
> Signed-off-by: Hans de Goede
> Signed-off-by: Javier Martinez Canillas
> Reviewed-by: Daniel Ki
On Wed, Apr 15, 2020 at 12:26:16PM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> This is a v3 of a patch-set that contains improvements for the EFI console and
> terminal drivers that allows to avoid the switch to text-mode until is needed.
>
> This is part of the patches we have in Fedora to
Hi,
On Wed, Apr 15, 2020 at 06:30:23PM +0200, Aleš Nesrsta wrote:
> Hi,
>
> just note:
>
> There was done some work mainly by Bjørn Forsman - but, AFAIK, it is
> probably unfinished, see e.g. here:
> https://lists.gnu.org/archive/html/grub-devel/2017-03/msg9.html
>
> From my point of view, the
On Thu, Apr 16, 2020 at 02:34:57PM +0200, Patrick Steinhardt wrote:
> On Thu, Apr 16, 2020 at 02:29:43PM +0200, Daniel Kiper wrote:
> > On Thu, Apr 16, 2020 at 12:19:48PM +0200, Patrick Steinhardt wrote:
> > > Update our embedded version of the jsmn library to upstream commit
&g
On Thu, Apr 16, 2020 at 02:36:10PM +0200, Patrick Steinhardt wrote:
> On Thu, Apr 16, 2020 at 02:27:02PM +0200, Daniel Kiper wrote:
> > On Thu, Apr 16, 2020 at 12:19:55PM +0200, Patrick Steinhardt wrote:
> > > While we already set up error messages in both `luks2
On Tue, Apr 14, 2020 at 09:39:17PM +, Chen, Zide wrote:
> Hi Daniel,
>
> > Subject: Re: [PATCH V4] multiboot2: Implement quirk-modules-after-kernel
> > On Tue, Apr 07, 2020 at 02:08:59PM -0700, Zide Chen wrote:
> > > In contrast to Mulitboot, in Mulitboot2, there is currently no way to
> > > co
Hi Hans,
On Thu, Apr 16, 2020 at 03:03:43PM +0200, Hans Ulrich Niedermann wrote:
> This patch does not change the intended meaning of the text
> and only touches about the first 1300 of about 7000 lines
> in docs/grub.texi. If there is interest in picking up this
> patch, I intend to read through
On Wed, Apr 15, 2020 at 02:04:36PM +0200, Flavio Suligoi wrote:
> Sometimes, writing a custom grub.cfg configuration file,
> especially with embedded systems, it is indispensable
> to know the version of the running GRUB.
> This is essential for every automatic sw update procedure.
>
> Additionally
single patch into two as
> proposed by Daniel.
>
> @Daniel: Note that I've added your Reviewed-by to the second patch, but
> not to the first one as it's message is completely new.
LGTM, Reviewed-by: Daniel Kiper for both...
Thanks,
Daniel
___
On Thu, Apr 16, 2020 at 05:39:02PM +0200, Hans Ulrich Niedermann wrote:
> On Thu, 16 Apr 2020 16:27:02 +0200
> Daniel Kiper wrote:
>
> > On Thu, Apr 16, 2020 at 03:03:43PM +0200, Hans Ulrich Niedermann
> > wrote:
> > > This patch does not change the intended mean
Hi,
On Fri, Apr 17, 2020 at 12:52:15PM +0800, 9. wrote:
> Hi, have you considered making grub2 support ecc, and if so, when?
> Thanks for reading and looking forward to your reply.
Without knowing what exactly you mean by ECC I am not able to say
anything about our plans with regards to that.
Da
On Mon, Apr 20, 2020 at 02:04:32PM +0100, Leif Lindholm wrote:
> On Fri, Apr 10, 2020 at 05:05:48 -0700, Daniel Kiper wrote:
> > On Tue, Apr 07, 2020 at 12:16:09PM +0100, Leif Lindholm wrote:
> > > On Fri, Apr 03, 2020 at 14:45:02 +0200, Daniel Kiper wrote:
> > > &g
Hi Marc,
On Sun, Apr 19, 2020 at 10:08:19PM +0200, Marc Beninca wrote:
> Hello,
>
> I recently migrated from xz to zstd for my squashfs files,
> and from GRUB version 2.02 to version 2.04,
> which was the occasion for me to notice that :
> – the zstd module has been implemented
> – the btrfs mod
On Mon, Mar 16, 2020 at 05:41:29PM +0100, Daniel Kiper wrote:
> On Wed, Mar 11, 2020 at 11:47:35AM +0100, Daniel Kiper wrote:
> > On Tue, Mar 03, 2020 at 06:26:03PM +0100, Daniel Kiper wrote:
> > > On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote:
> > > >
Hi Hans,
On Sat, Apr 18, 2020 at 12:53:12PM +0200, Hans Ulrich Niedermann wrote:
> Hi,
>
> I have noticed that there are two commands documented in grub.texi
> which appear not to occur anywhere within the grub source code:
> 'pxe_unload' and 'uppermem'.
>
> @node pxe_unload
> @subsection
801 - 900 of 3709 matches
Mail list logo
