CC-ing Vladimir... On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote: > Hi Olaf, > > The patch rang a bell to me and eventually I figured out that I had > similar patch posted. > > https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html
Yeah, it looks that it fell through the cracks... > In short, the issue is not only in the fix itself, but also to take care > and provide a measure to avoid incompatible grub.cfg before and after > the patch. > > To recap, there were two options provided to deal with the compatibilty > issue. > > 1. Introduce a shell variable to disable the change, whenever anything > goes wrong. > > 2. Use readonly feature variable similar to $feature_menuentry_id that > can be used to detect capability and apply settings accordingly, thus > still fulfill the requirement of one grub.cfg can work for all versions > IMHO. > > I am in favour of #2, but still they didn't seem to have upstream's > consent yet. Michael, please prepare a patch and CC Olaf and Vladimir on it. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
