Re: [PATCH v2 2/6] json: Implement wrapping interface

2019-11-13 Thread Daniel Kiper
On Thu, Nov 07, 2019 at 02:51:30AM +, Max Tottenham via Grub-devel wrote: > On 11/06, Patrick Steinhardt wrote: > > On Wed, Nov 06, 2019 at 02:57:52PM +, Max Tottenham wrote: > > > On 11/06, Daniel Kiper wrote: > > > > On Tue, Nov 05, 2019 at 02:12:13PM +

Re: [PATCH v2] lvm: add lvm cache logical volume handling

2019-11-13 Thread Daniel Kiper
On Tue, Nov 05, 2019 at 09:33:00AM +, Michael Chang wrote: > The lvm cache logical volume is the logical volume consisting of the > original and the cache pool logical volume. The original is usually on a > larger and slower storage device while the cache pool is on a smaller > and faster one.

Re: [PATCH v3 1/6] json: Import upstream jsmn-1.1.0

2019-11-14 Thread Daniel Kiper
> Upstream jsmn commit hash: fdcef3ebf886fa210d14956d3c068a653e76a24e > Upstream jsmn commit name: Modernize (#149), 2019-04-20 > > [1]: https://github.com/zserge/jsmn > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 2/6] json: Implement wrapping interface

2019-11-14 Thread Daniel Kiper
On Wed, Nov 13, 2019 at 02:22:34PM +0100, Patrick Steinhardt wrote: > While the newly added jsmn library provides the parsing interface, it > does not provide any kind of interface to act on parsed tokens. Instead, > the caller is expected to handle pointer arithmetics inside of the token > array i

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-15 Thread Daniel Kiper
On Thu, Nov 14, 2019 at 09:53:54AM +, Michael Chang wrote: > On Wed, Nov 13, 2019 at 12:00:50PM +0100, Daniel Kiper wrote: > > On Thu, Nov 07, 2019 at 12:52:35PM +0100, Daniel Kiper wrote: > > > On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder&#

Re: [PATCH v3 2/6] json: Implement wrapping interface

2019-11-15 Thread Daniel Kiper
On Thu, Nov 14, 2019 at 02:12:39PM +0100, Patrick Steinhardt wrote: > On Thu, Nov 14, 2019 at 01:37:18PM +0100, Daniel Kiper wrote: > > On Wed, Nov 13, 2019 at 02:22:34PM +0100, Patrick Steinhardt wrote: [...] > > > + switch (p->type) > > > +

Re: [PATCH v3 6/6] disk: Implement support for LUKS2

2019-11-15 Thread Daniel Kiper
On Wed, Nov 13, 2019 at 02:22:38PM +0100, Patrick Steinhardt wrote: > With cryptsetup 2.0, a new version of LUKS was introduced that breaks > compatibility with the previous version due to various reasons. GRUB > currently lacks any support for LUKS2, making it impossible to decrypt > disks encrypt

Re: Transfering Data from GRUB to userspace?

2019-11-15 Thread Daniel Kiper
On Thu, Nov 14, 2019 at 10:27:10AM +, Max Tottenham via Grub-devel wrote: > On 10/28, Daniel Kiper wrote: > > Hi Max, > > ... > > > Yeah, I think you are right. Additionally, please take a look at [1] and > > especially at [2]. The series is about to commit and s

Re: Transfering Data from GRUB to userspace?

2019-11-15 Thread Daniel Kiper
On Thu, Nov 14, 2019 at 12:56:25PM +0200, Toomas Soome via Grub-devel wrote: > > On 14. Nov 2019, at 12:27, Max Tottenham via Grub-devel > > wrote: > > On 10/28, Daniel Kiper wrote: > >> Hi Max, > > > > ... > > > >> Yeah, I think you

Re: [PATCH] lvm: add lvm cache logical volume handling

2019-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2019 at 08:05:22AM +, Michael Chang wrote: > On Thu, Oct 24, 2019 at 05:21:04PM +0200, Daniel Kiper wrote: > > On Thu, Oct 24, 2019 at 04:43:58AM +, Michael Chang wrote: > > > On Wed, Oct 23, 2019 at 12:48:23PM +0200, Daniel Kiper wrote: > > > &

Re: error: the initrd is too big

2019-11-18 Thread Daniel Kiper
On Fri, Nov 15, 2019 at 03:33:35PM +0100, Paul Menzel wrote: > Dear GRUB folks, > > I built Linux 5.4-rc7 with an initrd and additional options > like KASAN selected. When starting the 9.8 MB LZ4 compressed > initrd on a Dell Latitude E7250 with 16 GB RAM GRUB shows: > > error: the initrd is to

Re: [PATCH v4 2/6] json: Implement wrapping interface

2019-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2019 at 09:45:13AM +0100, Patrick Steinhardt wrote: > While the newly added jsmn library provides the parsing interface, it > does not provide any kind of interface to act on parsed tokens. Instead, > the caller is expected to handle pointer arithmetics inside of the token > array i

Re: [PATCH v4 6/6] disk: Implement support for LUKS2

2019-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2019 at 09:45:17AM +0100, Patrick Steinhardt wrote: > With cryptsetup 2.0, a new version of LUKS was introduced that breaks > compatibility with the previous version due to various reasons. GRUB > currently lacks any support for LUKS2, making it impossible to decrypt > disks encrypt

Re: [PATCH v3 2/6] json: Implement wrapping interface

2019-11-18 Thread Daniel Kiper
On Fri, Nov 15, 2019 at 01:36:18PM +0100, Patrick Steinhardt wrote: > On Fri, Nov 15, 2019 at 12:56:40PM +0100, Daniel Kiper wrote: > > On Thu, Nov 14, 2019 at 02:12:39PM +0100, Patrick Steinhardt wrote: > > > On Thu, Nov 14, 2019 at 01:37:18PM +0100, Daniel Kiper wrote: >

Re: [PATCH v4 2/6] json: Implement wrapping interface

2019-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2019 at 04:46:45PM +0100, Patrick Steinhardt wrote: > On Mon, Nov 18, 2019 at 03:14:15PM +0100, Daniel Kiper wrote: > > On Mon, Nov 18, 2019 at 09:45:13AM +0100, Patrick Steinhardt wrote: > > > +grub_size_t > > > +grub_json_getsi

Re: Transfering Data from GRUB to userspace?

2019-11-19 Thread Daniel Kiper
On Tue, Nov 19, 2019 at 02:01:11AM +, Tottenham, Max via Grub-devel wrote: > Original mail seems to have been eaten again, apologies if you already > received this. > > On 11/15, Daniel Kiper wrote: > > On Thu, Nov 14, 2019 at 10:27:10AM +, Max Tottenham via Gru

[ANNOUNCEMENT] FOSDEM 2020 Open Source Firmware, BMC and Bootloader Devroom Call for Participation

2019-11-25 Thread Daniel Kiper
Hi, Some of you may already know but we think that it is worth posting this thing here too. Piotr Król from 3mdeb and I are looking for papers for FOSDEM 2020 Open Source Firmware, BMC and Bootloader Devroom. If you want to help us to make this room interesting please send us your proposal until S

Re: [PATCH v5 2/6] json: Implement wrapping interface

2019-11-29 Thread Daniel Kiper
On Fri, Nov 29, 2019 at 07:51:46AM +0100, Patrick Steinhardt wrote: > While the newly added jsmn library provides the parsing interface, it > does not provide any kind of interface to act on parsed tokens. Instead, > the caller is expected to handle pointer arithmetics inside of the token > array i

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-11-29 Thread Daniel Kiper
On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: > On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > > We had a discussion with Daniel and agreed on following: > > 1) we accept the feature > > Great, thanks. > > > 2) we want to have an option to specify grub confi

Re: [PATCH 1/1] btrfs: add support for new raid1c34 profiles

2019-11-29 Thread Daniel Kiper
On Wed, Nov 27, 2019 at 01:56:56PM +0100, David Sterba wrote: > On Tue, Nov 05, 2019 at 01:18:41PM +0100, Daniel Kiper wrote: > > On Mon, Nov 04, 2019 at 05:23:22PM +0100, David Sterba wrote: > > > There are new 3- and 4-copy variants of RAID1, estimated to be merged to > &g

Re: [PATCH] tftp: Normalize slashes in tftp paths

2019-11-29 Thread Daniel Kiper
z > Signed-off-by: Mark Salter > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Except some nitpicks which I fix before committing... > --- > > grub-core/net/tftp.c | 28 +--- > 1 file changed, 25 insertions(+), 3 deletions(-) >

Re: [PATCH] cryptodisk: add luks_recover_key attempts option

2019-11-29 Thread Daniel Kiper
On Sat, Nov 02, 2019 at 06:23:49PM -0400, Jason Kushmaul wrote: > Hi Daniel, > > Please see revised patch addressing all of your comments in the > attached patch file. > > Jason > From 7a2b845f421d8605e139b2a7e41c2d7722c969c3 Mon Sep 17 00:00:00 2001 > From: "Jason J. Kushmaul" > Date: Sat, 20 Ju

[GRUB PATCH 1/1] loader/i386/linux: Fix an underflow in the setup_header length calculation

2019-12-02 Thread Daniel Kiper
_params)/grub_file_read(linux_params) section outside of it to not confuse the reader. Signed-off-by: Daniel Kiper --- grub-core/loader/i386/linux.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c ind

Re: [GRUB PATCH 1/1] loader/i386/linux: Fix an underflow in the setup_header length calculation

2019-12-08 Thread Daniel Kiper
Hmmm... Nobody cares? Strange... Adding 3mdeb folks... Daniel On Mon, Dec 02, 2019 at 06:29:39PM +0100, Daniel Kiper wrote: > Recent work around x86 Linux kernel loader revealed an underflow in the > setup_header length calculation and another related issue. Both lead to > the memory

Re: [PATCH v5 2/6] json: Implement wrapping interface

2019-12-08 Thread Daniel Kiper
On Fri, Dec 06, 2019 at 06:24:28PM +0100, Patrick Steinhardt wrote: > On Fri, Nov 29, 2019 at 04:34:58PM +0100, Daniel Kiper wrote: > > On Fri, Nov 29, 2019 at 07:51:46AM +0100, Patrick Steinhardt wrote: > [snip] > > > +grub_err_t > > > +grub_json_getsize (grub_size_t

Re: [PATCH] multiboot2: set min address for mbi allocation to 0x1000

2019-12-13 Thread Daniel Kiper
gt; > Signed-off-by: Lukasz Hawrylko Otherwise LGTM. If you add what I am asking for above then you can add Reviewed-by: Daniel Kiper to the next version of patch. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailma

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 03:28:37PM +0100, Javier Martinez Canillas wrote: > On 11/29/19 4:46 PM, Daniel Kiper wrote: > > On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: > >> On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > >

Re: [PATCH v3 1/2] Add grub_util_readlink()

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 03:44:21PM +0100, Javier Martinez Canillas wrote: > Hello Daniel, > > On 11/5/19 12:42 PM, Daniel Kiper wrote: > > [snip] > > >> --- grub-core/osdep/windows/hostdisk.c > >> +++ grub-core/osdep/windows/hostdisk.c > >> @@ -365,

Re: [PATCH v6 2/6] json: Implement wrapping interface

2019-12-13 Thread Daniel Kiper
ons to retrieve values from the parsed json type, > `grub_json_t`. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs: Export `superusers` to apply to submenus

2019-12-13 Thread Daniel Kiper
@samp{superusers} to empty > +string effectively disables both access to CLI and editing of menu entries. I would add that note at the end of the paragraph. If you want you can repost the patch. If not I will fix it before committing. Otherwise Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v2] multiboot2: set min address for mbi allocation to 0x1000

2019-12-16 Thread Daniel Kiper
allocated at address 0. > To prevent that, define min address for mbi allocation in x86 and x86_64 > platforms. > > Signed-off-by: Lukasz Hawrylko > Reviewed-by: Daniel Kiper LGTM. If there are no objections I will commit it by the end of

Re: [PATCH v6 6/6] disk: Implement support for LUKS2

2019-12-16 Thread Daniel Kiper
er of patches required for initial LUKS2 support. Adding it in the > future would be trivial, given that the code structure is already in > place. > > Signed-off-by: Patrick Steinhardt In general Reviewed-by: Daniel Kiper ... However, one question below... [...] > +static gru

Re: [PATCH v6 6/6] disk: Implement support for LUKS2

2019-12-16 Thread Daniel Kiper
On Mon, Dec 16, 2019 at 01:37:33PM +0100, Patrick Steinhardt wrote: > On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote: > > On Tue, Dec 10, 2019 at 10:26:21AM +0100, Patrick Steinhardt wrote: > [snip] > > > + /* Get the passphrase from the user. */ > &g

Re: [PATCH v6 6/6] disk: Implement support for LUKS2

2019-12-16 Thread Daniel Kiper
On Mon, Dec 16, 2019 at 02:10:55PM +0100, Patrick Steinhardt wrote: > On Mon, Dec 16, 2019 at 02:05:00PM +0100, Daniel Kiper wrote: > > On Mon, Dec 16, 2019 at 01:37:33PM +0100, Patrick Steinhardt wrote: > > > On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote: >

Re: [PATCH v6 0/6] Support for LUKS2 disk encryption

2019-12-20 Thread Daniel Kiper
On Tue, Dec 10, 2019 at 10:26:15AM +0100, Patrick Steinhardt wrote: > Hi, > > this is the 6th version of this patchset aiming to implement > support for LUKS2 disk encryption. All changes relate to the JSON > interface, only: Sadly your patchset brakes at least i386-pc and arm-coreboot builds. Com

Re: [PATCH v7 0/6] Support for LUKS2 disk encryption

2020-01-10 Thread Daniel Kiper
Hi Patrick, On Fri, Dec 27, 2019 at 04:18:33PM +0100, Patrick Steinhardt wrote: > Hi, > > this is hopefully the last version of this patchset. The previous Yes, it is. Everything builds. Patchset pushed. Thank you for your work! Daniel ___ Grub-devel

Re: [ANNOUNCEMENT] FOSDEM 2020 Open Source Firmware, BMC and Bootloader Devroom Call for Participation

2020-01-10 Thread Daniel Kiper
Hi Steve, On Fri, Jan 03, 2020 at 06:23:34PM +, Steve McIntyre wrote: > Hi Daniel! > > On Mon, Nov 25, 2019 at 11:19:52AM +0100, Daniel Kiper wrote: > > > >Some of you may already know but we think that it is worth posting this thing > >here too. Piotr Król from

Re: ZFS grubenv write support

2020-01-17 Thread Daniel Kiper
Hi Paul, On Mon, Jan 13, 2020 at 04:03:34PM -0800, Paul Dagnelie wrote: > Hey all, > > I'm interested in trying to enable support for boot-time modification of > the grubenv file on ZFS and other non-standard filesystems that don't > necessarily work today. I have a proposed design, and I was wond

Re: Contributing to GRUB

2020-01-17 Thread Daniel Kiper
On Thu, Jan 02, 2020 at 10:19:26PM +0100, Teach weaver wrote: > Hello, > > I am from Sweden and eager to contribute to GRUB. Please take a look at https://savannah.gnu.org/bugs/?group=grub and find the simplest bug for you to fix. Then post a patch here. Daniel __

Re: grub-mkrescue: The blkid LABELs of its ISO 9660, HFS+, FAT filesystems

2020-01-17 Thread Daniel Kiper
Hi, CC-ing Vladimir... On Wed, Dec 18, 2019 at 07:24:45PM +0100, Thomas Schmitt wrote: > Hi, > > during tests about the changes in blkid which are still discussed in > https://github.com/karelzak/util-linux/pull/913 > i noted that a grub-mkrescue ISO for x86 BIOS and EFI shows the same > filesy

Re: [PATCH] Fix FreeDOS command booting large files (near or above 64 KiB)

2020-01-17 Thread Daniel Kiper
: > http://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/lib/i386/relocator16.S?id=495781f5ed1b48bf27f16c53940d6700c181c74c#n97 > [4]: https://ulukai.org/ecm/lDebug-5479a7988d21-nohelp.zip > > Signed-off-by: C. Masloch Reviewed-by: Daniel Kiper If there are no objections in a week

Re: [PATCH] Fix an uninitialized variable.

2020-01-29 Thread Daniel Kiper
On Mon, Jan 27, 2020 at 03:01:16PM -0500, Peter Jones wrote: > gcc says: > > grub-core/fs/squash4.c: In function ‘direct_read’: > grub-core/fs/squash4.c:868:10: error: ‘err’ may be used uninitialized in > this function [-Werror=maybe-uninitialized] > 868 | if (err) > | ^ > cc

Re: [PATCH v2] Update to minilzo-2.08

2020-01-29 Thread Daniel Kiper
> Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v6 4/5] normal/main: Search for specific config files for netboot

2020-01-29 Thread Daniel Kiper
gt; It is enabled by default but can be disabled by setting the environment > variable 'feature_net_search_cfg' to 'n' in an embedded configuration. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=873406 > > Signed-off-by: Paulo Flabiano Smorigo >

Re: [PATCH v6 5/5] docs: Update info with grub.cfg netboot selection order

2020-01-29 Thread Daniel Kiper
default but can be disabled > by setting the 'feature_net_search_cfg' environment variable to 'n' in > an embedded configuration file. > > Signed-off-by: Robert Marshall > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel __

Re: GRUB Manual Apparent Typo

2020-01-29 Thread Daniel Kiper
Hi Patrick, On Fri, Jan 17, 2020 at 03:34:08PM -0500, Patrick Higgins wrote: > GRUB Developers, > > There appears to be a typo in the GRUB manual's Table of Contents at > https://www.gnu.org/software/grub/manual/grub/html_node/index.html. List > item 16.3.21 reads "linux", but this link actually g

[ANNOUNCEMENT] GRUB at FOSDEM 2020, etc.

2020-01-29 Thread Daniel Kiper
Hi, I would like to invite all of you to my talk "GRUB upstream and distros cooperation" during FOSDEM 2020. It will be held on Sunday at 14:30 in K.3.201 room [1]. If you are interested in firmware, BMC and bootloader in general I would like to encourage you to visit Open Source Firmware, BMC an

Re: [RESEND PATCH v4 2/2] Make editenv chase symlinks including those across devices

2020-02-11 Thread Daniel Kiper
same copy of grub-set-default will > work on both kinds of systems. > > Windows doesn't implement a readlink primitive, so the current behaviour is > maintained for this operating system. > > Signed-off-by: Peter Jones > Signed-off-by: Jonathan Lebon > Reviewed-by: Adam

Re: [PATCH 3/5] disk: luks2: Add missing newline to debug message

2020-02-11 Thread Daniel Kiper
On Thu, Feb 06, 2020 at 03:27:31PM +0100, Patrick Steinhardt wrote: > The debug message printed when decryption with a keyslot fails is > missing its trailing newline. Add it to avoid mangling it with > subsequent output. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-11 Thread Daniel Kiper
Adding Milan, Leif, Alex, Peter, Mathew and Vladimir. On Thu, Feb 06, 2020 at 03:27:28PM +0100, Patrick Steinhardt wrote: > Hi, > > as promised back when LUKS2 support was merged, here's the code that > enables decrypting LUKS2 partitions that use Argon2 as their key derival > function. Most of th

Re: Volume keys in grub2

2020-02-11 Thread Daniel Kiper
On Mon, Feb 10, 2020 at 09:17:18AM +, Workaround Profi_GMan wrote: > Hello! > As far as I see, the volume keys are mapped to the normal "up" and "down" > keys and they function just as up and down keys. So my aim to make them > recognized as different keys so I can adjust each of them separat

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-13 Thread Daniel Kiper
On Wed, Feb 12, 2020 at 08:47:49AM +0100, Patrick Steinhardt wrote: > On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote: > > > GRUB's codebase. This included both stripping off unneeded > > > functionality as well as converting the

Re: [PATCH] normal: Move common datetime functions out of the normal module

2020-02-18 Thread Daniel Kiper
endencies like these, that break the build due > the genmoddep.awk script catching the issues. > > Fix this by taking the datetime helper functions out of the normal module > and instead add them to the datetime module itself. Besides fixing these > issues, it makes more sense t

Re: [PATCH] verifiers: fix calling uninitialized function pointer

2020-02-18 Thread Daniel Kiper
ernel first > > > > Press any key to continue... > > > > and then you can go back to boot menu by pressing any key or after a few > > seconds expired. > > > > Signed-off-by: Michael Chang > > --- > > Reviewed-by: Javier Martinez Canillas Rev

GRUB 2.06 release

2020-02-19 Thread Daniel Kiper
Hi all, As I told during my FOSDEM 2020 presentation we are preparing for GRUB 2.06 release. Tentative schedule is below: - code freeze: 15th of March, 23:59:59 UTC; everything posted after that date will not be considered as a release material, - release: taking into account last experien

Re: [PATCH 1/2] build: Move TARGET_* assignments earlier

2020-02-21 Thread Daniel Kiper
opriate flags > (specifically -m64 in this case). > > Bug: https://bugs.gentoo.org/667850 Reviewed-by: Daniel Kiper for both patches... If there are no objections I will push these patches next week. Daniel > --- > configure.ac | 36 ++-- > 1 f

Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2

2020-02-21 Thread Daniel Kiper
Hi Patrick, On Thu, Feb 20, 2020 at 07:00:48PM +0100, Patrick Steinhardt wrote: > Hi, > > this is the second version of my patchset to add support for Argon2 > encryption keys for LUKS2. > > The most important change is that I've now verbosely imported the argon2 > code from the official reference

Re: [PATCH v2 2/6] types.h: add UINT-related macros needed for Argon2

2020-02-21 Thread Daniel Kiper
On Thu, Feb 20, 2020 at 07:00:50PM +0100, Patrick Steinhardt wrote: > For the upcoming import of the Argon2 library, we need the macros > GRUB_UINT32_MAX, GRUB_UINT32_C and GRUB_UINT64_C. Add them as a > preparatory step. > > Signed-off-by: Patrick Steinhardt > --- > include/grub/types.h | 8

Re: ZFS grubenv write support

2020-02-21 Thread Daniel Kiper
On Fri, Feb 21, 2020 at 11:14:25AM +0100, Javier Martinez Canillas wrote: > On 1/17/20 1:10 PM, Daniel Kiper wrote: > > Hi Paul, > > > > [snip] > > > > > In general I like the idea. Though I would like to have this > > configurable by user if possible (som

Re: [PATCH v2 3/6] argon2: Import Argon2 from cryptsetup

2020-02-21 Thread Daniel Kiper
On Thu, Feb 20, 2020 at 07:00:51PM +0100, Patrick Steinhardt wrote: > In order to support the Argon2 key derival function for LUKS2, we > obviously need to implement Argon2. It doesn't make a lot of sense to > hand-code any crypto, which is why this commit instead imports Argon2 > from the cryptset

Re: [PATCH v2 5/6] luks2: Discern Argon2i and Argon2id

2020-02-21 Thread Daniel Kiper
sed KDF's type > accordingly. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 6/6] luks2: Support key derival via Argon2

2020-02-21 Thread Daniel Kiper
trivial. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Make grub_strtol() "end" pointers have safer const qualifiers. (v2)

2020-02-24 Thread Daniel Kiper
s people using trying to use const (as they should!), > putting it at the wrong place, fighting with the compiler for a bit, and > then either removing it or typecasting something in a bad way. I won't > go into describing restrict, but its syntax has exactly the same issue > as with c

Re: [PATCH] ZFS/other CoW FS save_env support

2020-02-24 Thread Daniel Kiper
On Tue, Feb 18, 2020 at 11:10:07AM -0800, Paul Dagnelie wrote: > Hey all, I previously discussed my concept for this patch in my email > https://lists.gnu.org/archive/html/grub-devel/2020-01/msg4.html . > I'm pleased to announce that I've gotten it into a working state and > it is ready to revi

Re: [PATCH 1/2] Cryptomount support LUKS detached header

2020-02-24 Thread Daniel Kiper
Adding Patrick... On Fri, Feb 21, 2020 at 10:03:48PM +0100, Denis 'GNUtoo' Carikli wrote: > From: John Lane Both patches require explanation what they do and more importantly why they are needed... And it would be nice to have cover letter. ...and please CC Patrick next time... Daniel > Signe

Re: [PATCH] ZFS/other CoW FS save_env support

2020-02-25 Thread Daniel Kiper
On Mon, Feb 24, 2020 at 10:30:36AM -0800, Paul Dagnelie wrote: > On Mon, Feb 24, 2020 at 3:03 AM Daniel Kiper wrote: > > > > Why "root" not "boot"? > That was a typo on my part; the code uses grub_guess_root_device to > find the devices backin

Re: [PATCH] ZFS/other CoW FS save_env support

2020-02-25 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 06:33:09PM +0800, Michael Chang wrote: > On Mon, Feb 24, 2020 at 10:30:36AM -0800, Paul Dagnelie wrote: > > On Mon, Feb 24, 2020 at 3:03 AM Daniel Kiper wrote: > > > > > > > > > Why "root" not "boot"? > > That

Re: [PATCH 08/10] kern: Make grub_error() more verbose

2020-02-28 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 01:25:51PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > Add file and line to grub_error() output to make troubleshooting easier. This patch does more than that. I think it requires splitting into two separate ones... Daniel > Signed-off-by: Peter Jones

Re: [PATCH 09/10] video: Add more debug output on GOP and UGA probing

2020-02-28 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 01:25:52PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > Add debug information to EFI GOP and UGA video drivers probing function. Same as for patch #8... Daniel > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas > --- > > grub-co

Re: [PATCH 00/10] A set of trivial patches from the Fedora package

2020-02-28 Thread Daniel Kiper
ches don't have dependency with each other and can be independently > applied. I'm posting it as a set because I think that will make the review > easier, but please let me know if you want them to be posted individually. Except patches #8

Re: GRUB 2.06 release

2020-02-28 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 02:15:16PM +0100, John Paul Adrian Glaubitz wrote: > Hi! > > On 2/20/20 9:46 AM, John Paul Adrian Glaubitz wrote: > > On 2/19/20 4:01 PM, Daniel Kiper wrote: > >> As I told during my FOSDEM 2020 presentation we are preparing for > >> GRUB 2.

Re: master fails to create moddep.lst, related to luks2 changes

2020-03-03 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 12:18:18PM +0100, Paul Menzel wrote: > Dear Olaf, > > On 2020-03-03 09:48, Olaf Hering wrote: > > After upgrade from > > 4e75b2ae313b13b5bfb54cc5e5c53368d6eb2a08..d5a32255de0e073881980fca0262000c865b30dd > > I get this compile error: > > > > env CFLAGS=-Wall CXXFLAGS=-Wall

Re: [PATCH] fat: Support file modification times

2020-03-03 Thread Daniel Kiper
On Fri, Feb 28, 2020 at 11:25:43PM -0500, David Michael wrote: > E.g. this allows comparing file ages on EFI system partitions. > > Signed-off-by: David Michael > --- > > Hi, > > I tried to make a quick patch for #57621 based on the FAT timestamp > format as described on Wikipedia. Is there still

Re: [PATCH] Restore patches to po/Makefile.in.in

2020-03-03 Thread Daniel Kiper
27;ve added these to > conf/Makefile.extra-dist instead. > > Fixes: https://savannah.gnu.org/bugs/?57298 > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] po: fix replacement of %m in sed programs

2020-03-03 Thread Daniel Kiper
ample: > > msgid "cannot rename the file %s to %s: %m" > msgstr "ﺹﺎﻨﻧﻮﺗ ﺮﻌﻧﺎﻤﻋ ﺖﻬﻋ ﻒִﻴﻠﻋ %s ﺕﻭ %s: %ﻡ" > > Mimic the workaround used for "%s" by reversing the replacement of "%m" at > the end of the sed programs. > > Signed-off-by: Mike G

Re: [PATCH 1/4] Add envblk open functions to grub file interface

2020-03-03 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 11:26:35AM -0800, Paul Dagnelie wrote: > These functions are added to support the remainder of this patch set. > In order to add these special functions we have to refactor out the > logic that applies file filters so that it can be applied to both the > normal and envblk op

Re: [PATCH 2/4] Add envblk reading/writing functionality to GRUB

2020-03-03 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 11:26:41AM -0800, Paul Dagnelie wrote: > We leverage the grub envblk file and fs functions to read from and > write to the envblk. We also tweak the editenv code by factoring out > the logic that creates the buffer with the envblk contents so it can > be reused. The commit

Re: [PATCH 3/4] Add ZFS envblock functions

2020-03-03 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 11:26:45AM -0800, Paul Dagnelie wrote: > This patch adds a ZFS implementation of the new envblock functions, > storing the data for the envblock in the second padding area of the > label. This data is protected by an embedded checksum and is stored > redundantly, so even tho

Re: [PATCH 4/4] Update grub editenv to support modifying envblk

2020-03-03 Thread Daniel Kiper
On Tue, Feb 25, 2020 at 11:26:47AM -0800, Paul Dagnelie wrote: > This patch adds the capability for the editenv utility to modify the > envblk, and adds ZFS-specific handlers that will be built if GRUB is > built with libzfs support. It also adds logic that editenv uses to > detect GRUB's (root) fi

Re: [PATCH v2] smbios: Add a --linux argument to apply linux modalias-like filtering

2020-03-03 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 04:06:34PM +0100, Julian Andres Klode wrote: > Linux creates modalias strings by filtering out non-ASCII, space, > and colon characters. Provide an option that does the same filtering > so people can create a modalias string in grub, and then match their > modalias patterns

Re: master fails to create moddep.lst, related to luks2 changes

2020-03-03 Thread Daniel Kiper
Adding Patrick... On Tue, Mar 03, 2020 at 05:28:37PM +0100, Olaf Hering wrote: > On Tue, Mar 03, Paul Menzel wrote: > > > Please bisect the problem to found out the commit introducing the build > > regression in your environment. > > > git bisect start > # bad: [d5a32255de0e073881980fca0262000c86

Re: [PATCH] btrfs: disable zstd support for i386-pc

2020-03-03 Thread Daniel Kiper
On Tue, Nov 19, 2019 at 08:34:12AM +, Michael Chang wrote: > On Fri, Nov 15, 2019 at 12:42:52PM +0100, Daniel Kiper wrote: > > On Thu, Nov 14, 2019 at 09:53:54AM +, Michael Chang wrote: > > > On Wed, Nov 13, 2019 at 12:00:50PM +0100, Daniel Kiper wrote: > > > &

Re: [PATCH v2] smbios: Add a --linux argument to apply linux modalias-like filtering

2020-03-03 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 05:51:55PM +0100, Julian Andres Klode wrote: > On Tue, Mar 03, 2020 at 05:44:54PM +0100, Daniel Kiper wrote: > > On Tue, Mar 03, 2020 at 04:06:34PM +0100, Julian Andres Klode wrote: > > > @@ -261,6 +279,7 @@ grub_cmd_smbios (grub_extcmd_context_t ctxt, &g

Re: GRUB 2.06 release

2020-03-03 Thread Daniel Kiper
On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote: > Hi all, > > As I told during my FOSDEM 2020 presentation we are preparing for > GRUB 2.06 release. Tentative schedule is below: > - code freeze: 15th of March, 23:59:59 UTC; everything posted after > tha

Re: GRUB 2.06 release

2020-03-05 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 06:33:54PM +0100, John Paul Adrian Glaubitz wrote: > On 3/3/20 6:26 PM, Daniel Kiper wrote: > > On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote: > >> Hi all, > >> > >> As I told during my FOSDEM 2020 presentation we are

Re: GRUB 2.06 release

2020-03-05 Thread Daniel Kiper
On Wed, Mar 04, 2020 at 05:39:10AM +0100, Patrick Steinhardt wrote: > On Tue, Mar 03, 2020 at 06:26:03PM +0100, Daniel Kiper wrote: > > On Wed, Feb 19, 2020 at 04:01:38PM +0100, Daniel Kiper wrote: > > > Hi all, > > > > > > As I told during my FOSDEM 20

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-05 Thread Daniel Kiper
On Wed, Mar 04, 2020 at 12:58:47PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > Add file and line to grub_error() output to make troubleshooting easier. > > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas Reviewed-by: Dan

Re: [PATCH v2 09/12] efi: Print error messages to grub_efi_allocate_pages_real()

2020-03-05 Thread Daniel Kiper
> > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 10/12] efi/uga: Use video instead of fb as debug condition

2020-03-05 Thread Daniel Kiper
gned-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 11/12] efi/gop: Add debug output on GOP probing

2020-03-05 Thread Daniel Kiper
On Wed, Mar 04, 2020 at 12:58:50PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > Add debug information to EFI GOP video driver probing function. > > Signed-off-by: Peter Jones > Signed-off-by: Javier Martinez Canillas Reviewed-by: Dan

Re: [PATCH] build: Add soft-float handling for SuperH (sh4)

2020-03-05 Thread Daniel Kiper
ohn Paul Adrian Glaubitz Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs: Update for stopping small mbr gap support

2020-03-05 Thread Daniel Kiper
On Thu, Mar 05, 2020 at 06:40:01PM +0800, Michael Chang wrote: > Further to the discussion about disabling btrfs zstd support for > i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to > hold true any longer. > > "You must ensure that the first partition starts at least 31 KiB (6

Re: [PATCH] Enable the datetime module for the emu platform

2020-03-06 Thread Daniel Kiper
commands/ls.c:155: undefined reference to `grub_unixtime2datetime' > > > > Bug: https://bugs.gentoo.org/711512 > > Signed-off-by: Mike Gilbert > > --- > > Patch looks good to me and it fixes the issue. > > Reviewed-by: Javier Martinez Canil

Re: [PATCH v2] docs: Update for stopping small mbr gap support

2020-03-06 Thread Daniel Kiper
; > The patch tries to correct the paragraph with a more practical size that > > works for grub and also for modern computer systems in general. > > > > [1] https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00025.html > > > > Signed-off-by: Michael Chang >

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size I think it does not matter much if we stop pretending that we suppor

Re: [PATCH v2 1/2] exfat: Save the matching directory entry when iterating

2020-03-06 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 02:40:54PM -0500, David Michael wrote: > This provides the node's attributes outside the search function. > > Signed-off-by: David Michael Reviewed-by: Daniel Kiper ...except one nit... > --- > > I had to copy an extra struct to support exfat m

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > This allows comparing file ages on EFI system partitions. > > Signed-off-by: David Michael > --- > > Changes since v1: > - Added the previous patch to help support exfat > - Added exfat timestamp conversion + setting > - Switch

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
Re-adding grub-devel@gnu.org... On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit : > > > On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: &

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 10:48:07AM -0500, David Michael wrote: > On Fri, Mar 6, 2020 at 7:19 AM Daniel Kiper wrote: > > On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > > > This allows comparing file ages on EFI system partitions. > > > > &g

Re: [PATCH 1/2] build: Fix option to explicitly disable memory debugging

2020-03-09 Thread Daniel Kiper
how other defines work. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

<    3   4   5   6   7   8   9   10   11   12   >