Adding John and Eric... On Wed, Feb 19, 2020 at 10:51:41PM -0800, Matt Turner wrote: > From: Mike Gilbert <flop...@gentoo.org> > > On a 32-bit SPARC userland, configure fails to compile assembly and the > build fails: > > checking for options to compile assembly... configure: error: could not > compile assembly > > config.log shows: > > asm-tests/sparc64.S: Assembler messages: > asm-tests/sparc64.S:5: Error: Architecture mismatch on "lduw [%o4+4],%o4". > asm-tests/sparc64.S:5: (Requires v9|v9a|v9b|v9c|v9d|v9e|v9v|v9m|m8; > requested architecture is sparclite.) > asm-tests/sparc64.S:7: Error: Architecture mismatch on "stw %o5,[%o3]". > asm-tests/sparc64.S:7: (Requires v9|v9a|v9b|v9c|v9d|v9e|v9v|v9m|m8; > requested architecture is sparclite.) > asm-tests/sparc64.S:8: Error: Architecture mismatch on "bne,pt %icc,1b > ,pt %icc,1b". > asm-tests/sparc64.S:8: (Requires v9|v9a|v9b|v9c|v9d|v9e|v9v|v9m|m8; > requested architecture is sparclite.) > > Simply moving these blocks earlier in configure.ac is sufficient to > ensure that the tests are executed with the appropriate flags > (specifically -m64 in this case). > > Bug: https://bugs.gentoo.org/667850
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> for both patches... If there are no objections I will push these patches next week. Daniel > --- > configure.ac | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/configure.ac b/configure.ac > index e07ba4b56..b5e31c787 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -562,6 +562,24 @@ CPPFLAGS="$TARGET_CPPFLAGS" > LDFLAGS="$TARGET_LDFLAGS" > LIBS="" > > +if test "x$target_m32" = x1; then > + # Force 32-bit mode. > + TARGET_CFLAGS="$TARGET_CFLAGS -m32" > + TARGET_CCASFLAGS="$TARGET_CCASFLAGS -m32" > + TARGET_CPPFLAGS="$TARGET_CPPFLAGS -m32" > + TARGET_LDFLAGS="$TARGET_LDFLAGS -m32" > + TARGET_MODULE_FORMAT="elf32" > +fi > + > +if test "x$target_m64" = x1; then > + # Force 64-bit mode. > + TARGET_CFLAGS="$TARGET_CFLAGS -m64" > + TARGET_CCASFLAGS="$TARGET_CCASFLAGS -m64" > + TARGET_CPPFLAGS="$TARGET_CPPFLAGS -m64" > + TARGET_LDFLAGS="$TARGET_LDFLAGS -m64" > + TARGET_MODULE_FORMAT="elf64" > +fi > + > # debug flags. > TARGET_CFLAGS="$TARGET_CFLAGS $WARN_FLAGS -g -Wredundant-decls > -Wmissing-prototypes -Wmissing-declarations" > TARGET_CCASFLAGS="$TARGET_CCASFLAGS -g" > @@ -750,24 +768,6 @@ if test "x$target_cpu" = xi386 && test "x$platform" != > xemu; then > TARGET_CFLAGS="$TARGET_CFLAGS -march=i386" > fi > > -if test "x$target_m32" = x1; then > - # Force 32-bit mode. > - TARGET_CFLAGS="$TARGET_CFLAGS -m32" > - TARGET_CCASFLAGS="$TARGET_CCASFLAGS -m32" > - TARGET_CPPFLAGS="$TARGET_CPPFLAGS -m32" > - TARGET_LDFLAGS="$TARGET_LDFLAGS -m32" > - TARGET_MODULE_FORMAT="elf32" > -fi > - > -if test "x$target_m64" = x1; then > - # Force 64-bit mode. > - TARGET_CFLAGS="$TARGET_CFLAGS -m64" > - TARGET_CCASFLAGS="$TARGET_CCASFLAGS -m64" > - TARGET_CPPFLAGS="$TARGET_CPPFLAGS -m64" > - TARGET_LDFLAGS="$TARGET_LDFLAGS -m64" > - TARGET_MODULE_FORMAT="elf64" > -fi > - > if test "x$grub_cv_cc_target_clang" = xno && test "x$target_cpu" = xi386 && > test "x$platform" != xemu && test "x$platform" != xefi; then > TARGET_CFLAGS="$TARGET_CFLAGS -mrtd -mregparm=3" > fi > -- > 2.24.1 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
