Re: [PATCH v4 02/10] PE: Add RISC-V definitions

2019-01-17 Thread Daniel Kiper
iewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4 03/10] elf.h: Add RISC-V definitions

2019-01-17 Thread Daniel Kiper
iewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng One nit pick below. If you fix it you can add Reviewed-by: Daniel Kiper > --- > include/grub/elf.h | 59 > ++ > 1 file changed, 59 insertions(+) &

Re: [PATCH v4 04/10] RISC-V: Add setjmp implementation

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:09AM +0100, Alexander Graf wrote: > This patch adds a 32/64 capable setjmp implementation for RISC-V. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper How

Re: [PATCH v4 05/10] RISC-V: Add early startup code

2019-01-17 Thread Daniel Kiper
iewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > we also only want to support running Linux underneath as UEFI payload. > > Prepare that with a Linux boot case that is not enabled in Linux yet. At > least i

Re: [PATCH v4 07/10] RISC-V: Add awareness for RISC-V reloations

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:12AM +0100, Alexander Graf wrote: > This patch adds awareness of RISC-V relocations throughout the grub tools > as well as dynamic linkage and elf->PE relocation conversion support. > > Signed-off-by: Alexander Graf Except two nitpicks Reviewed-b

Re: [PATCH v4 08/10] RISC-V: Add auxiliary files

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:13AM +0100, Alexander Graf wrote: > To support a new architecture we need to provide a few helper functions > for memory, cache, timer, etc support. > > This patch adds the remainders of those. Some bits are still disabled, > as I couldn't guarantee that we're always r

Re: [PATCH v4 09/10] RISC-V: Add to build system

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:14AM +0100, Alexander Graf wrote: > This patch adds support for RISC-V to the grub build system. With this > patch, I can successfully build grub on RISC-V as a UEFI application. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > Reviewed-by: Bin Men

Re: [PATCH v4 10/10] fdt: Treat device tree file type like ACPI

2019-01-17 Thread Daniel Kiper
se their threat level is the same. > > Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-18 Thread Daniel Kiper
On Thu, Jan 17, 2019 at 02:50:19PM +, Leif Lindholm wrote: > On Thu, Jan 17, 2019 at 01:24:29PM +0100, Daniel Kiper wrote: > > > +static grub_err_t > > > +finalize_params_linux (void) > > > +{ > > > + int node, retval; > > > + > > &

Re: [PATCH] uboot: Add the missing disk write operation support

2019-01-21 Thread Daniel Kiper
On Wed, Jan 16, 2019 at 10:56:56PM +0100, Daniel Kiper wrote: > On Tue, Jan 15, 2019 at 04:59:56PM +0200, Cristian Ciocaltea wrote: > > uboot_disk_write() is currently lacking the write support > > to storage devices because, historically, those devices did not > > impleme

Re: [PATCH] bootp: add native DHCPv4 support

2019-01-21 Thread Daniel Kiper
On Fri, Jan 11, 2019 at 03:59:34PM +, Andre Przywara wrote: > From: Andrei Borzenkov > > This patch adds support for native DHCPv4 and removes requirement for > BOOTP compatibility support in DHCP server. > > There is no provision for selecting preferred server. We take the first > OFFER and t

Re: TPM/Verifiers testing bug?

2019-01-21 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 02:09:45PM +, Max Tottenham wrote: > On 01/14, Daniel Kiper wrote: > > On Wed, Jan 09, 2019 at 02:16:16PM +, Max Tottenham wrote: > > > Hi Folks > > > > > > I was curious about the upstream work on the verifiers framework (and &

Re: [PATCH v2] uboot: Add the missing disk write operation support

2019-01-22 Thread Daniel Kiper
U-Boot loading > and booting GRUB in a QEMU vexpress-a9 environment. > The disk write operations were triggered with GRUB's save_env > command. > > Signed-off-by: Cristian Ciocaltea > Reviewed-by: Daniel Kiper > --- > > Changes since v1: > * Fix compiler erro

Re: [PATCH] linux, efi, arm*, fdt: break FDT extra allocation space out into a #define

2019-01-23 Thread Daniel Kiper
On Tue, Jan 22, 2019 at 04:59:41PM +, Leif Lindholm wrote: > A certain amount of dynamic space is required for the handover from > GRUB/Linux-EFI-stub. This entails things like initrd addresses, > address-cells entries and associated strings. > > But move this into a proper centralised #define

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Daniel Kiper
On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > On 17.01.19 13:24, Daniel Kiper wrote: > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > >> We currently only support to run grub on RISC-V as UEFI payload. Ideally, > >> we also o

Re: [PATCH v3 3/4] mkimage: arm64-efi: Align header to page granularity

2019-01-23 Thread Daniel Kiper
On Tue, Jan 22, 2019 at 04:36:39PM +0100, Alexander Graf wrote: > On 15.01.19 14:40, Daniel Kiper wrote: > > On Tue, Jan 15, 2019 at 01:52:41PM +0100, Alexander Graf wrote: > >> On 01/15/2019 01:45 PM, Daniel Kiper wrote: > >>> On Mon, Jan 14, 2019 at 04:27:17

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-23 Thread Daniel Kiper
On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > > On 17.01.19 13:24, Daniel Kiper wrote: > > > On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: [...] > > &g

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-24 Thread Daniel Kiper
On Wed, Jan 23, 2019 at 05:15:58PM +, Leif Lindholm wrote: > On Wed, Jan 23, 2019 at 05:53:00PM +0100, Daniel Kiper wrote: > > On Wed, Jan 23, 2019 at 11:47:25AM +, Leif Lindholm wrote: > > > On Tue, Jan 22, 2019 at 05:09:18PM +0100, Alexander Graf wrote: > > >

Re: [PATCH v4 2/2] mkimage: Align efi sections on 4k boundary

2019-01-24 Thread Daniel Kiper
On Wed, Jan 23, 2019 at 04:34:58PM +0100, Alexander Graf wrote: > There is UEFI firmware popping up in the wild now that implements stricter > permission checks using NX and write protect page table entry bits. > > This means that firmware now may fail to load binaries if its individual > sections

Re: [PATCH v4 1/2] mkimage: Use EFI32_HEADER_SIZE define in arm-efi case

2019-01-24 Thread Daniel Kiper
; Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] bootp: add native DHCPv4 support

2019-01-24 Thread Daniel Kiper
On Mon, Jan 21, 2019 at 02:10:48PM +, Andre Przywara wrote: > On Mon, 21 Jan 2019 13:02:08 +0100 > Daniel Kiper wrote: > > Hi Daniel, > > thanks very much for your reply! You are welcome. > > On Fri, Jan 11, 2019 at 03:59:34PM +, Andre Przywara wrote: >

Re: [PATCH v4 2/2] mkimage: Align efi sections on 4k boundary

2019-01-24 Thread Daniel Kiper
On Thu, Jan 24, 2019 at 03:10:58PM +0100, Alexander Graf wrote: > On 24.01.19 15:08, Daniel Kiper wrote: > > On Wed, Jan 23, 2019 at 04:34:58PM +0100, Alexander Graf wrote: > >> There is UEFI firmware popping up in the wild now that implements stricter > >> permissio

Re: MKPasswd idempotency patch

2019-01-24 Thread Daniel Kiper
On Sun, Jan 20, 2019 at 02:04:44AM +0100, grub-de...@agowa338.de wrote: > Hello, > > I've separated the changes in single commits. > The patches include: > > 0001: Adds a quiet mode to grub-mkpasswd-pbkdf2. So that it can be used > within pipes and other tools. > 0002: Suppresses the leading newli

Re: [PATCH v5 1/3] mkimage: Use EFI32_HEADER_SIZE define in arm-efi case

2019-01-28 Thread Daniel Kiper
; Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 2/3] mkimage: Align efi sections on 4k boundary

2019-01-28 Thread Daniel Kiper
On Fri, Jan 25, 2019 at 12:45:15PM +0100, Alexander Graf wrote: > There is UEFI firmware popping up in the wild now that implements stricter > permission checks using NX and write protect page table entry bits. > > This means that firmware now may fail to load binaries if its individual > sections

Re: [PATCH v5 3/3] mkimage: Clarify file alignment in efi case

2019-01-28 Thread Daniel Kiper
file alignment constant instead. > > Reported-by: Daniel Kiper > Signed-off-by: Alexander Graf Great! However, this patch misses changes for EFI32_HEADER_SIZE and EFI64_HEADER_SIZE macros. In general I think about s/GRUB_PE32_SECTION_ALIGNMENT/GRUB_PE32_FILE_ALIGNMENT/ I have asked about t

Re: [PATCH v5 2/3] mkimage: Align efi sections on 4k boundary

2019-01-28 Thread Daniel Kiper
On Mon, Jan 28, 2019 at 01:33:33PM +0100, Alexander Graf wrote: > On 28.01.19 13:22, Daniel Kiper wrote: > > On Fri, Jan 25, 2019 at 12:45:15PM +0100, Alexander Graf wrote: > >> There is UEFI firmware popping up in the wild now that implements stricter > >> permissio

Re: [PATCH v5 3/3] mkimage: Clarify file alignment in efi case

2019-01-28 Thread Daniel Kiper
On Mon, Jan 28, 2019 at 01:34:20PM +0100, Alexander Graf wrote: > On 28.01.19 13:27, Daniel Kiper wrote: > > On Fri, Jan 25, 2019 at 12:45:16PM +0100, Alexander Graf wrote: > >> There are a few spots in the PE generation code for EFI binaries that uses > >> the section

Re: [PATCH v6 0/3] arm64: Support HP Envy X2

2019-01-29 Thread Daniel Kiper
lignment in efi case > > v5 -> v6: > > - Change EFIxxHEADER_SIZE macros too > - Fix comment > > Alexander Graf (3): > mkimage: Use EFI32_HEADER_SIZE define in arm-efi case > mkimage: Align efi sections on 4k boundary > mkimage: Clarify file alignment in

Re: [PATCH v6 0/3] arm64: Support HP Envy X2

2019-01-31 Thread Daniel Kiper
On Wed, Jan 30, 2019 at 03:04:08AM +0100, Julien ROBIN wrote: > Hi, > > Happy to give some help, so I tried with and without those patches on the > current version of Grub available trough Git here : git clone > git://git.savannah.gnu.org/grub.git > > I can confirm that the patch set is working fin

Re: [PATCH v6 0/3] arm64: Support HP Envy X2

2019-02-01 Thread Daniel Kiper
On Thu, Jan 31, 2019 at 10:06:25PM +0100, Julien ROBIN wrote: > Hi, Yes that's fine, I assume that the name of the creator of the patch also Thanks a lot! > deserves to appear ;) he did more than me! Yes, patch will have his SOB. Daniel ___ Grub-deve

Re: [PATCH] arm: Move initrd upper to leave more space for kernel

2019-02-01 Thread Daniel Kiper
On Tue, Jan 29, 2019 at 09:09:45AM +0100, Guillaume GARDET wrote: > From: Guillaume GARDET > > This patch allows to have bigger kernels. > If the kernel grows, then it will overwrite the initrd when it is extracted. > > Signed-off-by: Guillaume GARDET > > --- > grub-core/loader/arm/linux.c | 2 +

Re: clang 7.0.1 build fails with `error: argument unused during compilation: '-Qn'`

2019-02-06 Thread Daniel Kiper
Hi Paul, On Tue, Feb 05, 2019 at 05:45:50PM +0100, Paul Menzel wrote: > Dear GRUB folks, > > Building GRUB from the master branch fails with clang 7.0.1 fails > with the error below. The error is not shown with clang 6.0.1. > > ``` > $ ./autogen.sh > $ ./configure CC=clang > $ make -j`nproc` > […]

Re: [PATCH] ZFS: Ignore replacing-* devices

2019-02-06 Thread Daniel Kiper
On Sat, Feb 02, 2019 at 05:06:39PM -0600, Richard Laager wrote: > I submitted this patch to Ubuntu some time ago, but apparently never > submitted it directly to the GRUB project. > > I have copied the information from my Ubuntu bug report (including > attachments) into this email. If you wish to s

Re: [PATCH] normal/menu: Do not treat error values as key presses

2019-02-06 Thread Daniel Kiper
the time-out is cancelled/cleared. With the commit, it is not. > > With a small GRUB payload, this the problem is also reproducible on the > ASRock E350M1. > > Link: http://lists.gnu.org/archive/html/grub-devel/2019-01/msg00037.html > Signed-off-by: Paul Menzel Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

FOSDEM 2019 - GRUB upstream and distros cooperation

2019-02-06 Thread Daniel Kiper
Hi, If somebody is interested in "GRUB upstream and distros cooperation" presentation and video from FOSDEM 2019 is available at https://fosdem.org/2019/schedule/event/grub_upstream_and_distros/ Daniel ___ Grub-devel mailing list Grub-devel@gnu.org h

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Daniel Kiper
On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: > Paul, > > Let me start of by saying that I am a contributor and do not have any > authority to approve or deny patches to GRUB. That said I do have a few > comments below that I would like for you to consider. Paul, may I ask you to f

Re: [PATCH 1/1] Add a new grub module called msr that registers two commands (rdmsr and wrmsr) to be able to read and write to the model-specific registers. It is i386 specific, as the cpuid module. T

2019-02-18 Thread Daniel Kiper
Hi, Thank you for the contribution. A few comments below... On Sat, Feb 16, 2019 at 06:29:01PM +0100, JesusDF wrote: I think that message from mail #0 should go here. And you do not need introduction mail just for one patch. > --- > grub-core/Makefile.core.def | 10 > grub-core/command

Re: [PATCH v2] Add travis-ci config file

2019-02-18 Thread Daniel Kiper
On Thu, Feb 14, 2019 at 02:12:28PM +0100, Alexander Graf wrote: > There is a really convenient service for open source project from Travis > CI: They allow for free CI testing using their infrastructure. > > Grub has had issues with broken builds for various targets for a long time > already. The m

Re: [PATCH v6 06/11] RISC-V: Add Linux load logic

2019-02-18 Thread Daniel Kiper
64 target is > generalized, we can hook into that one and gain boot functionality. > > Signed-off-by: Alexander Graf Reviewed-by: Daniel Kiper But two nitpicks below... [...] > diff --git a/include/grub/riscv32/linux.h b/include/grub/riscv32/linux.h > new file mode 100644 > index 00

Re: [PATCH v7 08/11] RISC-V: Add auxiliary files

2019-02-18 Thread Daniel Kiper
atch adds the remainders of those. Some bits are still > > disabled, > > as I couldn't guarantee that we're always running on models / in > > modes > > where the respective hardware is available. > > > > Signed-off-by: Alexand

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-18 Thread Daniel Kiper
On Mon, Feb 18, 2019 at 07:41:43PM +0100, Paul Menzel wrote: > Dear Daniel, > > On 18.02.19 13:58, Daniel Kiper wrote: > > On Fri, Feb 15, 2019 at 07:44:55AM -0800, Nick Vinson wrote: > > > > Let me start of by saying that I am a contributor and do not have any > &g

Re: [PATCH v6 07/11] RISC-V: Add awareness for RISC-V reloations

2019-02-18 Thread Daniel Kiper
support. > > > > Signed-off-by: Alexander Graf > > Reviewed-by: Alistair Francis Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] Add travis-ci config file

2019-02-18 Thread Daniel Kiper
On Mon, Feb 18, 2019 at 07:57:35PM +0100, Daniel Kiper wrote: > On Thu, Feb 14, 2019 at 02:12:28PM +0100, Alexander Graf wrote: [...] > > + - mkdir /tmp/cross > > + # results in binaries like > > /tmp/cross/gcc-8.1.0-nolibc/ia64-linux/bin/ia64-linux-gcc > > + -

Re: [PATCH v6 10/11] RISC-V: Add to build system

2019-02-18 Thread Daniel Kiper
; Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper But two nitpicks below... [...] > diff --git a/grub-core/kern/emu/cache.c b/grub-core/kern/emu/cache.c > index 6f89e871a..113682cc4 100644 > --- a/grub-core/kern/emu/cache.c > +++ b/grub-core/k

Re: [PATCH v6 09/11] RISC-V: Add libgcc helpers for clz

2019-02-18 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 11:31:06AM +0100, Alexander Graf wrote: > Gcc may decide it wants to call helper functions to execute clz. Provide Do we know when it happens? Could we add that to the commit message? > them in our own copy of libgcc. > > Signed-off-by: Alexander Graf > --- > grub-core/k

Re: [PATCH 1/1] Add new module msr

2019-02-19 Thread Daniel Kiper
On Mon, Feb 18, 2019 at 08:09:37PM +0100, Jesús Diéguez Fernández wrote: > Hi, > > I have some doubts that I mention below. > > El 18/2/19 a las 14:24, Daniel Kiper escribió: > > Hi, > > > > Thank you for the contribution. A few comments below... > >

Re: [PATCH v6 06/11] RISC-V: Add Linux load logic

2019-02-20 Thread Daniel Kiper
On Tue, Feb 19, 2019 at 02:25:11PM +0100, Alexander Graf wrote: > On 02/18/2019 08:28 PM, Daniel Kiper wrote: > > On Tue, Feb 12, 2019 at 11:31:03AM +0100, Alexander Graf wrote: > > > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > > > w

Re: [PATCH v6 09/11] RISC-V: Add libgcc helpers for clz

2019-02-20 Thread Daniel Kiper
On Tue, Feb 19, 2019 at 02:26:04PM +0100, Alexander Graf wrote: > On 02/18/2019 08:55 PM, Daniel Kiper wrote: > > On Tue, Feb 12, 2019 at 11:31:06AM +0100, Alexander Graf wrote: > > > Gcc may decide it wants to call helper functions to execute clz. Provide > > Do we know w

Re: [PATCH v6 10/11] RISC-V: Add to build system

2019-02-20 Thread Daniel Kiper
On Tue, Feb 19, 2019 at 02:44:06PM +0100, Alexander Graf wrote: > On 02/18/2019 09:14 PM, Daniel Kiper wrote: > > On Tue, Feb 12, 2019 at 11:31:07AM +0100, Alexander Graf wrote: > > > This patch adds support for RISC-V to the grub build system. With this > > > patch, I

Re: [PATCH v3] Add travis-ci config file

2019-02-20 Thread Daniel Kiper
On Tue, Feb 19, 2019 at 04:34:08PM +0100, Alexander Graf wrote: > There is a really convenient service for open source project from Travis > CI: They allow for free CI testing using their infrastructure. > > Grub has had issues with broken builds for various targets for a long time > already. The m

Re: [PATCH v2 1/9] net: dhcp: remove dead code

2019-02-20 Thread Daniel Kiper
t; fields holds the IP address of the > BOOTP relay, not a general purpose router address. > Just remove the commented code, archeologists can find it in the git > history. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel _

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-20 Thread Daniel Kiper
On Sat, Feb 09, 2019 at 02:39:05PM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

Re: [PATCH] arm64/efi: fix grub_efi_get_ram_base()

2019-02-21 Thread Daniel Kiper
tyre <93...@debian.org> > >Signed-off-by: Leif Lindholm > > Tested-by: Steve McIntyre <93...@debian.org> Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3] Add travis-ci config file

2019-02-21 Thread Daniel Kiper
On Thu, Feb 21, 2019 at 12:38:09AM +0100, Alexander Graf wrote: > > Am 20.02.2019 um 21:46 schrieb Daniel Kiper : > >> On Tue, Feb 19, 2019 at 04:34:08PM +0100, Alexander Graf wrote: > >> There is a really convenient service for open source project from Travis > &g

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-21 Thread Daniel Kiper
On Thu, Feb 21, 2019 at 04:28:40PM +0100, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > Thanks for the review! > > On 2/20/19 9:59 PM, Daniel Kiper wrote: > > On Sat, Feb 09, 2019 at 02:39:05PM +0100, John Paul Adrian Glaubitz wrote: > >> Recent versions of bi

Re: [PATCH] grub-install: check for arm-efi as a default target

2019-02-21 Thread Daniel Kiper
> "arm-uboot" as previously. > > > > Split out the code to (maybe) load the efivar module and check for > > /sys/firmware/efi into a common helper routine is_efi_system() > > > > Signed-off-by: Steve McIntyre <93...@debian.org> > > LGTM: > Revi

Re: [PATCH v2 2/9] net: dhcp: replace parse_dhcp_vendor() with find_dhcp_option()

2019-02-21 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 05:46:53PM +, Andre Przywara wrote: > From: Andrei Borzenkov > > For proper DHCP support we will need to parse DHCP options from a packet > more often and at various places. > > Refactor the option parsing into a new function, which will scan a > packet to find *a parti

Re: [PATCH v2 3/9] net: dhcp: refactor DHCP packet transmission into separate function

2019-02-21 Thread Daniel Kiper
ction, so that future code can more easily reuse this. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper But one nitpick below... > - err = grub_net_send_ip_packet (&ifaces[j], &target, &ll_target, nb, > - GRUB

Re: [PATCH v2 4/9] net: dhcp: make grub_net_process_dhcp take an interface

2019-02-21 Thread Daniel Kiper
on. > > Signed-off-by: Andre Przywara In general Reviewed-by: Daniel Kiper However, please add a blurb to the commit message that you are also cleaning up the code a bit... > --- > grub-core/net/bootp.c | 29 - > grub-core/net/ip.c| 2 +- > i

Re: [PATCH v2 5/9] net: dhcp: introduce per-interface timeout

2019-02-21 Thread Daniel Kiper
DHCP handshake and to also cover the lease time limit a > DHCP offer will come with. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 6/9] net: dhcp: use DHCP options for name and bootfile

2019-02-21 Thread Daniel Kiper
On Tue, Feb 12, 2019 at 05:46:57PM +, Andre Przywara wrote: > From: Andrei Borzenkov > > The BOOTP RFC describes the boot file name and the server name as being > part of the integral BOOTP data structure, with some limits on the size > of them. > DHCP extends this by allowing them to be separ

Re: [PATCH v2 7/9] net: dhcp: allow receiving DHCP OFFER and ACK packets

2019-02-21 Thread Daniel Kiper
; > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 8/9] net: dhcp: actually send out DHCPv4 DISCOVER and REQUEST messages

2019-02-21 Thread Daniel Kiper
igned-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 9/9] net: dhcp: add explicit net_dhcp command

2019-02-21 Thread Daniel Kiper
able to > coexist. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v4] Add travis-ci config file

2019-02-22 Thread Daniel Kiper
ntime checks for other targets. > > Currently, with this config alone, I already see about half of the available > targets as broken. So it's definitely desperately needed :). > > Signed-off-by: Alexander Graf In general Reviewed-by: Daniel Kiper But... > --- > > v1

Re: [PATCH] grub-install: check for arm-efi as a default target

2019-02-26 Thread Daniel Kiper
On Tue, Feb 26, 2019 at 01:27:21PM +, Leif Lindholm wrote: > On Thu, Feb 21, 2019 at 04:31:32PM +0100, Daniel Kiper wrote: > > On Thu, Feb 21, 2019 at 03:04:26PM +, Leif Lindholm wrote: > > > On Thu, Feb 21, 2019 at 02:46:11PM +, Steve McIntyre wrote: > > >

Re: [PATCH v2 1/1] osdep/freebsd: Fix partition calculation for EBR entries

2019-03-01 Thread Daniel Kiper
adding. Thus we > must use "offset", and divide by the sector size to convert to sectors. > > Signed-off-by: James Clarke > Reviewed-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] util: Detect more I/O errors

2019-03-01 Thread Daniel Kiper
64.efi': No space left on device. > > There are more missing checks in other utilities, but this should fix > the most critical ones. > > Fixes Debian bug #922741. Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] Fix syslinux_test in out-of-tree builds

2019-03-01 Thread Daniel Kiper
; @abs_top_srcdir@ may contain ".." segments. > > Performing the substitution requires some awkwardness in Makefile.am due > to details of how config.status works. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH v2 1/1] Upgrade Gnulib; switch to bootstrap tool

2019-03-01 Thread Daniel Kiper
requires Autoconf >= 2.63 and Automake >= 1.11, in line with > Gnulib. > > Gnulib source code is now placed in grub-core/lib/gnulib/ (which should > not be edited directly), and GRUB's patches are in > grub-core/lib/gnulib-patches/. I've added a few notes to the deve

Re: [PATCH v2 1/2] Replace __asm__ __volatile__ with asm volatile.

2019-03-05 Thread Daniel Kiper
On Fri, Mar 01, 2019 at 06:17:41PM +0100, Jesús Diéguez Fernández wrote: > In order to maintain the coding style consistency, it was requested to > replace the methods that use __asm__ __volatile__ with asm volatile. > > Signed-off-by: Jesús Diéguez Fernández Reviewed-by: Daniel Ki

Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-05 Thread Daniel Kiper
On Fri, Mar 01, 2019 at 06:17:42PM +0100, Jesús Diéguez Fernández wrote: > In order to be able to read and write from/to model-specific registers, > two new modules are added. They are i386 specific, as the cpuid module. > > rdmsr module registers the command rdmsr that allows reading from a MSR. >

Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-06 Thread Daniel Kiper
On Tue, Mar 05, 2019 at 11:17:01PM +0100, Jesús Diéguez Fernández wrote: > Hi, >I have some doubts that I comment below. > > El 5/3/19 a las 12:09, Daniel Kiper escribió: > > On Fri, Mar 01, 2019 at 06:17:42PM +0100, Jesús Diéguez Fernández wrote: > >> In order t

Re: [PATCH] sparc64: add bios boot partition support

2019-03-06 Thread Daniel Kiper
On Mon, Mar 04, 2019 at 05:34:01PM -0800, Eric Snowberg wrote: > Add BIOS Boot Partition support for sparc64 platforms. This will work a > little different than x86. With GPT, both the OBP "load" and "boot" commands > are partition aware and neither command can see the partition table. > Theref

Re: [PATCH V3] ieee1275: obdisk driver

2019-03-06 Thread Daniel Kiper
On Mon, Mar 04, 2019 at 05:27:39PM -0800, Eric Snowberg wrote: > Add a new disk driver called obdisk for IEEE1275 platforms. Currently > the only platform using this disk driver is SPARC, however other IEEE1275 > platforms could start using it if they so choose. While the functionality > within t

Re: [PATCH] sparc64: add bios boot partition support

2019-03-07 Thread Daniel Kiper
On Wed, Mar 06, 2019 at 08:56:53AM -0700, Eric Snowberg wrote: > > On Mar 6, 2019, at 3:52 AM, Daniel Kiper wrote: > > On Mon, Mar 04, 2019 at 05:34:01PM -0800, Eric Snowberg wrote: > >> Add BIOS Boot Partition support for sparc64 platforms. This will work a > >> li

Re: [PATCH v6 00/11] Add RISC-V support

2019-03-07 Thread Daniel Kiper
On Wed, Mar 06, 2019 at 05:53:58PM +0100, Andreas Schwab wrote: > On Feb 12 2019, Alexander Graf wrote: > > > As part of the plan for total world domination, we would like to make sure > > that booting on RISC-V is in a sane state before anyone goes and does quick > > hacks "just because". > > > >

Re: [PATCH V3] ieee1275: obdisk driver

2019-03-07 Thread Daniel Kiper
On Wed, Mar 06, 2019 at 08:38:27AM -0700, Eric Snowberg wrote: > > On Mar 6, 2019, at 4:32 AM, Daniel Kiper wrote: > > On Mon, Mar 04, 2019 at 05:27:39PM -0800, Eric Snowberg wrote: > >> Add a new disk driver called obdisk for IEEE1275 platforms. Currently > >> the

Re: [PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-07 Thread Daniel Kiper
On Thu, Mar 07, 2019 at 12:16:06PM +0100, Paul Menzel wrote: > Date: Wed Mar 6 08:14:28 2019 +0100 > > By default all file system modules are added to the GRUB coreboot > payload `default_payload.elf`. This makes the image quite big, > especially as often not all modules are needed. > > Introduce t

Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-07 Thread Daniel Kiper
On Thu, Mar 07, 2019 at 07:05:20PM +0100, Jesús Diéguez Fernández wrote: [...] > I've sorted out the MSR support check, but I'm struggling a bit with Great! > handling the exception. Yeah, this can be difficult. > I've read the Intel SDM and other docs, and I think I understand the > reason w

Re: [PATCH v2] Makefile: Allow to set file systems modules for default_payload.elf

2019-03-08 Thread Daniel Kiper
On Fri, Mar 08, 2019 at 02:34:55AM +0100, Paul Menzel wrote: > Dear Daniel, > > On 07.03.19 20:37, Daniel Kiper wrote: > > On Thu, Mar 07, 2019 at 12:16:06PM +0100, Paul Menzel wrote: > > > Date: Wed Mar 6 08:14:28 2019 +0100 > > > > > > By default all

Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-08 Thread Daniel Kiper
On Thu, Mar 07, 2019 at 10:28:06PM +0100, Jesús Diéguez Fernández wrote: > El 7/3/19 a las 20:58, Daniel Kiper escribió: > > On Thu, Mar 07, 2019 at 07:05:20PM +0100, Jesús Diéguez Fernández wrote: > > > > [...] > > > > [...] > > >> - And from a pr

Re: getting KEVS for booting DFly

2019-03-08 Thread Daniel Kiper
I am not familiar with BSD but... On Thu, Mar 07, 2019 at 04:42:47PM +, Artsimovich, Wladislav wrote: > Dear GRUB team, > > I'm interested in getting DragonFlyBSD to boot without a BIOS environment > (e.g. using coreboot / libreboot with the coreboot-grub payload to load the > kernel directl

Re: [PATCH v3 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-08 Thread Daniel Kiper
s to > the particular cpu/core/thread that ran the command. > > Also, if you specify a reserved or unimplemented MSR address, it will > cause a general protection exception (which is not currently being handled) > and the system will reboot. > > Signed-off-by: Jesús Diéguez Fernán

Re: [PATCH v3 02/10] net: dhcp: replace parse_dhcp_vendor() with find_dhcp_option()

2019-03-08 Thread Daniel Kiper
gt; packet to find *a particular* option field. > Use that new function in places where we were dealing with DHCP options > before. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.

Re: [PATCH v3 03/10] net: dhcp: Allow overloading legacy bootfile and name field

2019-03-08 Thread Daniel Kiper
gt; Signed-off-by: Andre Przywara In general Reviewed-by: Daniel Kiper but one nitpick below... > --- > grub-core/net/bootp.c | 59 ++- > include/grub/net.h| 1 + > 2 files changed, 59 insertions(+), 1 deletion(-) > > diff --git a/gru

Re: [PATCH v3 07/10] net: dhcp: use DHCP options for name and bootfile

2019-03-08 Thread Daniel Kiper
ed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 03/10] net: dhcp: Allow overloading legacy bootfile and name field

2019-03-08 Thread Daniel Kiper
On Fri, Mar 08, 2019 at 11:51:27AM +, Andre Przywara wrote: > On Fri, 8 Mar 2019 12:34:18 +0100 > Daniel Kiper wrote: > > > On Thu, Mar 07, 2019 at 03:14:09PM +, Andre Przywara wrote: > > > From: Andrei Borzenkov > > > > > > DHCP specifies a sp

Re: [PATCH v3 08/10] net: dhcp: allow receiving DHCP OFFER and ACK packets

2019-03-08 Thread Daniel Kiper
; > Signed-off-by: Andre Przywara > Reviewed-by: Daniel Kiper This patch has changed and you retained my RB and not explained why it has changed. Could you tell us what has happened? Next time please drop RB if you change the code significantly. Hmmm... It seems to me that at least partially thi

Re: [PATCH v3 08/10] net: dhcp: allow receiving DHCP OFFER and ACK packets

2019-03-08 Thread Daniel Kiper
On Fri, Mar 08, 2019 at 12:21:20PM +, Andre Przywara wrote: > On Fri, 8 Mar 2019 13:01:33 +0100 > Daniel Kiper wrote: > > > On Thu, Mar 07, 2019 at 03:14:14PM +, Andre Przywara wrote: > > > From: Andrei Borzenkov > > > > > > In respone to a BOOT

Re: [PATCH v3 00/10] net: bootp: add native DHCPv4 support

2019-03-08 Thread Daniel Kiper
On Thu, Mar 07, 2019 at 03:14:06PM +, Andre Przywara wrote: > A minor rework compared to v2, addressing Daniel's comments on the list. > The former patch 2/9 has been split up to first refactor the > parse_dhcp_vendor() function, then later introduce the OVERLOAD > functionality. The other mino

Re: GRUB 2.04 freeze date announcement

2019-03-12 Thread Daniel Kiper
Hi, On Fri, Mar 01, 2019 at 12:31:40PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Hello everyone! > > We are happy to announce that the upcoming release of Grub 2.04 is expected > in March. In order to prepare the release we would freeze on Monday, March > 11, 23:59:59 UTC. From that point no n

Re: [PATCH] Save/restore CWD more reliably on Unix

2019-03-12 Thread Daniel Kiper
stead > when it can, avoiding this category of problem. > > Fixes Debian bug #918700. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] Add %X to grub_vsnprintf_real and friends

2019-03-12 Thread Daniel Kiper
On Mon, Mar 11, 2019 at 03:05:19PM +, Colin Watson wrote: > This is needed for UEFI Boot* variables, which the standard says are > named using upper-case hexadecimal. Missing SOB. I assume that I can add yours. If yes then Reviewed-by: Daniel Kiper

Re: [PATCH v3 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-12 Thread Daniel Kiper
On Fri, Mar 08, 2019 at 12:14:15PM +0100, Daniel Kiper wrote: > On Fri, Mar 08, 2019 at 01:26:37AM +0100, Jesús Diéguez Fernández wrote: > > In order to be able to read from and write to model-specific registers, > > two new modules are added. They are i386 specific, as t

Re: [PATCH 0/2] *** SUBJECT HERE ***

2019-03-13 Thread Daniel Kiper
On Mon, Mar 11, 2019 at 03:04:49PM +, Colin Watson wrote: > Some UEFI firmware is easily provoked into running out of space in its > variable storage. This is usually due to certain kernel drivers (e.g. > pstore), but regardless of the cause it can cause grub-install to fail > because it curre

Re: [PATCH v3 2/2] Add new MSR modules (rdmsr/wrmsr)

2019-03-13 Thread Daniel Kiper
On Wed, Mar 13, 2019 at 12:35:48AM +0100, Jesús Diéguez Fernández wrote: > El 12/3/19 a las 20:12, Daniel Kiper escribió: > > On Fri, Mar 08, 2019 at 12:14:15PM +0100, Daniel Kiper wrote: > >> On Fri, Mar 08, 2019 at 01:26:37AM +0100, Jesús Diéguez Fernández wrote: > >&

Re: [PATCH 0/2] *** SUBJECT HERE ***

2019-03-13 Thread Daniel Kiper
On Wed, Mar 13, 2019 at 10:12:26AM +, Colin Watson wrote: > On Wed, Mar 13, 2019 at 10:56:47AM +0100, Daniel Kiper wrote: > > This looks like something for longer discussion. So, I am going to take > > the patchset after the release if you do not convince me that it should >

<    1   2   3   4   5   6   7   8   9   10   >