On Tue, Feb 12, 2019 at 05:46:54PM +0000, Andre Przywara wrote: > From: Andrei Borzenkov <arvidj...@gmail.com> > > In contrast to BOOTP, DHCP uses a 4-way handshake, so requires to send > packets more often. > > Refactor the generation and sending of the BOOTREQUEST packet into a > separate function, so that future code can more easily reuse this. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> But one nitpick below... > - err = grub_net_send_ip_packet (&ifaces[j], &target, &ll_target, nb, > - GRUB_NET_IP_UDP); > - grub_netbuff_free (nb); > - if (err) > - return err; > + need_poll = 1; > } > - if (!done) > + if (!need_poll) > break; > grub_net_poll_cards (interval, 0); > } > > err = GRUB_ERR_NONE; > + This is not needed. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
