test this much at all beyond
compile-testing as I don't have a suitable system myself ...)
I suppose it might be nice to macroify the stuff in
grub_util_getdiskname, but TBH I'm not sure it would shorten it all that
much or make it much more readable, so I didn't both
r: Bazaar works fine on Savannah too. From another project:
$ bzr push
Using saved push location: bzr+ssh://bzr.sv.gnu.org/man-db/trunk
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
_WARNING([pointer-arith])
MAN_GCC_WARNING([write-strings])
MAN_GCC_WARNING([strict-prototypes])
MAN_GCC_WARNING([shadow])
MAN_GCC_WARNING([format-security])
MAN_GCC_WARNING([no-missing-field-initializers])
fi
Feel free to use and adjust to taste if you want.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
/00_all_gcc-trampolinewarn.patch?rev=1.1&view=markup
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
tml, with
the review comments incorporated, would be a reasonable place to start?
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
h the paperwork doesn't seem to have arrived yet (though
I was away for a couple of weeks; maybe I should have another dig
through the post pile ...)
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mai
de)" \
+ linux_entry "${OS}, Linux ${version} (recovery mode)" \
"single ${GRUB_CMDLINE_LINUX}"
list=`echo $list | tr ' ' '\n' | grep -vx $linux | tr '\n' ' '`
Thanks,
--
Colin Watson [cjw
put]\n\
\n\
Tool to convert pe image to elf.\n\
\nOptions:\n\
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
ChangeLog
===
--- ChangeLog (revision 2334)
+++ ChangeLog (working copy)
@@ -1,3 +1,9 @@
+2009-06-17 Colin Watson
+
+ * util/elf/grub-mkimage.c (usage): Prefix each option line with two
+ spaces, for the benefit of help2man.
+ * util/i38
This patch fixes
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/190207.
Index: ChangeLog
===
--- ChangeLog (revision 2335)
+++ ChangeLog (working copy)
@@ -1,5 +1,10 @@
+2009-06-17 Colin Watson
+
+ * util/grub
menu header text, advice on
keystrokes for editing menu entries, etc.) is most important to us, and
anything else is secondary.
I don't really care very much about translation of error messages
myself. If your system fails to boot then there are loads of things
witch to that! What does everyone think?
It's not clear just from the screenshot what I'm supposed to do at that
screen. Hit Tab to get to options? Cursor-key off the bottom? Press O or
H?
I think it's too terse in general.
--
Colin Watson [cjwat...
y can just remove the os-prober package, but that doesn't really
scale as other packages are allowed to depend on it too.
Perhaps we could have a configuration option for this? Patch attached.
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
Index: ut
On Fri, Jul 10, 2009 at 07:31:21PM +0200, Robert Millan wrote:
> On Wed, Jul 08, 2009 at 04:38:23PM +0100, Colin Watson wrote:
> > Some people seem to want to disable os-prober for various reasons (e.g.
> > they have lots of test installations lying around that they don't
>
cannot be recommended.
I'm pretty sure this is fixable with blockdev --setro. The main reason
we haven't got round to doing this in os-prober yet is that we need to
get round to adding blockdev to busybox (which is important for
os-prober's original purpose
tives; I
believe this algorithm matches that in the Linux kernel. Look at
libparted/labels/dos.c:msdos_probe(), which is already FSF-copyrighted
and GPLv3+. GRUB should use the same algorithm, and then the worst case
is that things will fail consistently.
--
Colin W
ne if
> an MBR is valid by checking the bootable flag, and this is not always so.
If the bootable flag is neither 0 nor 0x80, then neither libparted nor
the Linux kernel will understand it as a DOS partition table. Is it
really all that helpful for GRUB to attempt to do so?
I
set) or 0x80 (set)
>
> Yes. GRUB's boot.img doesn't do anything with it AFAICT.
That's as may be, sure; but checking that that byte is one of the two
permitted values in all four partitions happens to be a good sanity
check for whether it's really a
pass GRUB
device names to grub-probe?
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
On Wed, Jul 29, 2009 at 05:03:44PM -0400, Pavel Roskin wrote:
> On Wed, 2009-07-29 at 19:35 +0100, Colin Watson wrote:
> > $ sudo grub-probe -d /dev/sda1 -t drive
> > (hd0,1)
> >
> > I have a reason to want to do the reverse of this: I have a
> > libparted-b
e.
I don't remember the exact conversation we had at the time, but I think
that template can be changed once Debian changes its default.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
ut as desired. I also moved the timeout down to after
the point when the graphical terminal is initialised, to decrease the
period when GRUB isn't in the desired screen resolution.
2009-08-10 Colin Watson
* util/grub-mkconfig.in: Export GRUB_HIDDEN_TIMEOUT.
* util/grub.d/00
starts a framebuffer then it has
no way to display any text at all, and it doesn't seem to start one
until relatively late for me. It may be that the next step here is to
try to explicitly tell the kernel to set the correct VESA mode rather
than using 0x0F04, but I thought I'd send thi
On Mon, Aug 10, 2009 at 01:44:50PM +0200, Robert Millan wrote:
> On Mon, Aug 10, 2009 at 11:38:11AM +0100, Colin Watson wrote:
> > I'd like to integrate http://grub.enbug.org/Hiddenmenu as a
> > grub-mkconfig option so that we can use it by default in Ubuntu. How
> > do
On Mon, Aug 10, 2009 at 01:49:40PM +0200, Robert Millan wrote:
> On Mon, Aug 10, 2009 at 12:01:02PM +0100, Colin Watson wrote:
> > If the user set "keep" in gfxpayload, as I understand it, that indicates
> > that they want the graphical mode set by GRUB to persist thro
On Mon, Aug 10, 2009 at 02:05:15PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Colin Watson wrote:
> > This doesn't quite work perfectly yet. It's better than before - I've
> > tested this, and if everything works properly then the result is a
>
On Mon, Aug 10, 2009 at 02:38:42PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Colin Watson wrote:
> > Yes, it completely skips modesetting.
> >
> >> What if the same mode is passed as a value? Does linux redoes the
> >> modesetting?
> >
> &g
On Mon, Aug 10, 2009 at 05:15:41PM +0200, Robert Millan wrote:
> On Mon, Aug 10, 2009 at 12:58:35PM +0100, Colin Watson wrote:
> > It also seems that doing this right is tricky on the kernel side (see
> > https://lists.ubuntu.com/archives/kernel-team/2009-August/006773.html
> &
ot actually quite true that vid_mode isn't used *at all* with the
32-bit boot protocol; it's still saved for use with ACPI sleep.)
> Does 0x0F04 really do something when used in combination with Linux' vesafb?
It seems to be 16-bit boot protocol only. I withdra
work with Linux today, and whether
OS X can do it is not really directly relevant to that.
Regards,
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
t setting up vid_mode to match
gfxpayload unless "keep" is given.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
y incorrect for it to be converted
again; AFAICS that code will only work properly on little-endian CPUs.
This looks as if it ought to be better, although I'm not really in a
position to test it:
if (len > data->size)
len = data->size;
--
Colin Wat
as though we
can put this together using grub-editenv, grub-mkconfig will need to
support it.
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
facilities), although I agree with the suggestions from Robert/Pavel
that the save step should be a single command/function.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
On Wed, Aug 12, 2009 at 09:41:39AM +0100, Colin Watson wrote:
> On Wed, Aug 12, 2009 at 02:43:34AM +0200, Robert Millan wrote:
> > On Mon, Aug 10, 2009 at 07:10:12PM +0200, Vladimir 'phcoder' Serbinenko
> > wrote:
> > > What about savedefault? Which savedefault w
is at least ".
grub-mkconfig would end up carrying a bit of bloat, but at least the
bloat is in /usr, and I'm assuming that at this point things are stable
enough that we won't be talking about *too* many changes.
What do people think about this general a
Red Hat has an assignment already on file,
and it looks like mine is finally making some progress ...
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090725/commands/sleep.c grub2-1.96+20090725
On Wed, Aug 12, 2009 at 06:10:18PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Colin Watson wrote:
> > This is based on previous work in GRUB Legacy by Kristian and Peter
> > (CCed). Peter tells me that Red Hat has an assignment already on file,
> > and it looks l
On Thu, Aug 13, 2009 at 02:54:29AM -0400, Pavel Roskin wrote:
> On Wed, 2009-08-12 at 16:25 +0100, Colin Watson wrote:
> > I'm having persistent problems with grub.cfg and core.img getting out of
> > sync. The usual pattern is:
> >
> > * Some shiny new featur
On Mon, Aug 10, 2009 at 05:10:31PM +0200, Robert Millan wrote:
> On Mon, Aug 10, 2009 at 12:55:05PM +0100, Colin Watson wrote:
> > > If we default to verbose, we could also have an option to turn it off from
> > > /etc/default/grub, if that makes life easier for you.
> &g
On Thu, Aug 13, 2009 at 10:52:05PM +0200, Robert Millan wrote:
> On Wed, Aug 12, 2009 at 11:14:31PM +0100, Colin Watson wrote:
> > On Wed, Aug 12, 2009 at 06:10:18PM +0200, Vladimir 'phcoder' Serbinenko
> > wrote:
> > > Colin Watson wrote:
> > > > Th
On Sun, Aug 23, 2009 at 03:22:41PM +0200, Felix Zielcke wrote:
> Doestn't grub-mkconfig need to export it so it's actually usable
> in /etc/default/grub?
Yes, that seems likely. Sorry about that.
2009-08-23 Colin Watson
* util/grub-mkconfig.in: Export GRUB_DISABLE_O
On Sun, Aug 23, 2009 at 08:42:52PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> This partition scheme is "PC-style" ans calling it "msdos" effectively
> means miscrediting IBM's work to Microsoft. I don't believe this to be
> correct.
It's c
On Mon, Aug 24, 2009 at 12:27:45AM +0200, Robert Millan wrote:
> On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote:
> > +static int
> > +grub_at_keyboard_keystatus (void)
> > +{
> > + /* FIXME: I don't know if getting key modifier status is poss
On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote:
[Could you please preserve attributions in your replies? I've reinserted
one here so that it's clear who wrote what.]
> Colin Watson wrote:
> > The values I picked for the constants wer
On Mon, Aug 24, 2009 at 01:57:26PM +0200, Robert Millan wrote:
> On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote:
> > No, that code only spots make scan codes arriving after GRUB's terminal
> > starts up. AFAICS it has no way to tell whether e.g. Shift was held d
I was following
existing style, so the other code should be updated too.
I don't see anything in the USB HID spec about the number of times one
must attempt to get a keyboard report, so I think it must simply be a
timeout. USB frames are 1ms so waiting for 50ms shoul
t:
./grub-mkrescue --modules='uhci usb_keyboard' --pkglibdir=.
--grub-mkimage=./grub-mkimage ../t/disk
qemu -boot d -cdrom ../t/disk -usb -usbdevice keyboard
--
Colin Watson [cjwat...@ubuntu.com]
___
Gru
On Mon, Aug 24, 2009 at 04:26:09PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Mon, Aug 10, 2009 at 6:41 PM, Colin Watson wrote:
> > On Mon, Aug 10, 2009 at 06:27:04PM +0200, Vladimir 'phcoder' Serbinenko
> > wrote:
> >> Framebuffer console
On Mon, Aug 24, 2009 at 05:23:00PM +0100, Colin Watson wrote:
> On Mon, Aug 24, 2009 at 04:28:00PM +0200, Robert Millan wrote:
> > Please go ahead (I assume you've tested it, at least with QEMU's USB
> > keyboard).
>
> Hmm. Does GRUB actually work with that r
On Mon, Aug 24, 2009 at 04:28:00PM +0200, Robert Millan wrote:
> On Mon, Aug 24, 2009 at 02:27:07PM +0100, Colin Watson wrote:
> > Perhaps we can apply the following patch first, then? I was following
> > existing style, so the other code should be updated too.
>
> Ah, sor
) fixes some compilation errors in your
patch and (b) adds USB keyboard support back in. How does this look?
2009-08-24 Colin Watson
2009-08-24 Robert Millan
Add `getkeystatus' terminal method. Use it in `sleep' to detect
Shift being held down.
* include/g
On Tue, Aug 25, 2009 at 12:41:20AM +0200, Robert Millan wrote:
> On Mon, Aug 24, 2009 at 11:04:19PM +0100, Colin Watson wrote:
> > +/* See http://heim.ifi.uio.no/~stanisls/helppc/bios_data_area.html for a
> > + description of the BIOS Data Area layout. */
> > +struct grub_m
On Tue, Aug 25, 2009 at 12:02:17AM +0100, Colin Watson wrote:
> I'm open to other ideas. 'sleep --interruptible 0' is not an entirely
> natural way to express what I'm looking for, so I'm not particularly
> attached to it. 'if sleep --interruptible 0;
On Wed, Aug 26, 2009 at 08:39:00PM +0200, Robert Millan wrote:
> On Wed, Aug 26, 2009 at 04:33:56PM +0100, Colin Watson wrote:
> > Index: commands/sleep.c
> > ===
> > --- commands/sleep.c(revision 2
grub2/tmp/grub2-1.96+20090826/normal/cmdline.c:276:
warning: format not a string literal and no format arguments
2009-08-27 Colin Watson
* normal/cmdline.c (grub_cmdline_get): Supply a format string as
the first argument to grub_printf.
Ind
On Fri, Aug 28, 2009 at 02:44:15PM +0200, Robert Millan wrote:
> On Wed, Aug 26, 2009 at 09:26:06PM +0100, Colin Watson wrote:
> > If GRUB_HIDDEN_TIMEOUT is set to a non-zero value, I would use sleep
> > rather than keystatus, I think. (At least, if I decided I wanted to
&
On Fri, Aug 28, 2009 at 02:48:45PM +0200, Robert Millan wrote:
> On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote:
> > 2009-08-27 Colin Watson
> >
> > * normal/cmdline.c (grub_cmdline_get): Supply a format string as
> > the first argument to gru
K_DEFCFG;
+ command = argv[optind];
}
+ else
+{
+ filename = argv[optind];
+ command = argv[optind + 1];
+}
- filename = argv[optind];
- command = argv[optind + 1];
-
if (strcmp (command, "create") == 0)
create_envblk_file (filename);
else if
On Wed, Sep 02, 2009 at 02:49:39AM +0100, Colin Watson wrote:
> I came across the idea of an xasprintf function in Gnulib a while back.
> Using this both fixes the above class of warnings by always checking the
> return value of asprintf, and also provides an IMO more intuitive
>
#x27;s
theoretically possible that it may cause previously-"working" cases to
fail due to the extra strictness; so I thought I'd post it here in case
it helps anyone out.
2009-09-02 Colin Watson
* util/grub-probe.c (probe): Test st.st_mode using S_ISREG macro
ra
endif
+
#ifndef HAVE_ASPRINTF
int
@@ -377,11 +391,8 @@
int status;
va_list ap;
- /* Should be large enough. */
- *buf = xmalloc (512);
-
va_start (ap, fmt);
- status = vsprintf (*buf, fmt, ap);
+ status = vasprintf (*buf, fmt, ap);
va_end (ap);
return
I'm afraid I temporarily ran out of steam at this point, so there are
still lots of commands to go, but here's a start. Does this look OK?
2009-09-02 Colin Watson
* docs/grub.texi: Describe one-based partition numbering.
Document acpi, blocklist, crc, export, insmod,
On Wed, Sep 02, 2009 at 11:13:19AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Wed, Sep 2, 2009 at 11:06 AM, Colin Watson wrote:
> > I'm afraid I temporarily ran out of steam at this point, so there are
> > still lots of commands to go, but here's a start.
This implements saving an environment variable with a given value
without having to set that variable first, as suggested by Pavel here:
http://lists.gnu.org/archive/html/grub-devel/2009-06/msg00190.html
2009-09-02 Colin Watson
* commands/loadenv.c (grub_cmd_save_env): Allow an
l the boot loader to boot something else just once, but then return
to the previous default; consider unattended scenarios).
2009-09-02 Vladimir Serbinenko
2009-09-02 Colin Watson
* normal/menu.c (grub_menu_execute_entry): Save selected entry title
in `chosen_en
On Wed, Sep 02, 2009 at 03:11:32PM +0100, Colin Watson wrote:
> Still to do: update grub-set-default to use this (obvious, I think);
> implement 'savedefault --once' and grub-reboot (useful when you want to
> tell the boot loader to boot something else just once, but then retur
objections?
2009-09-03 Colin Watson
* configure.ac: By default, GCC 4.4 generates .eh_frame sections
containing unwind information in some cases where it previously did
not. Use -fno-dwarf2-cfi-asm if available to restore the old
behaviour. See http://patchwork.
-like
line editing being supported.
2009-09-03 Colin Watson
Display normal mode shell introductory message only when it makes
sense to do so.
* normal/main.c (grub_normal_reader_init): Rename to ...
(grub_normal_display_intro): ... this.
(grub_normal_read_line
)
2009-09-03 Colin Watson
* configure.ac: By default, GCC 4.4 generates .eh_frame sections
containing unwind information in some cases where it previously did
not. Use -fno-dwarf2-cfi-asm if available to restore the old
behaviour. See http://patchwork.kernel.o
On Thu, Sep 03, 2009 at 04:16:27PM +0200, Robert Millan wrote:
> On Tue, Sep 01, 2009 at 05:19:51PM +0100, Colin Watson wrote:
> > (Per a discussion with Robert on IRC, this can be post-1.97 if you
> > like.)
> >
> > Would it make sense for grub-editenv to have a defa
ge some specific bug
reports on it too.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote:
> On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote:
> > 2009-09-02 Colin Watson
> >
> > * commands/loadenv.c (grub_cmd_save_env): Allow an optional
> > explicit value (`s
On Thu, Sep 03, 2009 at 04:47:40PM +0200, Robert Millan wrote:
> On Thu, Sep 03, 2009 at 11:22:04AM +0100, Colin Watson wrote:
> > I'd like to commit this for 1.97; it's important for users of recent
> > distributions that use GCC 4.4 by default (which is the current
On Thu, Sep 03, 2009 at 04:38:27PM +0200, Robert Millan wrote:
> On Wed, Sep 02, 2009 at 03:11:32PM +0100, Colin Watson wrote:
> > I realise that Robert already said that this was post-1.97 material, but
> > I'd like to see if we can agree on this in advance.
>
> This pa
On Thu, Sep 03, 2009 at 05:38:27PM +0200, Robert Millan wrote:
> Ok. Unless someone knows better, I'm fine with your previous approach.
Committed, then; if somebody has a better idea they can always refine
from here.
--
Colin Watson [cjwat...@ub
; > > before in probe():
> >
> > A proper fix for this would be too intrusive for 1.97. Unless someone
> > has a bright idea, I'll comment it out untill we've released.
>
> For the release this is probable the best idea.
Agreed. Sorry for this regression.
have a
> password.
I think it'd be more sensible to do this in grub-mkconfig itself - it
doesn't really fit well into the /etc/grub.d/ hook system, which is
really just for generating output.
--
Colin Watson [cjwat...@ubuntu.com]
_
On Sun, Sep 06, 2009 at 03:43:46PM +0200, Felix Zielcke wrote:
> Am Sonntag, den 06.09.2009, 14:38 +0100 schrieb Colin Watson:
> > I think it'd be more sensible to do this in grub-mkconfig itself - it
> > doesn't really fit well into the /etc/grub.d/ hook system, whi
n't decide whether or not this is a terrible idea, so I'm sending
mail in case somebody thinks it's a good idea and wants to run with it.
:-)
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-de
od.
> Of course, the startup fs modules are still read-only, but after
> entering normal mode, users can switch to the fuse driver for more
> functionality.
The level of functionality provided by the existing filesystem modules
would be quite suff
On Mon, Sep 07, 2009 at 06:39:13PM +0800, Bean wrote:
> On Mon, Sep 7, 2009 at 6:18 PM, Colin Watson wrote:
> > On Mon, Sep 07, 2009 at 06:07:48PM +0800, Bean wrote:
> >> Actually I've considered this before. My goal is to add a mini FUSE fs
> >> interface so that i
bly older version of Autoconf than we already require.
2009-09-10 Colin Watson
* configure.ac: Don't look for help2man when cross-compiling. Fixes
part of bug #27349.
Index: configure.ac
===
--- configure
m image stored
on an NTFS filesystem, and wondering why he was getting "out of disk"
errors. Also, obviously, I didn't refer to Microsoft code in the process
of fixing this.)
2009-09-10 Colin Watson
* include/grub/ntfs.h (struct grub_fshelp_node): Change `size'
On Thu, Sep 10, 2009 at 09:17:54PM +0200, Robert Millan wrote:
> On Thu, Sep 10, 2009 at 05:39:14PM +0100, Colin Watson wrote:
> > Index: include/grub/ntfs.h
> > ===
> > --- include/grub/ntfs.h (revision 2584)
and think it's likely to be more
efficient, but I'm attaching both alternatives to this mail. Please let
me know what you think.
Thanks,
--
Colin Watson [cjwat...@ubuntu.com]
2009-09-10 Colin Watson
* disk/loopback.c (struct grub_loopback
On Thu, Sep 10, 2009 at 09:20:19PM +0200, Robert Millan wrote:
> On Thu, Sep 10, 2009 at 04:37:29PM +0100, Colin Watson wrote:
> > Index: configure.ac
> > ===
> > --- configure.ac(revision 2584)
> > +
On Fri, Sep 11, 2009 at 03:13:57PM +0200, Robert Millan wrote:
> On Thu, Sep 10, 2009 at 11:51:04PM +0100, Colin Watson wrote:
> > Revised patch follows, also addressing Felix's comment. Is this better?
>
> Looks fine.
Committed, thank
On Fri, Sep 11, 2009 at 03:14:53PM +0200, Robert Millan wrote:
> On Thu, Sep 10, 2009 at 08:24:44PM +0100, Colin Watson wrote:
> > It probably would, but I don't think anything cares, does it? This data
> > structure is purely internal - it isn't read from disk in a way th
; > more efficient.
>
> I don't see how grub-mkconfig could compensate for a missing feature in
> save_env. Perhaps I'm missing the context here.
The choices are:
var=value
save_env var
(uglier grub-mkconfig code, smaller core)
save_env var=value
(simpler grub-mkconf
le does not contain a filesystem, grub2 crashes (there
> is a sudden restart) when I run the test.
The following patch fixes this. OK to commit?
2009-09-14 Colin Watson
* commands/test.c (get_fileinfo): Return immediately if
grub_fs_p
I recently fixed
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/393565 in
os-prober svn. GRUB needs this patch to handle the new output correctly.
2009-09-14 Colin Watson
* util/grub.d/30_os-prober.in: Cope with Windows 7 in os-prober
output.
Index: util/grub.d
On Mon, Sep 14, 2009 at 12:27:06PM +0100, Colin Watson wrote:
> I recently fixed
> https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/393565 in
> os-prober svn. GRUB needs this patch to handle the new output correctly.
Felix OKed this on #debian-boot so I went ahead and
be much easier to understand and maintain.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
ain the list, and my expectation would be that churn would be
substantial and frequent. If it used some kind of generic superset, I'd
expect that we'd end up ignoring it and doing our own thing anyway.
I've just seen this done wrong
I'm not quite sure I've got everything right here, so please review.
It seemed much simpler to add everything to Makefile.in than to go
through conf/*.rmk for this, as there's no platform-specific work to be
done here.
2009-09-15 Colin Watson
Build info documentat
arefully installed there five years ago", I must
admin.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
_NUM 1021
> with a bigger number
I'm a little baffled. Why does the disk cache size make a difference
here? He has four disks - I'd have thought that 1021 would be plenty.
--
Colin Watson [cjwat...@ubuntu.com]
___
On Mon, Sep 21, 2009 at 04:22:53PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Colin Watson wrote:
> > On Sun, Sep 20, 2009 at 10:00:13PM +0200, Vladimir 'phcoder' Serbinenko
> > wrote:
> >> As a workaround for time being you can use one or more o
On Tue, Sep 22, 2009 at 09:49:23AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Colin Watson wrote:
> > * configure.ac: Check for makeinfo.
> > * Makefile.in (MAKEINFO, INFOS, info_INFOS): New variables.
> > (MAINTAINER_CLEANFILES): Add $(INFOS), d
101 - 200 of 703 matches
Mail list logo
