[PATCH 0/2] Enable bigtime feature for xfs driver

2021-03-23 Thread Carlos Maiolino
rub_unixtime2datetime() to support 64bit timestamp handling. I tested these patches on both x86_64 and x86_32 and in my testing they worked as expected, but again, I am new to grub code, so I might have missed some corner cases. Carlos Maiolino (2): Add bigtime support for xfs driver Use 64bit type

[PATCH 2/2] Use 64bit type for filesystem timestamp

2021-03-23 Thread Carlos Maiolino
y2038. Signed-off-by: Carlos Maiolino --- grub-core/fs/affs.c | 2 +- grub-core/fs/ext2.c | 2 +- grub-core/fs/fat.c | 4 ++-- grub-core/fs/hfs.c | 2 +- grub-core/fs/hfsplus.c | 2 +- grub-core/fs/iso9660.c | 6 +++--- grub-core/fs/nilfs2

[PATCH 1/2] Add bigtime support for xfs driver

2021-03-23 Thread Carlos Maiolino
files with timestamps up to INT32_MAX (y2038), any file with timestamps bigger than this will overflow the counter, causing grub to show wrong timestamps (not really much difference on current situation). Signed-off-by: Carlos Maiolino --- grub-core/fs/xfs.c | 69

Re: [PATCH 0/2] Enable bigtime feature for xfs driver

2021-03-24 Thread Carlos Maiolino
On Tue, Mar 23, 2021 at 07:09:01PM +0100, Daniel Kiper wrote: > Hey Carlos, > > On Tue, Mar 23, 2021 at 02:29:57PM +0100, Carlos Maiolino wrote: > > Hello. > > First, my apologies if I messed up with code styling here somehow, it's the > > first time I send a pa

[PATCH V2 0/2] Enable bigtime feature for xfs driver

2021-04-14 Thread Carlos Maiolino
er cases I could remember, in my testing they worked as expected, but again, I am new to grub code, so I might have missed some other corner cases. Carlos Maiolino (2): fs/xfs: Add bigtime support for xfs driver fs: Use 64bit type for filesystem timestamp grub-core/fs/affs.c | 2 +- grub-

[PATCH V2 1/2] fs/xfs: Add bigtime support for xfs driver

2021-04-14 Thread Carlos Maiolino
files with timestamps up to INT32_MAX (y2038), any file with timestamps bigger than this will overflow the counter, causing grub to show wrong timestamps (not really much difference on current situation). Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino --- Changelog

[PATCH V2 2/2] fs: Use 64bit type for filesystem timestamp

2021-04-14 Thread Carlos Maiolino
changes enables grub to support dates beyond y2038. Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino --- Changelog: V2: - Update subject adding 'fs:' prefix - Update patch description with more details about the 32 -> 64 bit ty

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-20 Thread Carlos Maiolino
ystem needs repair. Please run a XFS repair > tool")); > +} > + I'm not a grub developer, but from the XFS point of view, this looks fine. Feel free to add my reviewed tag if it makes sense to you: Reviewed-by: Carlos Maiolino -- Carlos ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Carlos Maiolino
Hi Daniel > > --- a/grub-core/fs/xfs.c > > +++ b/grub-core/fs/xfs.c > > @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); > > #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0)/* filetype in > > dirent */ > > #define XFS_SB_FEAT_INCOMPAT_SPINODES (1 << 1)/* sparse inode > > chunks

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-29 Thread Carlos Maiolino
On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: > Hello Vladimir, > > On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: > > Filesystems are not mounted in GRUB. This patch will result in GRUB > > outputting a warning on every access to any XFS that has this flag se

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-26 Thread Carlos Maiolino
On Thu, Aug 26, 2021 at 09:54:59AM +0200, Erwan Velu wrote: >I should have cc Carlos Maiolino who authored this patch. >This is now done. > >Le mer. 25 août 2021 à 15:32, Erwan Velu <[1]erwanalia...@gmail.com> a >écrit : > > Commit 8b1e5d1936fff

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-08-30 Thread Carlos Maiolino
Hi. On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: >Good day list, >Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiol...@redhat.com> >a écrit : > > [..] > Thanks for spotting this! > >I'm adding the maintainers in

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-01 Thread Carlos Maiolino
On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > >Good day list, > > >

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Carlos Maiolino
On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > >Good day list, > > >