Hi Daniel
> > --- a/grub-core/fs/xfs.c
> > +++ b/grub-core/fs/xfs.c
> > @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+");
> > #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0) /* filetype in
> > dirent */
> > #define XFS_SB_FEAT_INCOMPAT_SPINODES (1 << 1) /* sparse inode
> > chunks */
> > #define XFS_SB_FEAT_INCOMPAT_META_UUID (1 << 2) /* metadata UUID */
> > +#define XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR (1 << 4) /* needs
> > xfs_repair */
>
> s/XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR/XFS_SB_FEAT_INCOMPAT_NEEDS_REPAIR/
I believe Javier got this from kernel, I wonder if it doesn't make sense to keep
the flags names consistent with kernel?
>
> > + grub_cpu_to_be16_compile_time(XFS_SB_VERSION_5) &&
>
> Hmmm... Is XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR flag available for
> XFS_SB_VERSION_5 only? Should not we use ">=" instead of "=="?
> Does not older XFS versions support this flag?
No, only xfs V5 superblock supports needsrepair flag.
Hope it helps somehow.
Cheers.
--
Carlos
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
