Re: Idea: Move kernel to upper memory

2008-09-06 Thread BVK
On Fri, Sep 5, 2008 at 12:49 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Wed, Sep 03, 2008 at 04:15:33PM +0530, BVK Chaitanya wrote: >> >> Since payload(s) needs to be present at their precise positions only >> after the boot command, we can always deterministi

bzr trunk failed to build from separate build directory

2009-11-01 Thread BVK
Am I doing it wrong? Can anybody confirm this? -- bvk-chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: bzr trunk failed to build from separate build directory

2009-11-01 Thread BVK
On Sun, Nov 1, 2009 at 11:30 PM, Felix Zielcke wrote: > Solution is to add `-I$(srcdir)/include' to TARGET_CPPFLAGS in Makefile > or Makefile.in and call configure again Thanks. -- bvk-chaitanya ___ Grub-devel mailing list Grub-devel@g

On grub_strchr implementation

2009-11-01 Thread BVK
ed to mimic standard strchr semantics, but its implementation doesn't confrom the above requirement. Same goes for grub_strrchr function too. Attached is the patch to fix both of these. thanks, -- bvk-chaitanya fix-strchar.patch Description: Binary data _

Re: On grub_strchr implementation

2009-11-01 Thread BVK
as this check, so kept it as it is. I didn't want to break any code if it is assuming this behavior. I just saw that other functions like, grub_strcmp, etc. don't check for NULL dereference, so its better to remove this check. I will send a new

Re: On grub_strchr implementation

2009-11-01 Thread BVK
k_dev->open, etc.). thanks, -- bvk-chaitanya fix-strchr-strrchr.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: On grub_strchr implementation

2009-11-02 Thread BVK
On Mon, Nov 2, 2009 at 7:17 PM, Robert Millan wrote: > > Please see the commit I did yesterday.  Does this suffice? > Yes, it is sufficient. -- bvk-chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman

Bug in read_handler_list (autoloading) ???

2009-11-10 Thread BVK
libncurses.so.5.7 00ccd000-00ccf000 r-xp 00034000 08:03 770/lib/libncurses.so.5.7 00ccf000-00cd rwxp 00036000 08:03 770/lib/libncurses.so.5.7 00dfa000-00dfb000 r-xp 00:00 0 [vdso] 08048000-08095000 r-xp 08:03 58479 /home/bvk/sid-home/foss/grub2/b

Re: Bug in read_handler_list (autoloading) ???

2009-11-12 Thread BVK
Valgrind log is attached. It also reported invalid free for the same place. BTW, valgrind is run as sudo valgrind -v --log-file=/tmp/valgrind.log ./grub-emu -- bvk.chaitanya valgrind.log Description: Binary data ___ Grub-devel mailing list Gru

[RFC][PATCH] Basic unit testing support for GRUB

2009-11-13 Thread BVK
Hi, Attached is the (experimental branch) patch for unit testing that I have in mind for GRUB. Please let me know your comments. It provides "make check" target which would build and execute test programs from "tests" directory. We can write small programs to test specific functions in GRUB.

Re: [RFC][PATCH] Basic unit testing support for GRUB

2009-11-23 Thread BVK
Hi, I have been busy last week, so I couldn't reply :-( But I am able to complete most of the framework. It has support for logging multiple testcase failures and reporting them at the end of test execution. Please go through the attached patch and let me know your suggestions. Attached frame

Re: [RFC][PATCH] Basic unit testing support for GRUB

2009-11-23 Thread BVK
Earlier patch had ChangeLog entry missing for conf/tests.rmk. Attached version has it fixed now. -- bvk.chaitanya testing-framework.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/

Re: [RFC][PATCH] Basic unit testing support for GRUB

2009-12-02 Thread BVK
Hi, I have been traveling a lot, so I couldn't reply :-( On Wed, Nov 25, 2009 at 4:34 PM, Felix Zielcke wrote: > > Thanks for your work. > A really useful test and hopefully not complicated to implement would be > if the config generated by grub-mkconfig (with e.g. 1 fake linux kernel) > can b

[PATCH] Syntax checker for GRUB script config file

2009-12-03 Thread BVK
Hi, Attached patch (experimental) adds a new tool, grub-script-check, that can be used to check grub.cfg file syntax. Idea is to use this tool during update-grub to catch any syntax errors and reject the update. This tool uses the same parsing code as the normal mode script engine, except that

Re: [RFC][PATCH] Basic unit testing support for GRUB

2009-12-03 Thread BVK
Please see the other thread "Syntax checker for GRUB script configuration file" for this tool. -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: multidistro grub2 idea

2007-07-22 Thread BVK
ot one where grub2 is installed. What are your thoughts about this idea? Can't grub2 merge menu.lst files from all grub2-readable partitions and generate a menu dynamically? I dont know, but does this require grub2 to load *all* filesystem modules on boot-up? -- bv

Re: Idea: Move kernel to upper memory

2008-09-03 Thread BVK Chaitanya
at it removes any arbitrary limits on number of modules or their placement, if at all limits exists. thanks, -- bvk-chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Syntax checker for GRUB script config file

2009-12-06 Thread BVK Chaitanya
On Fri, Dec 4, 2009 at 9:42 PM, Robert Millan wrote: > On Fri, Dec 04, 2009 at 07:12:12AM +0000, BVK wrote: >> >> Attached patch (experimental) adds a new tool, grub-script-check, that >> can be used to check grub.cfg file syntax.  Idea is to use this tool >> duri

Re: [PATCH] Syntax checker for GRUB script config file

2009-12-06 Thread BVK Chaitanya
ChangeLog entry was missing, this attachment has it fixed. -- bvk.chaitanya === modified file 'ChangeLog' --- old/ChangeLog 2009-12-02 07:36:13 + +++ new/ChangeLog 2009-12-06 15:50:49 + @@ -1,3 +1,7 @@ +2009-12-06 BVK Chaitanya + + * script/parser.y: Bu

Re: my plan for Multiboot 2

2009-12-09 Thread BVK Chaitanya
I don't have much knowledge in multiboot yet, but this case comes to my mind: Since GRUB2 is extensible (using modules), over time third party modules would be developed and they may want to pass their own parameters to kernels; so we should provide some scheme to differentiate standard (i.e, mul

Re: Broken common.rmk change

2009-12-09 Thread BVK Chaitanya
On Thu, Dec 10, 2009 at 3:15 AM, Robert Millan wrote: > On Mon, Dec 07, 2009 at 10:23:51PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> Seth proposed a hinting technique: >> search --fs_uuid ... -s root --hint hd0,1 >> then hd0,1 will be checked first and only on failure it will rever

Re: Unittests

2009-12-14 Thread BVK Chaitanya
Hi Carles, Yes, I wrote unit testing framework and is available as a patch here: http://lists.gnu.org/archive/html/grub-devel/2009-11/msg00349.html It is not reviewed and is very basic as of now. It has no example for scripted tests, but can be added using check_SCRIPTS make/rmk variable, simil

Re: Unittests

2009-12-16 Thread BVK Chaitanya
On Tue, Dec 15, 2009 at 5:18 AM, Carles Pina i Estany wrote: > > Writing a unittest for gettext it's very easy: it just needs a couple of > .mo and a script executing gettext "string" and checking that the result > is "string translated". Will get more interesting when ngettext will > come too :-)

Re: Unittests

2009-12-16 Thread BVK Chaitanya
Hi, On Thu, Dec 17, 2009 at 5:15 AM, Carles Pina i Estany wrote: > > when I said "it's very easy" I was thinking more like "you explain to me > how the unittest infrastructure works and I write the test" more than > the other way. But no problem at all if you want to write it! > For scripted tes

Re: Unittests

2009-12-17 Thread BVK Chaitanya
Hi, an update is > doing this already.  I hit these below problems, but i have > workarounds in mind: > >  a.  Option for not to display grub prompt (add PS1 environment variable ???) >  b.  Option to set noecho flag to tty. >  c.  Option to disable NCURSES escape sequences for serial terminal >

Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-22 Thread BVK Chaitanya
Hi Attached is the patch, which removes use of undefined grub_assert_fail function for catching bad-type-cast errors, with a better version __attribute__((error("msg"))) gcc extension. With this extension, gcc can give the exact location of the bad type cast at compile time. Unfortunately, I co

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-22 Thread BVK Chaitanya
grub_fatal already calls grub_abort, so grub_abort line is removed. -- bvk.chaitanya === modified file 'include/grub/handler.h' --- include/grub/handler.h 2009-03-01 17:51:44 + +++ include/grub/handler.h 2009-12-22 13:34:38 + @@ -55,6 +55,6 @@ GRUB_FIELD_MATCH (ptr, grub_

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-22 Thread BVK Chaitanya
2009/12/22 Vladimir 'φ-coder/phcoder' Serbinenko : >> ./include/grub/list.h:44: warning: 'error' attribute directive ignored > This situation is acceptable. In unlikely case that cast is indeed bad > you will get runtime error instead of compile error. But it would be a > benefit if abort message w

Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

2009-12-23 Thread BVK Chaitanya
2009/12/23 Gre'goire Sutre : > > For your information, I tested it on NetBSD 5.0 (with default gcc 4.1.3), > and everything seems fine. > Thanks Gre'goire. I wanted to ask you to verify, but i forgot to mention :-( -- bvk.chaitanya ___ Grub-devel

[PATCH] For loop support to GRUB script

2009-12-24 Thread BVK Chaitanya
Hi, Attached patch adds for-loop support to GRUB script. It is based on r/grub/people/bvk/grub-script branch. Please review it and let me know your comments. Unfortunately, there is a bug in GRUB script string arguments expansion, which is causing grub_script_for1.in test case to fail. I

[PATCH] Bug fix in GRUB script word expansion

2009-12-25 Thread BVK Chaitanya
og.scripting 2009-12-25 12:13:34 + @@ -1,5 +1,25 @@ 2009-12-25 BVK Chaitanya + * include/grub/script_sh.h (grub_script_arg_type_t): New types + added. + (grub_script_execute_arglist_to_arg): Function proptotype added. + (grub_script_execute_argument_to_string):

[PATCH] While and until loops support to GRUB script

2009-12-25 Thread BVK Chaitanya
Hi, Attached patch adds while and until commands support to GRUB script. It is also available in people/bvk/while-loop-support branch. This doesn't have any unit tests yet -- i am still thinking of how to break out of the loop, after few iterations. Also, i am not sure how to handle Ctrl

[PATCH] Fixes for some out of memory cases in GRUB script

2009-12-27 Thread BVK Chaitanya
Hi, Below patch fixes some out of memory cases, that I came across when I was working on lexer rewrite. This patch is based on people/bvk/while-loop-support branch, and is also available as people/bvk/oom-fixes branch. Let me know your comments. thanks, -- bvk.chaitanya === modified file

[PATC] Unit testing framework adjusted over trunk

2010-01-08 Thread BVK Chaitanya
Hi, Attached is the patch that adds unit-testing framework support to GRUB. Its been adjusted to work over trunk branch, and has few changes from what is available in my people/bvk/unit-testing-support branch. Since my all of my other works has one-or-two unit tests, this is a pre-requisite

[PATCH] Some tests using unit-testing-framework

2010-01-08 Thread BVK Chaitanya
. -- bvk.chaitanya === added file 'ChangeLog.some-testcases' --- ChangeLog.some-testcases1970-01-01 00:00:00 + +++ ChangeLog.some-testcases2010-01-09 04:56:25 + @@ -0,0 +1,22 @@ +2010-01-09 BVK Chaitanya + + Added some testcases. + + * tests/grub_script_vars1.in: Te

[PATCH] [RESEND] grub-script-check tool to validate grub.cfg syntax

2010-01-09 Thread BVK Chaitanya
-script-check. Let me know your comments. thanks, -- bvk.chaitanya === added file 'ChangeLog.grub-script-check' --- ChangeLog.grub-script-check 1970-01-01 00:00:00 + +++ ChangeLog.grub-script-check 2010-01-09 14:59:31 + @@ -0,0 +1,9 @@ +2010-01-09 BVK Chaitanya + + Adde

Re: [PATC] Unit testing framework adjusted over trunk

2010-01-09 Thread BVK Chaitanya
Some minor comments: + +if ! diff -q ${outfile1} ${outfile2} >/dev/null +then + echo "$1: GRUB and BASH outputs (${outfile1}, ${outfile2}) did not match" + status=1 +else +rm -f ${outfile1} ${outfile2} +fi + 1. In the above echo statement, $1 doesn't resolve to the testcase file name, use

Re: [PATC] Unit testing framework adjusted over trunk

2010-01-12 Thread BVK Chaitanya
it-testing-framework1970-01-01 00:00:00 + +++ ChangeLog.unit-testing-framework2010-01-12 10:19:08 + @@ -0,0 +1,37 @@ +2010-01-12 BVK Chaitanya + + * tests/util/grub-shell.in: New --boot option. + + * conf/tests.rmk: Build functional tests on make. + * Makefile

Bazaar workflow for GRUB

2010-01-14 Thread BVK Chaitanya
Hi, Attached is the initial version of workflow document for GRUB contributions. I am yet to get right DVCS right, so I suspect it might have minor differences from what other developers are following already. Let me know your comments. -- bvk.chaitanya GNU GRUB Workflow GNU GRUB project re

Re: [PATC] Unit testing framework adjusted over trunk

2010-01-14 Thread BVK Chaitanya
Hi, This has been committed to trunk with some minor changes. Its been reviewed by Vladimir (over IRC). thanks, -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Some tests using unit-testing-framework

2010-01-14 Thread BVK Chaitanya
00 @@ -0,0 +1,22 @@ +2010-01-09 BVK Chaitanya + + Added some testcases. + + * tests/grub_script_vars1.in: Testcase for different types of + variable expansions and arguments. + * tests/grub_script_echo1.in: Likewise. + * tests/grub_script_echo_keywords.in

Re: [PATCH] [RESEND] grub-script-check tool to validate grub.cfg syntax

2010-01-18 Thread BVK Chaitanya
On Sat, Jan 9, 2010 at 10:02 PM, BVK Chaitanya wrote: > > Attached patch adds a new utility, grub-script-check that can be used > to validate syntax of grub.cfg file generated using grub-mkconfig (or > update-grub).  I had sent this patch earlier based on experimental > branch, b

Re: Bazaar workflow for GRUB

2010-01-18 Thread BVK Chaitanya
On Mon, Jan 18, 2010 at 11:19 PM, Colin D Bennett wrote: >> >> * For Occasional Contributors >> >> This workflow is recommended for users/developers who want to fix >> just-one GRUB issue.  This involves a trunk checkout, some local >> commits (as necessary for fixing the issue) and sending the pa

Re: Bazaar workflow for GRUB

2010-01-18 Thread BVK Chaitanya
On Mon, Jan 18, 2010 at 11:45 PM, Colin Watson wrote: > > I recommend using a checkout for trunk, because that way bzr takes out a > write lock on the branch when you start committing and doesn't release > it until it's finished; it also warns you immediately if you're out of > date rather than ma

Re: Antialiased fonts patch.

2010-01-22 Thread BVK Chaitanya
Can you send us a screenshot? :) -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Fix for "underquoted definition of grub_*" in acinclude.m4

2010-01-22 Thread BVK Chaitanya
Hi, Attached patch fixes the underquoted definition warning (as in below example) generated during autogen.sh phase. Example warning: acinclude.m4:39: warning: underquoted definition of grub_ASM_USCORE acinclude.m4:39: run info '(automake)Extending aclocal' acinclude.m4:39: or see http://so

[PATCH] [RESEND] For loop support to GRUB script

2010-01-23 Thread BVK Chaitanya
# target_branch: file:///home/bvk/Work/grub2/lexer-rewrite/ # testament_sha1: d2a268ca298ac4a46b2a7ee8f2cd6a3a59d3b4ed # timestamp: 2010-01-24 10:08:53 +0530 # base_revision_id: bvk.gro...@gmail.com-20100123045852-\ # vls49fz4tcviyzdf # # Begin patch === added file 'ChangeLog.for-loop' --- Cha

Re: [PATCH] [RESEND] GRUB script lexer rewrite using flex

2010-01-25 Thread BVK Chaitanya
On Mon, Jan 25, 2010 at 1:27 PM, Robert Millan wrote: > On Sat, Jan 23, 2010 at 10:39:47AM +0530, BVK Chaitanya wrote: >> Attached is the updated patch with changes as per review comments (by >> phcoder).  With these changes sh.mod file size is reduced from 38K to >> 28K :-)

Re: [PATCH] [RESEND] While and until loops support to GRUB script

2010-01-25 Thread BVK Chaitanya
-4jx21vvs3as5bp6u # target_branch: file:///home/bvk/Work/grub2/for-loop/ # testament_sha1: 765eb235c266725c213c934ee0086cdd9cac5e53 # timestamp: 2010-01-26 09:40:09 +0530 # base_revision_id: bvk.gro...@gmail.com-20100123053341-\ # ukj4s8lpltdoslue # # Begin patch === added file 'ChangeLog.while-until-

Re: [PATCH] [RESEND] For loop support to GRUB script

2010-01-25 Thread BVK Chaitanya
Pushed into branches/for-loop -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] [RESEND] While and until loops support to GRUB script

2010-01-25 Thread BVK Chaitanya
) # revision_id: bvk.gro...@gmail.com-20100126070247-jav742bys6z6vz6n # target_branch: file:///home/bvk/Work/grub2/for-loop/ # testament_sha1: ab52b0aa586f2d8c04f5b84e8685bac20ce2d57c # timestamp: 2010-01-26 12:33:11 +0530 # base_revision_id: bvk.gro...@gmail.com-20100123053341-\ # ukj4s8lpltdoslue

[PATCH] Making parenthesis part of word; fixes set root=(hd1,1) issue

2010-01-26 Thread BVK Chaitanya
alphabets. -- bvk.chaitanya === modified file 'ChangeLog.lexer-rewrite' --- ChangeLog.lexer-rewrite 2010-01-22 13:37:27 + +++ ChangeLog.lexer-rewrite 2010-01-25 16:30:38 + @@ -1,3 +1,8 @@ +2010-01-25 BVK Chaitanya + + * script/yylex.l: Accept parenthesis as part of word. +

Fwd: On boot tests

2010-01-27 Thread BVK Chaitanya
FYI -- Forwarded message -- From: BVK Chaitanya Date: 2010/1/26 Subject: On boot tests To: Vladimir 'φ-coder/phcoder' Serbinenko Hi Vladimir, Let me know what you think of the attached linux boot testcase.  It is similar to what you have done, except that it does

[PATCH] --foo bar cmdline argument parsing support for grub-* scripts

2010-02-06 Thread BVK Chaitanya
104-9ptsm4whvibzr2k6 # target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: 5aafafe74a15ba6adf3fccd3253863820f21a972 # timestamp: 2010-02-07 10:37:51 +0530 # base_revision_id: phco...@gmail.com-20100205233207-csk991t3yceon285 # # Begin patch === modified file 'util/grub-install.in&

Re: [PATCH] --foo bar cmdline argument parsing support for grub-* scripts

2010-02-08 Thread BVK Chaitanya
I assume you are talking about /usr/bin/getopt (not libc getopt). /usr/bin/getopt comes with util-linux package (in debian), and yes, I too dont think it would be available on other platforms as bash or coreutils does. -- bvk.chaitanya ___ Grub-dev

[PATCH] Fix for eating last char in menuentry

2010-02-10 Thread BVK Chaitanya
This patch adds fix for eating-last-char error in menuentry handling in experimental branch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100210040100-y2plzp4uqald8z7t # target_branch: file:///home/bvk/Work/grub2/experimental

Re: [PATCH] Fix for eating last char in menuentry

2010-02-11 Thread BVK Chaitanya
This is committed into experimental (and also in branches/lexer-rewrite). -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

GRUB with Automake build system

2010-02-22 Thread BVK Chaitanya
Hi, Initial phase of automake based build system is ready for testing. It is now available in branches/automake branch. It currently has native build support for only i386-pc architecture. Make rules for other architectures needs to be ported from rmk files. Since it uses nested packages appr

[PATCH] Testcase for checking msdos and gpt partitions logic

2010-03-16 Thread BVK Chaitanya
directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100316170632-ezfxl7ar6a32v8g1 # target_branch: file:///home/bvk/work/grub2/mainline/ # testament_sha1: 310d6d70b5a1bbb1280b6f9a0a948fbc3fd03905 # timestamp: 2010-03-16 22:36:36 +0530 # base_revision_id: bvk.gro...@gmail.com

Re: [PATCH] Testcase for checking msdos and gpt partitions logic

2010-03-16 Thread BVK Chaitanya
This new patch has checks for sun and apple partition types. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100316210427-i99kah8gbr4l4iqn # target_branch: file:///home/bvk/work/grub2/mainline/ # testament_sha1

[PATCH] Testcase for checking lvm module

2010-03-16 Thread BVK Chaitanya
Hi, Attached patch adds a testcase to check for GRUB's lvm module functionality. It configures lvm volumes on-the-fly on temporary disk images, and tests to see whether grub-shell ls command identifies them or not. Since all of the LVM operations need root privilege, this real test is performed

Re: [PATCH] Testcase for checking lvm module

2010-03-16 Thread BVK Chaitanya
Attached! -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100317021252-1cts9bjol2lkd2a2 # target_branch: file:///home/bvk/work/grub2/mainline/ # testament_sha1: 9b533426627983a43022b8a2918a3b40f00984a0 # timestamp: 2010-03-17 07:43:03

[PATCH] A testcase for blank lines in grub script (debian bug #572302)

2010-03-22 Thread BVK Chaitanya
# target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: 92341f9daabb8d9055832f64822b614435c29f48 # timestamp: 2010-03-22 17:40:11 +0530 # base_revision_id: bvk.gro...@gmail.com-20100314170717-\ # q8ppihzgyjyifcke # # Begin patch === modified file 'conf/tests.rmk' --- conf

[BUG][PATCH] Bug fix and a test case for the last semicolon behavior in grub-script

2010-03-22 Thread BVK Chaitanya
(Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100322083320-62qfphq8t6utvlx6 # target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: b34fa1addf6d937190819406127d3e76b86623a3 # timestamp: 2010-03-22 17:44:27 +0530 # base_revision_id: bvk.gro...@gmail.com-20100314170717

New build system for GRUB

2010-03-31 Thread BVK Chaitanya
Hi, New automake based build system for GRUB is now available in branches/automake branch. Build system now has new dependency on GNU Automake and GNU Autogen. Autogen is used to convert a modules.def definitions file into an automake makefile (modules.am) which is included by Makefile.am This

[PATCH] Unit testing framework fix for Qemu 0.12

2010-04-06 Thread BVK Chaitanya
(Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100406070144-p9sqy98eqv90vo4n # target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: b99333fbdc905f06f129a2f9060cd05c97382e97 # timestamp: 2010-04-06 12:31:57 +0530 # base_revision_id: bvk.gro...@gmail.com-20100405194732

[PATCH] Fix for FreeBSD build

2010-04-06 Thread BVK Chaitanya
Hi Below patch fixes build failure on FreeBSD. FreeBSD ships with very old version of flex (in /usr/bin), which is now obsolete. This patch adds a configure time check for flex version to be >= 2.5.35. FreeBSD users can build GRUB by specifying LEX=/usr/local/bin/flex to configure command line

Re: escape strings in grub.cfg

2010-04-12 Thread BVK Chaitanya
On Mon, Apr 12, 2010 at 5:39 AM, Colin Watson wrote: > > In other words, only ' is special (as a terminator) when reading a > single-quoted string, and the sequences " $ \\ \" \n are special inside > a double-quoted string.  (Incidentally, I think there's another bug > here; if $ is special, \$ sh

Re: [PATCH] --foo bar cmdline argument parsing support for grub-* scripts

2010-04-12 Thread BVK Chaitanya
-20100412160303-6jybcf4eb75thcj3 # target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: ff33d30449069fb834a529fa1960a74052916fa3 # timestamp: 2010-04-12 21:33:14 +0530 # base_revision_id: phco...@gmail.com-20100410231431-bddwdlx8sh5oa2j2 # # Begin patch === modified file 'util

Re: escape strings in grub.cfg

2010-04-13 Thread BVK Chaitanya
On Mon, Apr 12, 2010 at 10:19 PM, BVK Chaitanya wrote: > On Mon, Apr 12, 2010 at 5:39 AM, Colin Watson wrote: >> >> In other words, only ' is special (as a terminator) when reading a >> single-quoted string, and the sequences " $ \\ \" \n are spec

Re: where i can find the GRUB design document

2010-04-17 Thread BVK Chaitanya
On Sat, Apr 17, 2010 at 3:19 PM, Bai Shuwei wrote: > >    I  want to know the GRUB architecture and the source files > relations, and want to know more information on GRUB implementation. > So does some design documents are avaliable? Thanks ALL > There is no definitive design document for GRUB.

Re: how to compile the grub legacy on AMD64

2010-04-19 Thread BVK Chaitanya
GRUB Legacy is obsolete. If you are interested in learning GRUB, I would suggest to explore GRUB-2. -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix Cygwin path handling

2010-04-19 Thread BVK Chaitanya
On Sat, Apr 17, 2010 at 9:40 PM, Christian Franke wrote: > > As far as I understand "Bazaar workflow for GRUB" > (http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00175.html) such > changes should be 'bzr push'ed to e.g. '.../branches/feature-foo' (e.g. > '.../branches/cygwin-path' in this

[PATCH] grub-emu sources re-organization

2010-04-28 Thread BVK Chaitanya
Hi, Attached patch does some source tree re-org for grub-emu build. This change is part of automake work, that is separated out for mainline branch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100427152945-bjgexrt8o76byxuf # target_br

[PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-04-28 Thread BVK Chaitanya
Hi, This patch merges grub-emu's --enable-grub-emu-modules build into normal emu build, by introducing a new tool, grub-emu-lite, which supports module loading. This patch is made on top of my earlier grub-emu sources re-org patch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.

[PATCH] Remove grub_script_cmdblock

2010-05-05 Thread BVK Chaitanya
0.90) # revision_id: bvk.gro...@gmail.com-20100504062545-fiml6jlskuyd9nbe # target_branch: file:///home/bvk/Work/grub2/mainline/ # testament_sha1: 0a426fe707fc58ac1e305121ace0001b278204fd # timestamp: 2010-05-05 14:03:57 +0530 # base_revision_id: phco...@gmail.com-20100503111712-7ilqdfmu0zesel3c # # Begin

[PATCH] Function parameters support

2010-05-05 Thread BVK Chaitanya
Hi, Attached patch adds function parameters ($1, $2, etc. and $#) support to GRUB script.. Shell expansion for "$@" and $@ specials is not yet available. PS: It needs to be applied over my earlier, remove grub_script_cmdblock patch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar

[PATCH] break command support

2010-05-05 Thread BVK Chaitanya
Hi, Attached patch adds "break [n]" command support to GRUB script. This needs to be applied on top of func-params patch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100505100426-vp7j1j0otn99h0xn # target_branch: ../func-params/ # tes

[PATCH] continue command support

2010-05-05 Thread BVK Chaitanya
Hi, Attached patch provides "continue [n]" command support for GRUB script. It needs to be applied over my earlier break command patch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100505104931-cy2j9xtwicrbbvmi # target_branch: ../brea

Re: [PATCH] break command support

2010-05-06 Thread BVK Chaitanya
is also to be consistent with bash behavior. I just missed that case; it is now fixed in people/bvk/break-cmd branch. thanks, -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Function parameters support

2010-05-06 Thread BVK Chaitanya
On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg wrote: > >  This is a *great* start, but can you please add support for $* as well as a > shift operator (though shift is not as useful when there are no looping > constructs) shift command is now available in people/bvk/shift-cmd bra

Re: [PATCH] Function parameters support

2010-05-11 Thread BVK Chaitanya
2010/5/9 Vladimir 'φ-coder/phcoder' Serbinenko : > The only place where new scope is added or removed is: > +  grub_list_push (GRUB_AS_LIST_P (&scope), GRUB_AS_LIST (&new_scope)); > + > +  ret = grub_script_execute (func->func); > + > +  grub_list_pop (GRUB_AS_LIST_P (&scope)); > + > So you can act

Re: [PATCH] Function parameters support

2010-05-11 Thread BVK Chaitanya
On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg wrote: > >  This is a *great* start, but can you please add support for $* ... > Support for $@, $* and their double quoted forms is added. Its available in people/bvk/func-params branch. One known bug is, "$@" currently ex

Re: grub2 back to lilo ?

2010-05-14 Thread BVK Chaitanya
I tend to agree. IIRC, with grub-legacy (on debian), we could simply add any user customizations at the end of the menu.lst (after auto generated list markers) which would remain there even after update-grub operations. Thus user had an easier way to add his customizations (without even need to r

Re: grub2 back to lilo ?

2010-05-15 Thread BVK Chaitanya
On Sat, May 15, 2010 at 12:41 PM, Colin Watson wrote: > On Sat, May 15, 2010 at 08:02:22AM +0530, BVK Chaitanya wrote: >> With GRUB2 that simplicity is not there anymore. > > Simplicity ... except when it broke.  Which it did, all the time.  Let's > not follow the model o

[PATCH] GRUB script shell expansion for *

2010-05-18 Thread BVK Chaitanya
Hi, Attached patch adds support for path name expansion for * in grub-script. So, we can now use *, (*,msdos*), */boot/grub/*.mod, etc. in grub scripts. It is available in people/bvk/shell-expansion branch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id

[PATCH] Shift command support to GRUB script

2010-05-18 Thread BVK Chaitanya
Hi, Attached patch adds shift cmd support to grub-script. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100512121649-kssucchekpggnms0 # target_branch: ../cmdlist/ # testament_sha1: fcbd7e7ab663a4edf0114e8dc1fbc33fb006c78e # timestamp: 2

Re: [PATCH] Function parameters support

2010-05-19 Thread BVK Chaitanya
Committed into exp. -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Option handling in grub-mkconfig

2010-05-23 Thread BVK Chaitanya
2010/5/21 Grégoire Sutre : > > The processing of option `-o' in grub-mkconfig only works when > it is the first option. > IMO this issue might have been fixed in experimental branch, by fix-cmdline-parsing (or similar) branch. I am on travel, so I cannot confirm this now :-( -- bvk.chaitanya

[PATCH] Mainline build fixes for emu platform

2010-05-25 Thread BVK Chaitanya
Hi, Attached patch fixes mainline build failures for emu platform on sparc64-linux-gnu and freebsd platforms. On freebsd GCC still reports some warnings, which can be suppressed using TARGET_CFLAGS=-Wno-error for now. I will handle them later. -- bvk.chaitanya === modified file 'conf/any-emu

Re: [PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-05-26 Thread BVK Chaitanya
Attached is the updated version with build fixes for sparc64-linux-gnu and freebsd platforms. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100526112829-yqtb9jfvlbwku9mv # target_branch: ../mainline/ # testament_sha1: 58a6119f369683840d67

Re: [PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-05-27 Thread BVK Chaitanya
Updated for cygwin build. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: chaita...@personal-lr2wsx-20100528000431-\ # qeo8qbb74n92rutd # target_branch: ../mainline/ # testament_sha1: 0d5c612d935b7c6f116130b4c15d715c0d36958c # timestamp: 2010-05-27 22:34:44 +0

Re: [Patch] File name transformations & grub-mkconfig --root-directory

2010-05-28 Thread BVK Chaitanya
A general comment, not specific your patch: IMO we should make these scripts in grub.d, standalone, i.e., instead of assuming some environment variables (like GRUB_DEVICE), they should accept values through command line arguments, like --root-device=/dev/sda or similar. Thus, final result should

Re: [PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-05-28 Thread BVK Chaitanya
Updated for netbsd build. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100528105307-z4fye52fe0j681no # target_branch: ../mainline/ # testament_sha1: bb58c232ef2971489afd458d475db4062ca985c8 # timestamp: 2010-05-28 17:14:34 +0530 # base_r

Re: [PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-06-02 Thread BVK Chaitanya
Updated patch with review comments (on IRC) is attached. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100602091507-1ue7h482akbs3w5b # target_branch: ../mainline/ # testament_sha1: b64ba6563eb16fb1ff5ae97d2102dc8f20c6b61d # timestamp: 20

Re: New build system for GRUB

2010-06-07 Thread BVK Chaitanya
It seems my mail couldn't be delivered due to patch size. Please look at branches/bvk/automake for this patch. On Tue, Jun 8, 2010 at 10:28 AM, BVK Chaitanya wrote: > Hi > > > Attached is the patch for autogen+automake based build system for > GRUB.  It is building suc

Re: [PATCH] grub-emu-lite tool instead of --enable-grub-emu-modules

2010-06-08 Thread BVK Chaitanya
2010/6/8 Vladimir 'φ-coder/phcoder' Serbinenko : > On 06/02/2010 11:29 AM, BVK Chaitanya wrote: >> Updated patch with review comments (on IRC) is attached. >> >> > go ahead >> Committed into experimental. -- bvk.chaitanya __

Re: 915resolution doesn't work with 945GME

2010-06-08 Thread BVK Chaitanya
Where is this 915resolution.c file located exactly? I can't seem to find it in mainline :-( -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Multiline double and single quote strings in GRUB script

2010-06-12 Thread BVK Chaitanya
Hi, Attached patch adds support for logical linebreaks (ie, backslash followed by newline) and multi-line double quoted and single quoted strings in GRUB script. Its also available in people/bvk/nl-fix branch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id

[PATCH] Add /boot/grub/custom.cfg file support

2010-06-12 Thread BVK Chaitanya
Hi Attached patch adds support for /boot/grub/custom.cfg (or /grub/custom.cfg) file for user customizations. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100612092745-d9vnimifh4l8iny4 # target_branch: ../mainline/ # testament_sha1: 622d

  1   2   >