Re: [PATCH] arm64/xen: Consider alignment calling grub_arch_efi_linux_boot_image

2025-07-07 Thread Frediano Ziglio via Grub-devel
On Fri, Jul 4, 2025 at 4:20 PM Sudhakar Kuppusamy wrote: > > > > > On 4 Jul 2025, at 7:36 PM, Frediano Ziglio via Grub-devel > > wrote: > > > > The Xen image is loaded alignment, not always at "start". > > > > Signed-off-by: Frediano Ziglio > > --- > > grub-core/loader/arm64/xen_boot.c | 10 +++

[PATCH v2] arm64/xen: Consider alignment calling grub_arch_efi_linux_boot_image

2025-07-07 Thread Frediano Ziglio via Grub-devel
The Xen image is loaded alignment, not always at "start". Signed-off-by: Frediano Ziglio --- Changes since v1: - indentation changes --- grub-core/loader/arm64/xen_boot.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/lo

Re: [PATCH v3 00/25] Appended Signature Secure Boot Support for PowerPC

2025-07-07 Thread Daniel Kiper
On Tue, Jun 10, 2025 at 09:20:34PM +0530, Sudhakar wrote: > This patch set contains v3 of the consolidated version of the patch > sets for secure boot using appended signatures on powerpc, > rebased on top of git HEAD. Your patch set breaks at least this target/platform pair build: ./configure

[PATCH v5] Define a Containerfile and instructions to build distro images

2025-07-07 Thread Leo Sandoval via Grub-devel
Containers bring the ability to have ready-to-use environments isolated completely from the build environment. Once users manually build it, they can launch the desired container, jump into it and have a setup ready for development. On the other hand, if users prefer to use bare metal instead of a

[PATCH v14 10/15] libgcrypt: Import blake family of hashes

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/06_blake.patch | 80 +++ include/grub/crypto.h | 9 +++ util/import_gcry.py | 36 +++-- 3 files changed, 118 insertions(+), 7 deletions(-) create mode 1006

[PATCH v14 11/15] import_gcry: Make compatible with python 3.4

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- util/import_gcry.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/util/import_gcry.py b/util/import_gcry.py index ca918c777..9b0e8d936 100644 --- a/util/import_gcry.py +++ b/util/import_gcry.py @@ -249,15 +249,15 @@ for ciphe

[PATCH v14 08/15] Remove now unneeded gcrypt compilation flag

2025-07-07 Thread Vladimir Serbinenko
HAVE_STRTOUL is now defined in stdlib.h. Include it in g10lib.h rather than defining on command line Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common | 2 +- util/import_gcry.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.

[PATCH v4] Define a Containerfile and instructions to build distro images

2025-07-07 Thread Leo Sandoval via Grub-devel
Containers bring the ability to have ready-to-use environments isolated completely from the build environment. Once users manually build it, they can launch the desired container, jump into it and have a setup ready for development. On the other hand, if users prefer to use bare metal instead of a

[PATCH v14 04/15] Adjust import script, definitions and API users for libgcrypt 1.11

2025-07-07 Thread Vladimir Serbinenko
This patches modifies the GRUB-libgcrypt API to match new libgcrypt 1.11 Signed-off-by: Vladimir Serbinenko --- autogen.sh| 5 + conf/Makefile.common | 4 +- grub-core/Makefile.core.def | 20 +- grub-core/command

[PATCH v14 14/15] libgcrypt: Fix a memory leak

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/08_sexp_leak.patch | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/08_sexp_leak.patch diff --git a/grub-core/lib/libgcrypt-patches/08_sexp_leak.patch b/grub-core/lib/

[PATCH v14 03/15] b64dec: Add harness for compilation in GRUB environment

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- grub-core/lib/gpgrt-int.h | 24 1 file changed, 24 insertions(+) create mode 100644 grub-core/lib/gpgrt-int.h diff --git a/grub-core/lib/gpgrt-int.h b/grub-core/lib/gpgrt-int.h new file mode 100644 index 0..45d63580b --- /d

[PATCH v14 13/15] libgcrypt: Don't use 64-bit division on platforms where it's slow

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/07_disable_64div.patch | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/07_disable_64div.patch diff --git a/grub-core/lib/libgcrypt-patches/07_disable_64div.patch b/grub-c

[PATCH v14 02/15] Import b64dec from gpg-error

2025-07-07 Thread Vladimir Serbinenko
Imported from libgpg-error 1.51 Signed-off-by: Vladimir Serbinenko --- grub-core/lib/b64dec.c | 279 + 1 file changed, 279 insertions(+) create mode 100644 grub-core/lib/b64dec.c diff --git a/grub-core/lib/b64dec.c b/grub-core/lib/b64dec.c new file mode

[PATCH v14 12/15] import_gcry: Fix pylint warnings

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- util/import_gcry.py | 1276 +-- 1 file changed, 622 insertions(+), 654 deletions(-) diff --git a/util/import_gcry.py b/util/import_gcry.py index 9b0e8d936..086bde77c 100644 --- a/util/import_gcry.py +++ b/util/import_

[PATCH v14 05/15] Add DSA and RSA SEXP tests

2025-07-07 Thread Vladimir Serbinenko
This allows us to test purely the integration of the implementation of DSA and RSA from libgcrypt without concerning with additional code. Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 16 grub-core/tests/dsa_sexp_test.c | 127 gr

[PATCH v14 09/15] gcry: Ignore sign-compare warnings

2025-07-07 Thread Vladimir Serbinenko
libgcrypt itself is compiled with -Wno-sign-compare. Do the same for consistency Signed-off-by: Vladimir Serbinenko --- conf/Makefile.common| 2 +- grub-core/Makefile.core.def | 10 +- util/import_gcry.py | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --

[PATCH v14 15/15] Write how to import new libgcrypt

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- docs/grub-dev.texi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi index f4367f895..62ad43c9d 100644 --- a/docs/grub-dev.texi +++ b/docs/grub-dev.texi @@ -507,6 +507,7 @@ to

[PATCH v14 00/15] Import libgcrypt 1.11

2025-07-07 Thread Vladimir Serbinenko
Changes from previous version: 1) Fixed coverity scan 2) Added documentation ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v14 07/15] libgcrypt: Fix coverity warnings

2025-07-07 Thread Vladimir Serbinenko
Signed-off-by: Vladimir Serbinenko --- .../libgcrypt-patches/03_mpiutil_alloc.patch | 20 ++ .../lib/libgcrypt-patches/03_sexp_free.patch | 37 +++ 2 files changed, 57 insertions(+) create mode 100644 grub-core/lib/libgcrypt-patches/03_mpiutil_alloc.patch create mode 1

[PATCH v14 06/15] keccak: Disable acceleration with SSE asm

2025-07-07 Thread Vladimir Serbinenko
Libgcrypt code assumes that on x64 all SSE registers are fair game. While it's true that CPUs in question support it, we disable it in our compilation options. Disable the offending optimization. Signed-off-by: Vladimir Serbinenko --- .../lib/libgcrypt-patches/02_keccak_sse.patch | 25 ++