On Fri, Jul 4, 2025 at 4:20 PM Sudhakar Kuppusamy
<sudha...@linux.ibm.com> wrote:
>
>
>
> > On 4 Jul 2025, at 7:36 PM, Frediano Ziglio via Grub-devel
> > <grub-devel@gnu.org> wrote:
> >
> > The Xen image is loaded alignment, not always at "start".
> >
> > Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
> > ---
> > grub-core/loader/arm64/xen_boot.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/grub-core/loader/arm64/xen_boot.c
> > b/grub-core/loader/arm64/xen_boot.c
> > index 8db1d9db0..26ffd9794 100644
> > --- a/grub-core/loader/arm64/xen_boot.c
> > +++ b/grub-core/loader/arm64/xen_boot.c
> > @@ -247,13 +247,17 @@ fail:
> > static grub_err_t
> > xen_boot (void)
> > {
> > + grub_addr_t start;
> > +
> > grub_err_t err = finalize_params_xen_boot ();
> > if (err)
> > return err;
> >
> > - return grub_arch_efi_linux_boot_image (xen_hypervisor->start,
> > - xen_hypervisor->size,
> > - xen_hypervisor->cmdline);
> > + start = xen_boot_address_align (xen_hypervisor->start,
> > + xen_hypervisor->align);
>
> it would be better like below
>
> start = xen_boot_address_align (xen_hypervisor->start, xen_hypervisor->align);
>
I can do it, it looks like the line is exactly 80 characters.
>
> > + return grub_arch_efi_linux_boot_image (start,
> > + xen_hypervisor->size,
> > + xen_hypervisor->cmdline);
>
>
> Something is off with indention here
>
I'm not really familiar with GNU style however I think it's correct.
The code should be indented with 8 space tabs. The "xen_hypervisor..."
lines are exactly under "start,".
> Thanks,
> Sudhakar
> > }
> >
> > static void
Frediano
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
