Re: [PATCH v19 33/33] docs: Document TPM2 key protector

2024-10-03 Thread Gary Lin via Grub-devel
On Fri, Sep 20, 2024 at 09:42:01AM -0400, Stefan Berger wrote: > Sorry for my late reply. Just back from vacation. > > On 9/20/24 4:16 AM, Gary Lin wrote: > > On Fri, Sep 13, 2024 at 10:25:14AM -0400, Stefan Berger wrote: > > > > > > > > > > > +SHA1, SHA256, SHA384, and SHA512, and the defaul

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-10-03 Thread Gary Lin via Grub-devel
On Thu, Oct 03, 2024 at 05:58:41PM +0200, Daniel Kiper wrote: > On Fri, Sep 06, 2024 at 05:10:52PM +0800, Gary Lin via Grub-devel wrote: > > GIT repo for v19: https://github.com/lcp/grub2/tree/tpm2-unlock-v19 > > > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > > Hernan

Re: [PATCH v19 21/33] tss2: Add TPM2 Software Stack (TSS2) support

2024-10-03 Thread Gary Lin via Grub-devel
On Tue, Oct 01, 2024 at 04:48:34PM +0200, Daniel Kiper wrote: > On Wed, Sep 18, 2024 at 03:28:44PM +0800, Gary Lin via Grub-devel wrote: > > On Tue, Sep 17, 2024 at 11:14:33PM -0400, Stefan Berger wrote: > > > On 9/6/24 5:11 AM, Gary Lin wrote: > > > > A Trusted Platform Module (TPM) Software Stack

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Michael Chang via Grub-devel
On Thu, Oct 03, 2024 at 09:17:46PM GMT, Askar Safin wrote: > On Thu, 03 Oct 2024 11:23:08 +0400 Michael Chang via Grub-devel wrote > --- > > A regression in grub 2.12 causes the grub screen to become cluttered > > I just tested. Your patch doesn't fix anything for me! Thank you for sha

Re: [PATCH] lvm: allocate metadata buffer from raw contents

2024-10-03 Thread Michael Chang via Grub-devel
On Thu, Oct 03, 2024 at 10:30:15AM GMT, ross.philip...@oracle.com wrote: > On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: > > Previously, the buffer for LVM metadata parsing was set to twice the > > size of the metadata area, which caused excessive memory use. > > > > This patch changes

[PATCH] lvm: allocate metadata buffer from raw contents

2024-10-03 Thread Michael Chang via Grub-devel
Previously, the buffer for LVM metadata parsing was set to twice the size of the metadata area, which caused excessive memory use. This patch changes the allocation to read the actual raw metadata blocks directly from the metadata area. Instead of using twice the entire metadata area size, we now

[PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Michael Chang via Grub-devel
A regression in grub 2.12 causes the grub screen to become cluttered with artifacts from the previous screen, whether it's the UEFI post ui, UEFI shell, or any graphical UI running before grub. this issue occurs in situations like booting grub from the UEFI shell and going straight to the rescue or

[PATCH] tpm: Skip loopback image measurement

2024-10-03 Thread Michael Chang via Grub-devel
The loopback image is configured to function as a disk by being mapped as a block device. Instead of measuring the entire block device, we should focus on tracking the individual files accessed from it. For example, we do not directly measure block devices like disk hd0, but the files opened from i

Re: [PATCH v3 1/8] i386/msr: Merge rdmsr.h and wrmsr.h into msr.h

2024-10-03 Thread Daniel Kiper via Grub-devel
On Sun, Sep 22, 2024 at 08:17:47PM +0300, Sergii Dmytruk wrote: > From: Daniel Kiper > > It does not make sense to have separate headers for individual static > functions. Additionally, we have to add some constants with MSR > addresses in subsequent patches. So, make one common place to store Th

Re: [PATCH v3 2/8] i386/msr: Rename grub_msr_read() and grub_msr_write()

2024-10-03 Thread Daniel Kiper via Grub-devel
On Sun, Sep 22, 2024 at 08:17:48PM +0300, Sergii Dmytruk wrote: > From: Daniel Kiper > > Use more obvious names which match corresponding instructions: > * grub_msr_read() => grub_rdmsr() > * grub_msr_write() => grub_wrmsr() > > Signed-off-by: Daniel Kiper > Signed-off-by: Sergii Dmytruk > Re

Re: [PATCH v2 0/2] Delete Net Routes for Deleted Interfaces

2024-10-03 Thread Andrew Hamilton
Any feedback on this? I can regenerate and resend the patch if there are any conflicts with other updates. Thanks, Andrew On Sat, Aug 31, 2024 at 10:31 PM Andrew Hamilton wrote: > Correct incorrect handling of routes being maintained when an > associated interface is deleted. Previously the rou

Re: [PATCH 0/1] docs: Small Fixes for Network, Secure Boot, PXE

2024-10-03 Thread Andrew Hamilton
Any feedback on this? If needed and can make a new version against current main branch. Thanks, Andrew On Sun, Aug 18, 2024 at 11:21 AM Andrew Hamilton wrote: > Currently the GRUB Manual has a few small issues captured in bug > reports (54480, 62004, and 65152). These are related to issues in >

Re: [PATCH v3 3/8] i386/msr: Extract and improve MSR support detection code

2024-10-03 Thread Daniel Kiper via Grub-devel
On Sun, Sep 22, 2024 at 08:17:49PM +0300, Sergii Dmytruk wrote: > From: Daniel Kiper > > Currently rdmsr and wrmsr commands have own MSR support detection code. > This code is the same. So, it is duplicated. Additionally, this code > cannot be reused by others. Hence, extract this code to a functi

Re: [PATCH v3 4/8] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

2024-10-03 Thread Daniel Kiper via Grub-devel
On Mon, Sep 23, 2024 at 09:56:22AM -0700, ross.philipson via trenchboot-devel wrote: > On 9/22/24 10:17 AM, Sergii Dmytruk wrote: > > From: Daniel Kiper > > > > This fixes naming inconsistency that goes against coding style as well > > as helps to avoid potential conflicts and confusion. > > > >

Re: [PATCH v3 5/8] i386/memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

2024-10-03 Thread Daniel Kiper via Grub-devel
On Mon, Sep 23, 2024 at 10:04:04AM -0700, ross.philipson via trenchboot-devel wrote: > On 9/22/24 10:17 AM, Sergii Dmytruk wrote: > > From: Daniel Kiper > > > > Subsequent patches will use that constant. This sentence is not true due to lack of DRTM patches. I think we should replace it with som

Re: [PATCH v3 7/8] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

2024-10-03 Thread Daniel Kiper via Grub-devel
On Sun, Sep 22, 2024 at 08:17:53PM +0300, Sergii Dmytruk wrote: > From: Daniel Kiper > > The functions find the lowest and highest values with regard to the > passed in limit. Passing a low limit of 0 or a high limit of ~0 > calculates lowest and highest available RAM addresses respectively. > >

Re: [PATCH] tpm: Skip loopback image measurement

2024-10-03 Thread Daniel Kiper
On Thu, Oct 03, 2024 at 03:23:22PM +0800, Michael Chang via Grub-devel wrote: > The loopback image is configured to function as a disk by being mapped > as a block device. Instead of measuring the entire block device, we > should focus on tracking the individual files accessed from it. For > exampl

Re: [PATCH] efinet: Skip virtual VLAN devices during card enumeration

2024-10-03 Thread Daniel Kiper
On Thu, Oct 03, 2024 at 03:23:15PM +0800, Michael Chang via Grub-devel wrote: > Similar to the fix in commit "c52ae4057 efinet: skip virtual IPv4 and > IPv6 devices during card enumeration", the UEFI PXE driver creates > additional VLAN child devices when a VLAN ID is configured on a network > inte

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Daniel Kiper
On Thu, Oct 03, 2024 at 03:23:08PM +0800, Michael Chang via Grub-devel wrote: > A regression in grub 2.12 causes the grub screen to become cluttered > with artifacts from the previous screen, whether it's the UEFI post ui, > UEFI shell, or any graphical UI running before grub. this issue occurs > i

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-10-03 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:10:52PM +0800, Gary Lin via Grub-devel wrote: > GIT repo for v19: https://github.com/lcp/grub2/tree/tpm2-unlock-v19 > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > Hernan Gatta to introduce the key protector framework and TPM2 stack > to GRUB

Re: [PATCH v19 04/33] libtasn1: replace strcat() with strcpy() in _asn1_str_cat()

2024-10-03 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:10:56PM +0800, Gary Lin via Grub-devel wrote: > strcat() is not available in GRUB. This commit replaces strcat() with > strcpy() in _asn1_str_cat() as the preparation to replace other strcat() > with the bounds-checking _asn1_str_cat(). > > Signed-off-by: Daniel Axtens >

Re: [PATCH v19 05/33] libtasn1: replace strcat() with _asn1_str_cat()

2024-10-03 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:10:57PM +0800, Gary Lin via Grub-devel wrote: > strcat() is not available in GRUB. This commit replaces strcat() and > _asn1_strcat() with the bounds-checking _asn1_str_cat(). > > Signed-off-by: Daniel Axtens > Signed-off-by: Gary Lin Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v19 06/33] libtasn1: adjust the header paths in libtasn1.h

2024-10-03 Thread Daniel Kiper
On Fri, Sep 06, 2024 at 05:10:58PM +0800, Gary Lin via Grub-devel wrote: > Since libtasn1.h is the header to be included by users, including the > standard POSIX headers in libtasn1.h would force the user to add the > CFLAGS/CPPFLAGS for the POSIX headers. > > This commit adjusts the header paths t

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Askar Safin via Grub-devel
On Thu, 03 Oct 2024 11:23:08 +0400 Michael Chang via Grub-devel wrote --- > A regression in grub 2.12 causes the grub screen to become cluttered I just tested. Your patch doesn't fix anything for me! (Note: I'm not GRUB developer, I'm just a user.) Hi. I'm annoyed by screen cluttering

Re: [PATCH] lvm: allocate metadata buffer from raw contents

2024-10-03 Thread Ross Philipson via Grub-devel
On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: Previously, the buffer for LVM metadata parsing was set to twice the size of the metadata area, which caused excessive memory use. This patch changes the allocation to read the actual raw metadata blocks directly from the metadata area. In

[PATCH] efinet: Skip virtual VLAN devices during card enumeration

2024-10-03 Thread Michael Chang via Grub-devel
Similar to the fix in commit "c52ae4057 efinet: skip virtual IPv4 and IPv6 devices during card enumeration", the UEFI PXE driver creates additional VLAN child devices when a VLAN ID is configured on a network interface associated with a physical NIC. These virtual VLAN devices must be skipped durin