On Fri, Sep 06, 2024 at 05:10:52PM +0800, Gary Lin via Grub-devel wrote:
> GIT repo for v19: https://github.com/lcp/grub2/tree/tpm2-unlock-v19
>
> This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by
> Hernan Gatta to introduce the key protector framework and TPM2 stack
> to GRUB2, and this could be a useful feature for the systems to
> implement full disk encryption.
>
> To support TPM 2.0 Key File format(*2), patch 1~7,9-16 are grabbed from
> Daniel Axtens's "appended signature secure boot support" (*3) to import
> libtasn1 into grub2. Besides, the libtasn1 version is upgraded to
> 4.19.0 instead of 4.16.0 in the original patch.
I tried to build this patch set and got this errors:
./configure --target=i386 --with-platform=pc ...
make
...
tests/asn1/tests/Test_overflow.c: In function ‘test_overflow’:
tests/asn1/tests/Test_overflow.c:48:50: error: left shift of negative value
[-Werror=shift-negative-value]
unsigned long num = ((long) GRUB_UINT_MAX) << 2;
^~
cc1: all warnings being treated as errors
May I ask you to test 32-bit builds, e.g. as above, before posting next
versions of patches?
I will send more comments in the following days. I will drop you a line
when you can repost the patch set.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
