Re: [PATCH v6 10/10] efi: Disallow fallback to legacy Linux loader when shim says NX is required.

2024-09-23 Thread Frediano Ziglio via Grub-devel
On Thu, Sep 19, 2024 at 5:33 PM Mate Kukri wrote: > > Signed-off-by: Mate Kukri > --- > grub-core/kern/efi/sb.c | 28 > grub-core/loader/efi/linux.c | 12 +++- > include/grub/efi/api.h | 2 ++ > include/grub/efi/sb.h| 2 ++ > 4 files chan

Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

2024-09-23 Thread Thomas Schmitt via Grub-devel
Hi, The patches apply without complaints by "git am". But when i run (again as superuser, shudder): make check TESTS=grub_cmd_cryptomount i still get in /tmp the empty direcories /tmp/17*.LUKS2_*. Minor nitpick: > [PATCH 2/4] tests: Cleaup the cryptsetup script in grub_cmd_cryptomount > un

Re: [PATCH v3 4/8] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

2024-09-23 Thread Ross Philipson via Grub-devel
On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Daniel Kiper This fixes naming inconsistency that goes against coding style as well as helps to avoid potential conflicts and confusion. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core

Re: [PATCH v3 5/8] i386/memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

2024-09-23 Thread Ross Philipson via Grub-devel
On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Daniel Kiper Subsequent patches will use that constant. Signed-off-by: Daniel Kiper Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- grub-core/loader/i386/xen.c | 35 +-- include/grub/i386/m

Re: [PATCH v3 6/8] i386/memory: Define GRUB_PAGE_MASK and GRUB_PAGE_{UP,DOWN} macros

2024-09-23 Thread Ross Philipson via Grub-devel
On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Krystian Hebel GRUB_PAGE_MASK is intentionally signed to make use of sign extension. Subsequent patches will use them. Signed-off-by: Krystian Hebel Signed-off-by: Sergii Dmytruk Reviewed-by: Ross Philipson --- include/grub/i386/memory

Re: [PATCH v3 7/8] mmap: Add grub_mmap_get_lowest() and grub_mmap_get_highest()

2024-09-23 Thread Ross Philipson via Grub-devel
On 9/22/24 10:17 AM, Sergii Dmytruk wrote: From: Daniel Kiper The functions find the lowest and highest values with regard to the passed in limit. Passing a low limit of 0 or a high limit of ~0 calculates lowest and highest available RAM addresses respectively. Signed-off-by: Daniel Kiper Si

Re: [PATCH 1/4] tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup

2024-09-23 Thread Thomas Schmitt via Grub-devel
Hi, (adding Vladimir Serbinenko to Cc) Glenn Washburn wrote: > --- a/tests/util/grub-shell-luks-tester.in > +++ b/tests/util/grub-shell-luks-tester.in > @@ -143,6 +143,7 @@ fi > > # Make sure that the dm-crypto device is shutdown > cleanup() { > +RET=$? > if [ -e "$luksdev" ]; then >