memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

Ross Philipson via Grub-devel Mon, 23 Sep 2024 10:05:06 -0700

On 9/22/24 10:17 AM, Sergii Dmytruk wrote:

From: Daniel Kiper <daniel.ki...@oracle.com>


Subsequent patches will use that constant.

Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com>
Signed-off-by: Sergii Dmytruk <sergii.dmyt...@3mdeb.com>


Reviewed-by: Ross Philipson <ross.philip...@oracle.com>

---
  grub-core/loader/i386/xen.c | 35 +++++++++++++++++------------------
  include/grub/i386/memory.h  |  1 +
  2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c
index 520367732..dcdf005df 100644
--- a/grub-core/loader/i386/xen.c
+++ b/grub-core/loader/i386/xen.c
@@ -92,8 +92,7 @@ static struct xen_loader_state xen_state;

static grub_dl_t my_mod;-#define PAGE_SIZE (1UL << GRUB_PAGE_SHIFT)

-#define MAX_MODULES (PAGE_SIZE / sizeof (struct xen_multiboot_mod_list))
+#define MAX_MODULES (GRUB_PAGE_SIZE / sizeof (struct xen_multiboot_mod_list))
  #define STACK_SIZE 1048576
  #define ADDITIONAL_SIZE (1 << 19)
  #define ALIGN_SIZE (1 << 22)
@@ -229,7 +228,7 @@ generate_page_table (grub_xen_mfn_t *mfn_list)

for (m1 = 0; m1 < xen_state.n_mappings; m1++)

      grub_memset (xen_state.mappings[m1].where, 0,
-                xen_state.mappings[m1].area.n_pt_pages * PAGE_SIZE);
+                xen_state.mappings[m1].area.n_pt_pages * GRUB_PAGE_SIZE);

for (l = NUMBER_OF_LEVELS - 1; l >= 0; l--)

      {
@@ -324,7 +323,7 @@ grub_xen_p2m_alloc (void)

map = xen_state.mappings + xen_state.n_mappings;

    p2msize = ALIGN_UP (sizeof (grub_xen_mfn_t) *
-                     grub_xen_start_page_addr->nr_pages, PAGE_SIZE);
+                     grub_xen_start_page_addr->nr_pages, GRUB_PAGE_SIZE);
    if (xen_state.xen_inf.has_p2m_base)
      {
        err = get_pgtable_size (xen_state.xen_inf.p2m_base,
@@ -380,9 +379,9 @@ grub_xen_special_alloc (void)
    xen_state.state.start_info = xen_state.max_addr + 
xen_state.xen_inf.virt_base;
    xen_state.virt_start_info = get_virtual_current_address (ch);
    xen_state.max_addr =
-    ALIGN_UP (xen_state.max_addr + sizeof (xen_state.next_start), PAGE_SIZE);
+    ALIGN_UP (xen_state.max_addr + sizeof (xen_state.next_start), 
GRUB_PAGE_SIZE);
    xen_state.console_pfn = xen_state.max_addr >> GRUB_PAGE_SHIFT;
-  xen_state.max_addr += 2 * PAGE_SIZE;
+  xen_state.max_addr += 2 * GRUB_PAGE_SIZE;

xen_state.next_start.nr_pages = grub_xen_start_page_addr->nr_pages;

    grub_memcpy (xen_state.next_start.magic, grub_xen_start_page_addr->magic,
@@ -431,9 +430,9 @@ grub_xen_pt_alloc (void)
        /* Map the relocator page either at virtual 0 or after end of area. */
        nr_need_pages = nr_info_pages + map->area.n_pt_pages;
        if (xen_state.xen_inf.virt_base)
-       err = get_pgtable_size (0, PAGE_SIZE, nr_need_pages);
+       err = get_pgtable_size (0, GRUB_PAGE_SIZE, nr_need_pages);
        else
-       err = get_pgtable_size (try_virt_end, try_virt_end + PAGE_SIZE,
+       err = get_pgtable_size (try_virt_end, try_virt_end + GRUB_PAGE_SIZE,
                                nr_need_pages);
        if (err)
        return err;
@@ -538,7 +537,7 @@ grub_xen_boot (void)

return grub_relocator_xen_boot (xen_state.relocator, xen_state.state, nr_pages,

                                  xen_state.xen_inf.virt_base <
-                                 PAGE_SIZE ? page2offset (nr_pages) : 0,
+                                 GRUB_PAGE_SIZE ? page2offset (nr_pages) : 0,
                                  xen_state.pgtbl_end - 1,
                                  page2offset (xen_state.pgtbl_end - 1) +
                                  xen_state.xen_inf.virt_base);
@@ -677,7 +676,7 @@ grub_cmd_xen (grub_command_t cmd __attribute__ ((unused)),
        goto fail;
      }

- if (xen_state.xen_inf.virt_base & (PAGE_SIZE - 1))

+  if (xen_state.xen_inf.virt_base & (GRUB_PAGE_SIZE - 1))
      {
        grub_error (GRUB_ERR_BAD_OS, "unaligned virt_base");
        goto fail;
@@ -700,10 +699,10 @@ grub_cmd_xen (grub_command_t cmd __attribute__ ((unused)),
        kern_start = grub_min (kern_start, xen_state.xen_inf.hypercall_page -
                                         xen_state.xen_inf.virt_base);
        kern_end = grub_max (kern_end, xen_state.xen_inf.hypercall_page -
-                                    xen_state.xen_inf.virt_base + PAGE_SIZE);
+                                    xen_state.xen_inf.virt_base + 
GRUB_PAGE_SIZE);
      }

- xen_state.max_addr = ALIGN_UP (kern_end, PAGE_SIZE);

+  xen_state.max_addr = ALIGN_UP (kern_end, GRUB_PAGE_SIZE);

if (grub_sub (kern_end, kern_start, &sz))

@@ -730,7 +729,7 @@ grub_cmd_xen (grub_command_t cmd __attribute__ ((unused)),
    if (xen_state.xen_inf.has_hypercall_page)
      {
        unsigned i;
-      for (i = 0; i < PAGE_SIZE / HYPERCALL_INTERFACE_SIZE; i++)
+      for (i = 0; i < GRUB_PAGE_SIZE / HYPERCALL_INTERFACE_SIZE; i++)
        set_hypercall_interface ((grub_uint8_t *) kern_chunk_src +
                                 i * HYPERCALL_INTERFACE_SIZE +
                                 xen_state.xen_inf.hypercall_page -
@@ -828,7 +827,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ 
((unused)),
                (unsigned) (xen_state.max_addr + xen_state.xen_inf.virt_base),
                (unsigned) size);

- xen_state.max_addr = ALIGN_UP (xen_state.max_addr + size, PAGE_SIZE);

+  xen_state.max_addr = ALIGN_UP (xen_state.max_addr + size, GRUB_PAGE_SIZE);

fail:

    grub_initrd_close (&initrd_ctx);
@@ -882,7 +881,7 @@ grub_cmd_module (grub_command_t cmd __attribute__ 
((unused)),
      {
        xen_state.xen_inf.unmapped_initrd = 0;
        xen_state.n_modules = 0;
-      xen_state.max_addr = ALIGN_UP (xen_state.max_addr, PAGE_SIZE);
+      xen_state.max_addr = ALIGN_UP (xen_state.max_addr, GRUB_PAGE_SIZE);
        xen_state.modules_target_start = xen_state.max_addr;
        xen_state.next_start.mod_start =
        xen_state.max_addr + xen_state.xen_inf.virt_base;
@@ -902,7 +901,7 @@ grub_cmd_module (grub_command_t cmd __attribute__ 
((unused)),
        MAX_MODULES * sizeof (xen_state.module_info_page[0]);
      }

- xen_state.max_addr = ALIGN_UP (xen_state.max_addr, PAGE_SIZE);

+  xen_state.max_addr = ALIGN_UP (xen_state.max_addr, GRUB_PAGE_SIZE);

file = grub_file_open (argv[0], GRUB_FILE_TYPE_LINUX_INITRD |

                         (nounzip ? GRUB_FILE_TYPE_NO_DECOMPRESS : 
GRUB_FILE_TYPE_NONE));
@@ -925,7 +924,7 @@ grub_cmd_module (grub_command_t cmd __attribute__ 
((unused)),

xen_state.module_info_page[xen_state.n_modules].cmdline =

      xen_state.max_addr - xen_state.modules_target_start;
-  xen_state.max_addr = ALIGN_UP (xen_state.max_addr + cmdline_len, PAGE_SIZE);
+  xen_state.max_addr = ALIGN_UP (xen_state.max_addr + cmdline_len, 
GRUB_PAGE_SIZE);

if (size)

      {
@@ -952,7 +951,7 @@ grub_cmd_module (grub_command_t cmd __attribute__ 
((unused)),
    xen_state.n_modules++;
    grub_dprintf ("xen", "module, addr=0x%x, size=0x%x\n",
                (unsigned) xen_state.max_addr, (unsigned) size);
-  xen_state.max_addr = ALIGN_UP (xen_state.max_addr + size, PAGE_SIZE);
+  xen_state.max_addr = ALIGN_UP (xen_state.max_addr + size, GRUB_PAGE_SIZE);

fail:

diff --git a/include/grub/i386/memory.h b/include/grub/i386/memory.h
index 7be57d6d7..c64529630 100644
--- a/include/grub/i386/memory.h
+++ b/include/grub/i386/memory.h
@@ -21,6 +21,7 @@
  #define GRUB_MEMORY_CPU_HEADER        1

#define GRUB_PAGE_SHIFT 12

+#define GRUB_PAGE_SIZE         (1UL << GRUB_PAGE_SHIFT)

/* The flag for protected mode. */

  #define GRUB_MEMORY_CPU_CR0_PE_ON             0x1



_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 5/8] i386/memory: Rename PAGE_SIZE to GRUB_PAGE_SIZE and make it global

Reply via email to