Re: [PATCH v18 04/25] libtasn1: use bound-checked _asn1_str_cat()

2024-08-16 Thread Daniel Kiper
On Thu, Aug 15, 2024 at 02:18:17PM +0800, Gary Lin wrote: > On Wed, Aug 14, 2024 at 05:40:08PM +0200, Daniel Kiper wrote: > > On Fri, Jun 28, 2024 at 04:18:47PM +0800, Gary Lin via Grub-devel wrote: > > > Remove _asn1_strcat() and replace strcat() with the bound-checked > > > _asn1_str_cat() except

Re: [PATCH v18 05/25] libtasn1: adjust the header paths in libtasn1.h

2024-08-16 Thread Daniel Kiper
On Thu, Aug 15, 2024 at 02:24:18PM +0800, Gary Lin wrote: > On Wed, Aug 14, 2024 at 05:41:35PM +0200, Daniel Kiper wrote: > > On Fri, Jun 28, 2024 at 04:18:48PM +0800, Gary Lin via Grub-devel wrote: > > > Use the grub headers instead of the standard POSIX headers. > > > > Again, why? > > > "libtasn

Re: [PATCH v18 08/25] asn1_test: changes for grub compatibility

2024-08-16 Thread Daniel Kiper
On Thu, Aug 15, 2024 at 02:49:34PM +0800, Gary Lin wrote: > On Wed, Aug 14, 2024 at 05:52:14PM +0200, Daniel Kiper wrote: > > On Fri, Jun 28, 2024 at 04:18:51PM +0800, Gary Lin via Grub-devel wrote: > > > Do a few things to make asn1 tests compile as part of grub: > > > > > > - include asn1_test.h

Re: [PATCH v18 00/25] Automatic Disk Unlock with TPM2

2024-08-16 Thread Daniel Kiper
On Fri, Aug 16, 2024 at 01:34:18PM +0800, Gary Lin wrote: > On Wed, Aug 14, 2024 at 05:34:52PM +0200, Daniel Kiper wrote: > > On Fri, Jun 28, 2024 at 04:18:43PM +0800, Gary Lin via Grub-devel wrote: > > > GIT repo for v18: https://github.com/lcp/grub2/tree/tpm2-unlock-v18 > > > > > > This patch ser

Re: [PATCH v18 10/25] asn1_test: test module for libtasn1

2024-08-16 Thread Daniel Kiper
On Fri, Jun 28, 2024 at 04:18:53PM +0800, Gary Lin via Grub-devel wrote: > From: Daniel Axtens > > Import tests from libtasn1 that don't use functionality we don't > import. This test module is integrated into functional_test so that the Would not be it easier if you say: Import tests from libtas

Re: [PATCH v18 11/25] libtasn1: Add the documentation

2024-08-16 Thread Daniel Kiper
On Fri, Jun 28, 2024 at 04:18:54PM +0800, Gary Lin via Grub-devel wrote: > Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. > Also add the patches to make libtasn1 compatible with grub code. > > Signed-off-by: Gary Lin > Reviewed-by: Vladimir Serbinenko Reviewed-by: Daniel Kipe