On Thu, Aug 15, 2024 at 02:18:17PM +0800, Gary Lin wrote: > On Wed, Aug 14, 2024 at 05:40:08PM +0200, Daniel Kiper wrote: > > On Fri, Jun 28, 2024 at 04:18:47PM +0800, Gary Lin via Grub-devel wrote: > > > Remove _asn1_strcat() and replace strcat() with the bound-checked > > > _asn1_str_cat() except the one inside _asn1_str_cat(). That strcat > > > > s/strcat/strcat()/ > > > > > is replaced with strcpy. > > > > s/strcpy/strcpy()/ > > > Will fix them in the next version. > > > This commit message and one below miss explanation why these changes are > > needed. > Ok, I'll add more details about the change. > > > And I think this patch should be split into two... > The changes are all about the same thing: replacing strcat() with a > bound-checked function. What kind of splitting woud you suggest?
The strcat() and strcpy() are two distinct changes. So, both begs for separate patches. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
