Re: grub keyfile read errors support

2024-02-29 Thread Daniel Kiper
On Tue, Feb 27, 2024 at 06:57:17AM +0300, Alexey Kuznetsov wrote: > > > If so. Then why does your allow users to remove a removable key? > > > > I don't understand this, can you rephrase the question? > > I have two separate drives: a boot device and a usb flash drive with a key. If > I have a usb

Re: [PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-02-29 Thread Daniel Kiper
On Mon, Feb 19, 2024 at 02:22:23PM +0800, Yifan Zhao wrote: > EROFS [1] is a lightweight read-only filesystem designed for performance > which has already been shipped in most Linux distributions as well as widely > used in several scenarios, such as Android system partitions, container > images, a

Re: [PATCH v4 rebased 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

2024-02-29 Thread Daniel Kiper
On Mon, Feb 19, 2024 at 02:22:24PM +0800, Yifan Zhao wrote: > In this patch, three tests of EROFS are introduced and they cover > compact, extended and chunk-based inodes, respectively. > > Signed-off-by: Yifan Zhao LGTM... Daniel ___ Grub-devel maili

Re: [PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-02-29 Thread Glenn Washburn
Hi Yifan, I would suggest that the next version of this series have a cover letter which includes the output of --range-diff or --interdiff (as appropriate). Cover letters for multipatch submissions are standard on this list. They allow the tracking of what changed in series revisions. Please see

Re: [PATCH 0/4] More ls improvements

2024-02-29 Thread Glenn Washburn
Hi Daniel, On Thu, 14 Sep 2023 16:44:46 +0200 Daniel Kiper wrote: > On Mon, Aug 14, 2023 at 01:57:06PM -0500, Glenn Washburn wrote: > > Currently when given a path to a file, ls will open the file to determine > > if its is valid and then run the appropriate print function, in contrast to > > di

Re: [PATCH v2] efi: Fix stack protector issues

2024-02-29 Thread Glenn Washburn
On Wed, 17 Jan 2024 06:10:29 +0300 "Vladimir 'phcoder' Serbinenko" wrote: > Looks good. A small comment inline > > > diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c > > index 731c07c29..5db504e6e 100644 > > --- a/grub-core/kern/main.c > > +++ b/grub-core/kern/main.c > > @@ -265,6 +265

[PATCH] disk/mdraid1x_linux: Prevent infinite recursion

2024-02-29 Thread Lidong Chen
The test corpus for version-1 RAID generated an infinite recursion in grub_partition_iterate() while attempting to read the superblock. The reason for the issue was that the data region overlapped with the superblock. The infinite call loop looks like this: grub_partition_iterate() -> partmap->ite

Re: [PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-02-29 Thread Gao Xiang
Hi Daniel, On 2024/3/1 01:59, Daniel Kiper wrote: On Mon, Feb 19, 2024 at 02:22:23PM +0800, Yifan Zhao wrote: EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as

Re: [PATCH v4 rebased 1/2] fs/erofs: Add support for EROFS

2024-02-29 Thread Gao Xiang
Hi Glenn, On 2024/3/1 04:52, Glenn Washburn wrote: Hi Yifan, I would suggest that the next version of this series have a cover letter which includes the output of --range-diff or --interdiff (as appropriate). Cover letters for multipatch submissions are standard on this list. They allow the tra