Re: [PATCH v8 08/22] protectors: Add key protectors framework

On Thu, Jan 18, 2024 at 03:02:19PM +0800, Gary Lin wrote: > On Wed, Jan 17, 2024 at 05:58:25AM +0300, Vladimir 'phcoder' Serbinenko wrote: > > Any strong reason to have it in kernel? It doesn't seem to be > > necessary in non-crypto cases. Separate module or cryptodisk looks > > like better places

[PATCH] util/grub.d/30_os-prober.in: Fix GRUB_OS_PROBER_SKIP_LIST for non-EFI

GRUB documentation states: 'GRUB_OS_PROBER_SKIP_LIST' List of space-separated FS UUIDs of filesystems to be ignored from os-prober output. For efi chainloaders it's @ But the actual behaviour does not match this description. Setting GRUB_OS_PROBER_SKIP_LIST="" does not ignore non-EFI boot

[PATCH v2] util/grub.d/30_os-prober.in: Skip drivemap for Windows 8 to 19, Server 2012 and later

If Windows Vista, Seven and Server 2008 do not need drivemap, then later versions using bootmgr should not need it either. This patch checks Windows versions up to 19 because distinguishing 20 from 2000 requires more complex logic. Hopefully Windows will drop legacy BIOS boot support before versio

[PATCH v2] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

On systems which support multiple boot platforms such as BIOS or EFI, it makes no sense to show menu entries which are not supported by the current boot platform. Menu entries generated from os-prober 'chain' boot type use boot sector chainloading which is supported by PC BIOS platform only. Show

[PATCH 0/3] Clean up unused values

Coverity listed three unused value bugs in the GRUB. These patches help clean up and remove these uneccessary bits of code. The Coverity bugs being addressed are: CID 428875 CID 428876 CID 428877 Alec Brown (3): fs/jfs.c: Clean up redundant code osdep/unix/getroot.c: Clean up redundan

[PATCH 3/3] loader/i386/multiboot_mbi.c: Clean up redundant code

In grub-core/loader/i386/multiboot_mbi.c, coverity spotted redundant code where the variable err was being set to GRUB_ERR_NONE and then being overwritten later without being used. Since this is unnecessary, we can remove the code that sets err to GRUB_ERR_NONE. Fixes: CID 428877 Signed-off-by: A

[PATCH 1/3] fs/jfs.c: Clean up redundant code

In grub-core/fs/jfs.c, coverity spotted redundant code where the pointer diro was being set to 0 and then being overwritten later without being used. Since this is unnecessary, we can remove the code that sets diro to 0. Fixes: CID 428876 Signed-off-by: Alec Brown --- grub-core/fs/jfs.c | 1 -

[PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

In grub-core/osdep/unix/getroot.c, coverity spotted redundant code where the double pointer os_dev was being set to 0 and then being overwritten later without being used. Since this is unnecessary, we can remove the code that sets os_dev to 0. Fixes: CID 428875 Signed-off-by: Alec Brown --- gru