In grub-core/osdep/unix/getroot.c, coverity spotted redundant code where the
double pointer os_dev was being set to 0 and then being overwritten later
without being used. Since this is unnecessary, we can remove the code that sets
os_dev to 0.

Fixes: CID 428875

Signed-off-by: Alec Brown <alec.r.br...@oracle.com>
---
 grub-core/osdep/unix/getroot.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/grub-core/osdep/unix/getroot.c b/grub-core/osdep/unix/getroot.c
index cde821eb9..12b111634 100644
--- a/grub-core/osdep/unix/getroot.c
+++ b/grub-core/osdep/unix/getroot.c
@@ -540,7 +540,6 @@ grub_guess_root_devices (const char *dir_in)
       for (cur = os_dev; *cur; cur++)
        free (*cur);
       free (os_dev);
-      os_dev = 0;
     }
 
   if (stat (dir, &st) < 0)
-- 
2.27.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to