Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Paul Menzel
Dear Mathieu, Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: The current implementation of the 10_linux script implements its menu items sorting in bash with a quadratic algorithm, calling "sed", "sort", head, and grep to compare versions between individual lines, which is annoyingly slow for

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mathieu Desnoyers
- On May 3, 2022, at 4:47 AM, Paul Menzel pmen...@molgen.mpg.de wrote: > Dear Mathieu, > > > Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: >> The current implementation of the 10_linux script implements its menu >> items sorting in bash with a quadratic algorithm, calling "sed", "sort", >>

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Paul Menzel
Dear Mathieu, Am 03.05.22 um 16:42 schrieb Mathieu Desnoyers: - On May 3, 2022, at 4:47 AM, Paul Menzel pmen...@molgen.mpg.de wrote: Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: The current implementation of the 10_linux script implements its menu items sorting in bash with a quadrat

[PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mathieu Desnoyers
The current implementation of the 10_linux script implements its menu items sorting in bash with a quadratic algorithm, calling "sed", "sort", head, and grep to compare versions between individual lines, which is annoyingly slow for kernel developers who can easily end up with 50-100 kernels in /bo

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mihai Moldovan
Just a nit, feel free to ignore it... * On 5/3/22 4:42 PM, Mathieu Desnoyers wrote: > How does the following paragraph sound ? > > > Here is the improved algorithm proposed: > > - Prepare a list with all the relevant information for ordering by a single > sort(1) execution. This is d

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Oskari Pirhonen
On Tue, May 03, 2022 at 07:15:47PM +0200, Mihai Moldovan wrote: > Just a nit, feel free to ignore it... > > > * On 5/3/22 4:42 PM, Mathieu Desnoyers wrote: > > How does the following paragraph sound ? > > > > > > Here is the improved algorithm proposed: > > > > - Prepare a list with al

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mihai Moldovan
* On 5/4/22 2:54 AM, Oskari Pirhonen wrote: > The existing `version_sort()` function in grub-mkconfig_lib.in uses the > same logic for detecting the existence of `sort -V` with a fallback to > `sort -n`. I don't think it adds any new hidden dependencies. Right, there are fallbacks in both places f