Just a nit, feel free to ignore it...
* On 5/3/22 4:42 PM, Mathieu Desnoyers wrote: > How does the following paragraph sound ? > > ^^^^^^^^ > Here is the improved algorithm proposed: > > - Prepare a list with all the relevant information for ordering by a single > sort(1) execution. This is done by renaming ".old" suffixes by " 1" and > by suffixing all other files with " 2", thus making sure the ".old" entries > will follow the non-old entries in reverse-sorted-order. > - Call version_reverse_sort on the list (sort -r -V): A single execution of > sort(1) will reverse-sort the list in O(n*log(n)) with a merge sort. This is correct for GNU coreutils's sort, but nothing (I'm mostly thinking of SUS/POSIX here) mandates that the sort utility must either use merge sort or have O(n*log(n)) time complexity. Given that you're using version sort, which is a GNU extension, it probably can't be anything than GNU sort anyway, though, so the point still holds by implicity. However, this also means that you're adding a hidden dependency upon GNU coreutils sort here, which will hit systems traditionally not using the GNU userland by default, most prominently BSDs (which, I might add, seem not to use GRUB by default and generally either discourage it or have thrown it out of their package management systems). Mihai
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
