On 12/15/20 1:36 PM, Daniel Kiper wrote:
[snip]
>
>> the unexpected build error.
>>
>> ../../grub-core/commands/efi/shim_lock.c:121:21: error: implicit declaration
>> of function ‘grub_efi_get_secureboot’; did you mean
>> ‘grub_efi_get_device_path’? [-Werror=implicit-function-declaration]
>>
On Tue, Dec 15, 2020 at 05:31:06PM -0600, Glenn Washburn wrote:
> The function grub_disk_native_sectors(source) returns the number of sectors
> of source in grub native (512-byte) sectors, not source sized sectors. So
> the conversion needs to use GRUB_DISK_SECTOR_BITS. the grub native sector
> siz
On Tue, Dec 15, 2020 at 05:31:07PM -0600, Glenn Washburn wrote:
> Check to make sure that source disk has a known size. If not, print debug
> message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is
> set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing
>
On Tue, Dec 15, 2020 at 05:31:08PM -0600, Glenn Washburn wrote:
> Do some sanity checking on data coming from the luks header. If segment.size
> is "dynamic", verify that the offset is not past the end of disk. Otherwise,
> check for errors from grub_strtoull when converting segment size from
> str
On Tue, Dec 15, 2020 at 05:31:09PM -0600, Glenn Washburn wrote:
> This patch is similiar to commit 9dab2f51e (sparc: Enable __clzsi2() and
> __clzdi2()) but for MIPS target and __clzdi2 only, __clzsi2 was already
> enabled.
>
> Suggested-by: Daniel Kiper
> Signed-off-by: Glenn Washburn
Reviewed-
On Tue, Dec 15, 2020 at 06:47:34PM -0600, Glenn Washburn wrote:
> Document the artificially imposed 1 EiB disk size limit and size limitations
> with LUKS volumes.
>
> Fix a few punctuation issues.
>
> Signed-off-by: Glenn Washburn
Reviewed-by: Daniel Kiper
Daniel
_
On Wed, 16 Dec 2020 13:38:16 +0100
Daniel Kiper wrote:
> On Tue, Dec 15, 2020 at 05:31:08PM -0600, Glenn Washburn wrote:
> > Do some sanity checking on data coming from the luks header. If
> > segment.size is "dynamic", verify that the offset is not past the
> > end of disk. Otherwise, check for
On Thu, 10 Dec 2020 10:14:53 +0100
Denis 'GNUtoo' Carikli wrote:
> Hi,
>
> I've addressed the issues found in the last round.
>
> Like the last time I also tested it on real hardware.
>
> I'm also sorry for the delay.
Great, thanks for the update. Since Grub is currently in a feature
freeze u
On Wed, 16 Dec 2020 12:35:13 -0600
Glenn Washburn wrote:
> Great, thanks for the update. Since Grub is currently in a feature
> freeze until the release, this won't get accepted until after.
At least, it makes it easier for someone else to pickup the patch set,
rebase it and push it if for a reaso
