On Tue, Dec 15, 2020 at 05:31:08PM -0600, Glenn Washburn wrote: > Do some sanity checking on data coming from the luks header. If segment.size > is "dynamic", verify that the offset is not past the end of disk. Otherwise, > check for errors from grub_strtoull when converting segment size from > string. If a GRUB_ERR_BAD_NUMBER error was returned, then the string was > not a valid parsable number, so skip the key. If GRUB_ERR_OUT_OF_RANGE was > returned, then there was an overflow in converting to a 64-bit unsigned > integer. So this could be a very large disk (perhaps large raid array). > In this case, we want to continue to try to use this key, but only allow > access up to the end of the source disk.
Last sentence looks wrong taking into account code below. I can fix it before committing... > Signed-off-by: Glenn Washburn <developm...@efficientek.com> Otherwise Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel