Re: [PATCH v4 08/15] luks2: Split idx into three variables: keyslot_key, digest_key, segment_key.

2020-11-17 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:48:37AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:28PM -0600, Glenn Washburn wrote: > > Introduce new variables keyslot_key, digest_key, and segment_key which > > represent the integer key of the item in the respective associative array > > when loo

Re: [PATCH v4 09/15] luks2: Improve error messages in luks2_get_keyslot.

2020-11-17 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:52:03AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:29PM -0600, Glenn Washburn wrote: > > Error messages now distinguish between indexes and keys. The former > > include "index" in the error string, and the later are surrounded in quotes. > > > > Sig

Re: [PATCH v4 12/15] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-11-17 Thread Daniel Kiper
On Fri, Nov 06, 2020 at 10:44:32PM -0600, Glenn Washburn wrote: > The total_length field is named confusingly because length usually refers to total_length? I think by mistake you left original commit message here. It is confusing right now. > bytes, whereas in this case its really the total numb

Re: [PATCH v4 14/15] luks2: Better error handling when setting up the cryptodisk.

2020-11-17 Thread Daniel Kiper
On Fri, Nov 06, 2020 at 10:44:34PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/disk/luks2.c | 70 +++--- > include/grub/misc.h| 2 ++ > 2 files changed, 67 insertions(+), 5 deletions(-) > > diff --git a/grub-core/disk/luk

Re: [PATCH v4 15/15] luks2: Error check segment.sector_size.

2020-11-17 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 11:42:24AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:35PM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > Reviewed-by: Patrick Steinhardt > > > --- > > grub-core/disk/luks2.c | 11 +++ > > 1 file changed, 11 insertions(+)

Re: [PATCH v4 00/15] Cryptodisk fixes for v2.06 redux

2020-11-17 Thread Daniel Kiper
Hey, On Fri, Nov 06, 2020 at 10:44:20PM -0600, Glenn Washburn wrote: > Here we go again. I have not added RB sigs to any patches since I've had to > modify them in moving them earlier in the patch set. This would be the first > three rename patches. The first two patches of v3 have been reworked

[PATCH] grub-mkpasswd-pbkdf2: Simplify the main function implementation

2020-11-17 Thread Tianjia Zhang
Allocate memory if needed, while saving the corresponding release operation, reducing the amount of code and code complexity. Signed-off-by: Tianjia Zhang --- util/grub-mkpasswd-pbkdf2.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/util/grub-mkpasswd-