On Fri, Nov 06, 2020 at 10:44:32PM -0600, Glenn Washburn wrote: > The total_length field is named confusingly because length usually refers to
total_length? I think by mistake you left original commit message here. It is confusing right now. > bytes, whereas in this case its really the total number of sectors on the > device. Also counter-intuitively, grub_disk_get_size returns the total > number of device native sectors. We need to convert the sectors from the > size of the underlying device to the cryptodisk sector size. And > segment.size is in bytes which need to be converted to cryptodisk sectors. > > Also, removed an empty statement. > > Signed-off-by: Glenn Washburn <developm...@efficientek.com> Otherwise patch LGTM. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
