Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

On Thu, Oct 29, 2020 at 02:53:34PM -0500, Glenn Washburn wrote: > On Tue, 27 Oct 2020 20:11:56 +0100 > Daniel Kiper wrote: > > On Sat, Oct 03, 2020 at 12:42:55AM -0500, Glenn Washburn wrote: > > > On Mon, 21 Sep 2020 13:23:04 +0200 > > > Daniel Kiper wrote: > > > > On Mon, Sep 21, 2020 at 06:28:2

Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt.

On Thu, Oct 29, 2020 at 04:51:37PM -0500, Glenn Washburn wrote: > On Tue, 27 Oct 2020 19:03:36 +0100 > Daniel Kiper wrote: > > On Mon, Oct 19, 2020 at 06:09:55PM -0500, Glenn Washburn wrote: [...] > > > diff --git a/include/grub/types.h b/include/grub/types.h > > > index 035a4b528..8b4267ebd 100

Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.

On Thu, Oct 29, 2020 at 04:52:55PM -0500, Glenn Washburn wrote: > On Fri, 23 Oct 2020 14:14:52 +0200 > Daniel Kiper wrote: > > On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > > > Introduce new variables keyslot_key, digest_key, and segment_key > > > which represent the integer ke

Re: [PATCH v3 06/10] cryptodisk: Properly handle non-512 byte sized sectors.

On Mon, Oct 19, 2020 at 06:09:54PM -0500, Glenn Washburn wrote: > By default, dm-crypt internally uses an IV that corresponds to 512-byte > sectors, even when a larger sector size is specified. What this means is > that when using a larger sector size, the IV is incremented every sector. > However,