On Thu, Oct 29, 2020 at 04:52:55PM -0500, Glenn Washburn wrote: > On Fri, 23 Oct 2020 14:14:52 +0200 > Daniel Kiper <dki...@net-space.pl> wrote: > > On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote: > > > Introduce new variables keyslot_key, digest_key, and segment_key > > > which represent the integer key of the item in the respective > > > associative array when looping over the array items. This replaces > > > using a generically named variable named "idx" used for all three > > > values. The parameter "i" is renamed to "keyslot_idx" and the loop > > > variable "j" is renamed to "i". Error messages now distinguish > > > between indexes and keys. The former include "index" in the error > > > string, and the later are surrounded in quotes. > > > > I think this patch does too many things in one step. Please do one > > rename per patch if possible. Additionally, I think this patch, or > > series of the patches, should be before current patch #1. > > > > Daniel > > Okay, I've split these two patches into 5 patches: > 5: luks2: Improve error messages in luks2_get_keyslot. > 4: luks2: Split idx into three variables: keyslot_key, digest_key, > segment_key. > 3: luks2: Rename index variable j to i. > 2: luks2: Rename variable i to keyslot_idx in luks2_get_keyslot. > 1: luks2: Use correct index variable when looping in luks2_get_keyslot.
LGTM... > I'm traveling the next few days and thinking that it would be best to > send these with the next iteration of the patch series which includes > some of the changes suggested for other patches. Yeah, that would be perfect. Thank you for doing the work. Have a nice weekend, Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
