Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06

Sep 17, 2020 8:14:40 AM Patrick Steinhardt : > On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: >> this is the third version of this patchset, collecting various fixes for >> LUKS2/cryptodisk for the upcoming release of GRUB v2.06. >> >> Besides my Reviewed-by tag, the only thin

Re: [PATCH v3 9/9] cryptodisk: Properly handle non-512 byte sized sectors

Sep 9, 2020 5:22:11 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:28:08PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn >> >> By default, dm-crypt internally uses an IV that corresponds to 512-byte >> sectors, even when a larger sector size is specified. What this means is >> that whe

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

Sep 8, 2020 7:21:31 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn >> >> The total_length field is named confusingly because length usually refers to >> bytes, whereas in this case its really the total number of sectors on the >> de

Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages

Sep 8, 2020 6:58:48 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn > > It seems to me this patch should be split into two and and begs for > commit message improvement. In general it would be nice to know why > we need these fixes.

Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module

Sep 8, 2020 7:28:13 AM Daniel Kiper : > On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote: >> From: Glenn Washburn >> >> Signed-off-by: Glenn Washburn >> Reviewed-by: Patrick Steinhardt >> --- >> grub-core/disk/cryptodisk.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --g