Sep 8, 2020 6:58:48 AM Daniel Kiper <daniel.ki...@oracle.com>:

> On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote:
>> From: Glenn Washburn <developm...@efficientek.com>
>
> It seems to me this patch should be split into two and and begs for
> commit message improvement. In general it would be nice to know why
> we need these fixes.

This patch is doing two things, fixing a bug and making the code more 
understandable. My original patch just fixed the bug, then Patrick suggested 
making it more readable. I can split it into two patches.

The bug it's fixing is that the keyslot index variable was being used to index 
the digests and segments, whereas the digest and segment index variables should 
be used to index their respective json arrays.

Glenn


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to