Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

2020-09-18 Thread Paul Menzel
Dear Glenn, Am 29.08.20 um 01:30 schrieb Glenn Washburn: LODEVICES is not an array variable and should not be accessed as such. This allows the f2fs test to pass as it was failing because a device name had a space prepended to the path. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-t

Re: [PATCH] tpm: Remove unused functions and structures

2020-09-18 Thread Daniel Kiper
On Wed, Jul 29, 2020 at 09:31:14PM +0800, Tianjia Zhang wrote: > Although the tpm_execute() series of functions are defined, they > are not used anywhere, and several structures in the header file > `tpm.h` are also not used. Delete them here. > > Signed-off-by: Tianjia Zhang Reviewed-by: Daniel

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-18 Thread Daniel Kiper
On Fri, Sep 18, 2020 at 01:08:15PM +0800, Tianjia Zhang wrote: > Hi, > > On 9/17/20 10:58 PM, Daniel Kiper wrote: > > On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote: > > > Like tpm, the module is only enabled for x86_64, but there's nothing > > > specific to x86_64 in the implementat

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-18 Thread John Paul Adrian Glaubitz
On 9/18/20 11:38 PM, Daniel Kiper wrote: >> It is tested on x86_64-efi and arm64-efi platforms. I don’t have an >> environment for x86 32-bit EFI, and I haven’t tested on this platform. > > It looks that this patch does not break any builds. So, I took it. Don't forget ia64 is an EFI platform as