Re: [PATCH] Fix packed-not-aligned error on GCC 8

2018-03-26 Thread Michael Chang
When building with GCC 8, there are several errors regarding packed-not-aligned. ./include/grub/gpt_partition.h:79:1: error: alignment 1 of ‘struct grub_gpt_partentry’ is less than 8 [-Werror=packed-not-aligned] This patch tries to fix the build error by cleaning up the ambiguity of placing alig

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-26 Thread John Lane
On 22/03/18 14:22, TJ wrote: > On 22/03/18 12:38, Daniel Kiper wrote: >> Hi John, >> >> On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: >>> On 14/03/18 13:05, Daniel Kiper wrote: On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > From: John Lane I have just

Re: [PATCH] Fix packed-not-aligned error on GCC 8

2018-03-26 Thread Daniel Kiper
On Mon, Mar 26, 2018 at 04:52:34PM +0800, Michael Chang wrote: > When building with GCC 8, there are several errors regarding > packed-not-aligned. > > ./include/grub/gpt_partition.h:79:1: error: alignment 1 of ???struct > grub_gpt_partentry??? is less than 8 [-Werror=packed-not-aligned] > > This

Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

2018-03-26 Thread Daniel Kiper
On Thu, Mar 22, 2018 at 08:17:53PM -0700, Nick Vinson wrote: > On 03/22/2018 06:56 AM, Daniel Kiper wrote: > > On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote: > >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > >> partuuid target. Update grub.texi documenati

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-26 Thread Daniel Kiper
On Mon, Mar 26, 2018 at 02:10:48PM +0100, John Lane wrote: > On 22/03/18 14:22, TJ wrote: > > On 22/03/18 12:38, Daniel Kiper wrote: > >> Hi John, > >> > >> On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: > >>> On 14/03/18 13:05, Daniel Kiper wrote: > On Wed, Mar 14, 2018 at 09:44:5

Re: Grub website issues

2018-03-26 Thread Daniel Kiper
On Wed, Mar 14, 2018 at 01:47:20PM +0100, Daniel Kiper wrote: > Hi Samuel, > > On Sun, Mar 11, 2018 at 09:56:57PM +0100, Samuel Thibault wrote: > > Hello, > > > > There are a few issues on the grub website on > > https://www.gnu.org/software/grub/grub-development.html > > > > The page says it is ma

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-26 Thread Daniel Kiper
On Thu, Mar 22, 2018 at 08:14:50PM +0100, Samuel Thibault wrote: > Daniel Kiper, on jeu. 22 mars 2018 15:16:46 +0100, wrote: > > On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > > > @@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)' > > > --class hurd --cla

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-26 Thread Daniel Kiper
On Fri, Mar 23, 2018 at 02:11:33PM -0500, Mike Travis wrote: > A GPU inserted into a PCIe I/O slot disappears during system startup. > The problem centers around GRUB and a specific VGA init function in > efi_uga.c. This causes an LER (link error recorvery) because the MMIO > memory has not been e

[GRUB PARTUUID PATCH V7 2/4] Update grub_gpt_partentry

2018-03-26 Thread Nicholas Vinson
Rename grub_gpt_part_type to grub_gpt_part_guid and update grub_gpt_partentry to use this type for both the partition type GUID string and the partition GUID string entries. This change ensures that the two GUID fields are handled more consistently and helps to simplify the changes needed to add L

[GRUB PARTUUID PATCH V7 0/4] Add PARTUUID detection support

2018-03-26 Thread Nicholas Vinson
Changes from Patch v6: - Corrected spelling and grammatical errors in description text for GRUB_ENABLE_LINUX_PARTUUID - Moved disk->partition save & restore logic to beginning and end of probe_partuuid() - Fixed formatting errors in probe_partuuid Changes from Patch v5:

[GRUB PARTUUID PATCH V7 1/4] Centralize guid prints

2018-03-26 Thread Nicholas Vinson
Define print_gpt_guid(), so there is a central function for printing GUID strings. This change is a precursor for later patches which rely on this logic. Signed-off-by: Nicholas Vinson --- util/grub-probe.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-)

[GRUB PARTUUID PATCH V7 4/4] Update grub script template files

2018-03-26 Thread Nicholas Vinson
Update grub-mkconfig.in and 10_linux.in to support grub-probe's new partuuid target. Update grub.texi documenation. Signed-off-by: Nicholas Vinson --- docs/grub.texi | 9 + util/grub-mkconfig.in | 3 +++ util/grub.d/10_linux.in | 12 +--- 3 files changed, 21 inserti

[GRUB PARTUUID PATCH V7 3/4] Add PARTUUID detection support to grub-probe

2018-03-26 Thread Nicholas Vinson
Add PARTUUID detection support grub-probe for MBR and GPT partition schemes. Signed-off-by: Nicholas Vinson --- util/grub-probe.c | 48 1 file changed, 48 insertions(+) diff --git a/util/grub-probe.c b/util/grub-probe.c index 21cb80fbe..48ef1e2ec