On Mon, Mar 26, 2018 at 02:10:48PM +0100, John Lane wrote: > On 22/03/18 14:22, TJ wrote: > > On 22/03/18 12:38, Daniel Kiper wrote: > >> Hi John, > >> > >> On Wed, Mar 14, 2018 at 07:00:11PM +0000, John Lane wrote: > >>> On 14/03/18 13:05, Daniel Kiper wrote: > >>>> On Wed, Mar 14, 2018 at 09:44:58AM +0000, John Lane wrote: > >>>>> From: John Lane <j...@lane.uk.net> > >>>> > >>>> I have just skimmed through the series. First of all, most if not > >>>> all patches beg for full blown commit messages. Just vague statements > >>>> in the subject are insufficient for me. And please add patch 0 which > >>>> introduces the series. git send-email --compose is your friend. > >>>> > >>>> Daniel > >>>> > >>> > >>> Sorry Daniel, this isn't something I do that often - submitting patches > >> > >> Not a problem. > >> > >>> to ML. Do you want me to resubmit them again, or is the below ok for you ? > >> > >> Please resubmit whole patch series and do not forget to take into > >> account comments posted by others. > >> > >> Daniel > > > > I've spent a couple of days doing a thorough review of this patch series. > > > > Firstly I want to say a big thanks to John for bringing this along - > > it's long been a large missing piece of the LUKS support. > > Thanks for that. I will take a look at the below and try and work a > patch series as you suggest. But it might take a few days to find some > time to dedicate to it, due to other commitments I have right now. > > I'll report back when I have something to show.
Not a problem, we how it works. We are patiently looking forward for the patches. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
