[PATCH v2] Add hidden menu entries

2016-04-28 Thread Alexander Graf
The menu infrastructure is quite powerful. It allows you to define menu entries that can contain arbitrary grub commands that can do a lot more than just boot kernel entries. For some of these it makes sense to hide them inside the normal menu though and instead have them available through hotkeys

[PATCH] Rewrite and fix grub_bufio_read()

2016-04-28 Thread Stefan Fritsch
We had problems downloading large (10-100 MB) gziped files via http with grub. After some debugging, I think I have found the reason in grub_bufio_read, which leads to wrong data being passed on. This patch fixes the issues for me. I did my tests with a somewhat older snapshot, but the bufio.c fil

How to receive notification of a new (disk) device being connected?

2016-04-28 Thread TJ
I'm currently finalising a patch that adds key-file support to cryptodisk::cryptomount and luks. As well as being able to grub_device_iterate(hook,...) to search the existing devices for the key-file the code needs to wait for TIMEOUT seconds for additional (usually USB Mass Storage) devices t

Re: [PATCH] Rewrite and fix grub_bufio_read()

2016-04-28 Thread Andrei Borzenkov
28.04.2016 14:11, Stefan Fritsch пишет: > We had problems downloading large (10-100 MB) gziped files via http > with grub. After some debugging, I think I have found the reason in > grub_bufio_read, which leads to wrong data being passed on. This patch > fixes the issues for me. I did my tests wit

Re: How to receive notification of a new (disk) device being connected?

2016-04-28 Thread Andrei Borzenkov
28.04.2016 16:03, TJ пишет: > I'm currently finalising a patch that adds key-file support to > cryptodisk::cryptomount and luks. > > As well as being able to grub_device_iterate(hook,...) to search the > existing devices for the key-file the code needs to wait for TIMEOUT > seconds for additional

Re: [PATCH v2] Add hidden menu entries

2016-04-28 Thread Andrei Borzenkov
28.04.2016 14:14, Alexander Graf пишет: > The menu infrastructure is quite powerful. It allows you to define menu > entries that can contain arbitrary grub commands that can do a lot more > than just boot kernel entries. > > For some of these it makes sense to hide them inside the normal menu > th

Re: [PATCH 1/2] misc: fix invalid character recongition in strto*l

2016-04-28 Thread Andrei Borzenkov
28.04.2016 03:53, Aaron Miller пишет: > Would previously allow digits larger than the base and didn't check that > subtracting the difference from 0-9 to lowercase letters for characters > larger than 9 didn't result in a value lower than 9, which allowed the > parses: ` = 9, _ = 8, ^ = 7, ] = 6, \

[PATCH] efi term: open input console exlusively

2016-04-28 Thread Josef Bacik
We've had issues with a bunch of our EFI machines getting random console input from God knows where. This stops our provisioning because the timeout countdown stops as it thinks we pressed a button, which we most certaintly did not. So open the input console in exclusive mode to make sure only th

Re: [PATCH] Rewrite and fix grub_bufio_read()

2016-04-28 Thread Stefan Fritsch
On Thu, 28 Apr 2016, Andrei Borzenkov wrote: > 28.04.2016 14:11, Stefan Fritsch пишет: > > We had problems downloading large (10-100 MB) gziped files via http > > with grub. After some debugging, I think I have found the reason in > > grub_bufio_read, which leads to wrong data being passed on. Thi

gzio/http problem (was: [PATCH] Rewrite and fix grub_bufio_read())

2016-04-28 Thread Stefan Fritsch
On Thursday 28 April 2016 21:52:27, Stefan Fritsch wrote: > You are right, I was misreading the second part of the code with > the direct read. Now I wonder why the patch helped with our > problem. I will do some more debugging. The real problem seems to be that http sometimes (depending on netwo

Re: [PATCH] verify: search keyid in hashed signature subpackets

2016-04-28 Thread Ignat Korchagin
Is this going to 2.02? I think it should, because it is a bug. On Thu, Apr 21, 2016 at 5:54 PM, Ignat Korchagin wrote: > Best of both worlds: I left the READBUF_SIZE as is for the rest of the code, > but rather reallocate the buffer with appropriate length for subpackets > specifically. Hashing

Re: gzio/http problem (was: [PATCH] Rewrite and fix grub_bufio_read())

2016-04-28 Thread Vladimir 'phcoder' Serbinenko
HTTP code should never return short reads. The whole subsystem relies on never having short reads from any fs or network driver Le ven. 29 avr. 2016 09:30, Stefan Fritsch a écrit : > On Thursday 28 April 2016 21:52:27, Stefan Fritsch wrote: > > You are right, I was misreading the second part of

Re: [PATCH] Rewrite and fix grub_bufio_read()

2016-04-28 Thread Andrei Borzenkov
28.04.2016 22:52, Stefan Fritsch пишет: > On Thu, 28 Apr 2016, Andrei Borzenkov wrote: > >> 28.04.2016 14:11, Stefan Fritsch пишет: >>> We had problems downloading large (10-100 MB) gziped files via http >>> with grub. After some debugging, I think I have found the reason in >>> grub_bufio_read, w

Re: gzio/http problem

2016-04-28 Thread Andrei Borzenkov
29.04.2016 00:54, Vladimir 'phcoder' Serbinenko пишет: > HTTP code should never return short reads. The whole subsystem relies on > never having short reads from any fs or network driver > HTTP code never returns short reads itself. But it sets EOF on socket in case something bad happens, and in