HTTP code should never return short reads. The whole subsystem relies on
never having short reads from any fs or network driver

Le ven. 29 avr. 2016 09:30, Stefan Fritsch <s...@sfritsch.de> a écrit :

> On Thursday 28 April 2016 21:52:27, Stefan Fritsch wrote:
> > You are right, I was misreading the second part of the code with
> > the  direct read. Now I wonder why the patch helped with our
> > problem. I will do some more debugging.
>
> The real problem seems to be that http sometimes (depending on network
> timing?) returns short reads but gzio does not check how many bytes
> have actually been read. The looping in my patch for grub_bufio_read()
> fixed this by never returning a short read.
>
> I guess two things should be fixed: gzio should check the return value
> of grub_file_read(), and (assuming that other code depends on there
> not being short reads, too) http should be fixed. Or maybe
> grub_file_read() should get a loop that ensures that there are no
> short reads?
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to